heap: Use default constructor for v8::EmbedderRootsHandler [chromium/src : main]

0 views
Skip to first unread message

Michael Lippautz (Gerrit)

unread,
Jun 12, 2024, 3:04:05 AMJun 12
to Dominik Inführ, Chromium LUCI CQ, Omer Katz, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Dominik Inführ and Omer Katz

Michael Lippautz voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dominik Inführ
  • Omer Katz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifb929a1a5a413f6fe0c90f7bed91f60dbf436c88
Gerrit-Change-Number: 5622172
Gerrit-PatchSet: 4
Gerrit-Owner: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Dominik Inführ <dinf...@chromium.org>
Gerrit-Attention: Omer Katz <omer...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Jun 2024 07:03:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Omer Katz (Gerrit)

unread,
Jun 12, 2024, 3:17:42 AMJun 12
to Dominik Inführ, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Dominik Inführ

Omer Katz voted and added 1 comment

Votes added by Omer Katz

Code-Review+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Dominik Inführ
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifb929a1a5a413f6fe0c90f7bed91f60dbf436c88
Gerrit-Change-Number: 5622172
Gerrit-PatchSet: 4
Gerrit-Owner: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Dominik Inführ <dinf...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Jun 2024 07:17:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Dominik Inführ (Gerrit)

unread,
Jun 12, 2024, 4:28:55 AMJun 12
to Omer Katz, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org

Dominik Inführ voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifb929a1a5a413f6fe0c90f7bed91f60dbf436c88
Gerrit-Change-Number: 5622172
Gerrit-PatchSet: 4
Gerrit-Owner: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Jun 2024 08:28:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 12, 2024, 5:31:18 AMJun 12
to Dominik Inführ, Omer Katz, Michael Lippautz, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
heap: Use default constructor for v8::EmbedderRootsHandler

kDontQueryEmbedderForAnyReference is the default now for
v8::EmbedderRootsHandler and so we can use the default ctor.
Bug: 340098917
Change-Id: Ifb929a1a5a413f6fe0c90f7bed91f60dbf436c88
Reviewed-by: Omer Katz <omer...@chromium.org>
Commit-Queue: Dominik Inführ <dinf...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1313883}
Files:
  • M third_party/blink/renderer/platform/heap/thread_state.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Omer Katz, +1 by Michael Lippautz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifb929a1a5a413f6fe0c90f7bed91f60dbf436c88
Gerrit-Change-Number: 5622172
Gerrit-PatchSet: 5
Gerrit-Owner: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages