Remove WTF:: aliases for wtf/hash_traits.h [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Jul 29, 2025, 3:34:00 AMJul 29
to Kent Tamura, Fredrik Söderquist, chromium...@chromium.org, Chromium LUCI CQ, Raphael Kubo da Costa, (Julie)Jeongeun Kim, Kevin Babbitt, Dirk Schulze, Kentaro Hara, Stephen Chenney, Olga Gerchikov, Alexis Menard, AyeAye, apavlo...@chromium.org, aleventhal...@chromium.org, fmalit...@chromium.org, drott+bl...@chromium.org, fserb...@chromium.org, hiroshig...@chromium.org, dtseng...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, blink-rev...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, blink-...@chromium.org, kouhe...@chromium.org, blink-re...@chromium.org, dominicc+...@chromium.org, dom+...@chromium.org, devtools-re...@chromium.org, yuzo+...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, abigailbk...@google.com, blink-re...@chromium.org, web-schedulin...@chromium.org, kouhei...@chromium.org, mattreyno...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, lucasrada...@google.com, antoniosartori+wa...@chromium.org, oilpan-rev...@chromium.org, feature-v...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, blink-revi...@chromium.org
Attention needed from Fredrik Söderquist

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Kent Tamura . resolved

fs@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib306c0bf37f9b896e880f2b18d3c857235ada1b1
Gerrit-Change-Number: 6795724
Gerrit-PatchSet: 2
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Tue, 29 Jul 2025 07:33:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Jul 29, 2025, 4:15:23 AMJul 29
to Kent Tamura, chromium...@chromium.org, Chromium LUCI CQ, Raphael Kubo da Costa, (Julie)Jeongeun Kim, Kevin Babbitt, Dirk Schulze, Kentaro Hara, Stephen Chenney, Olga Gerchikov, Alexis Menard, AyeAye, apavlo...@chromium.org, aleventhal...@chromium.org, fmalit...@chromium.org, drott+bl...@chromium.org, fserb...@chromium.org, hiroshig...@chromium.org, dtseng...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, blink-rev...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, blink-...@chromium.org, kouhe...@chromium.org, blink-re...@chromium.org, dominicc+...@chromium.org, dom+...@chromium.org, devtools-re...@chromium.org, yuzo+...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, abigailbk...@google.com, blink-re...@chromium.org, web-schedulin...@chromium.org, kouhei...@chromium.org, mattreyno...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, lucasrada...@google.com, antoniosartori+wa...@chromium.org, oilpan-rev...@chromium.org, feature-v...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, blink-revi...@chromium.org
Attention needed from Kent Tamura

Fredrik Söderquist voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib306c0bf37f9b896e880f2b18d3c857235ada1b1
    Gerrit-Change-Number: 6795724
    Gerrit-PatchSet: 2
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Tue, 29 Jul 2025 08:15:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 29, 2025, 4:20:51 AMJul 29
    to Kent Tamura, Fredrik Söderquist, chromium...@chromium.org, Raphael Kubo da Costa, (Julie)Jeongeun Kim, Kevin Babbitt, Dirk Schulze, Kentaro Hara, Stephen Chenney, Olga Gerchikov, Akihiro Ota, Alexis Menard, AyeAye, apavlo...@chromium.org, aleventhal...@chromium.org, fmalit...@chromium.org, drott+bl...@chromium.org, fserb...@chromium.org, hiroshig...@chromium.org, dtseng...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, blink-rev...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, blink-...@chromium.org, kouhe...@chromium.org, blink-re...@chromium.org, dominicc+...@chromium.org, dom+...@chromium.org, devtools-re...@chromium.org, yuzo+...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, abigailbk...@google.com, blink-re...@chromium.org, web-schedulin...@chromium.org, kouhei...@chromium.org, mattreyno...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, lucasrada...@google.com, antoniosartori+wa...@chromium.org, oilpan-rev...@chromium.org, feature-v...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, blink-revi...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Remove WTF:: aliases for wtf/hash_traits.h

    This CL has no behavior changes.
    Bug: 422768753
    Change-Id: Ib306c0bf37f9b896e880f2b18d3c857235ada1b1
    Auto-Submit: Kent Tamura <tk...@chromium.org>
    Commit-Queue: Fredrik Söderquist <f...@opera.com>
    Reviewed-by: Fredrik Söderquist <f...@opera.com>
    Cr-Commit-Position: refs/heads/main@{#1493347}
    Files:
    • M third_party/blink/renderer/bindings/core/v8/boxed_v8_module_test.cc
    • M third_party/blink/renderer/bindings/core/v8/profiler_trace_builder.h
    • M third_party/blink/renderer/bindings/core/v8/v8_code_cache.cc
    • M third_party/blink/renderer/core/accessibility/blink_ax_event_intent.h
    • M third_party/blink/renderer/core/animation/property_handle.cc
    • M third_party/blink/renderer/core/canvas_interventions/canvas_interventions_helper.cc
    • M third_party/blink/renderer/core/css/css_property_name.cc
    • M third_party/blink/renderer/core/css/css_property_value_set.h
    • M third_party/blink/renderer/core/css/css_value_pool.h
    • M third_party/blink/renderer/core/css/resolver/matched_properties_cache.cc
    • M third_party/blink/renderer/core/dom/node_lists_node_data.h
    • M third_party/blink/renderer/core/dom/weak_identifier_map.h
    • M third_party/blink/renderer/core/frame/font_matching_metrics.h
    • M third_party/blink/renderer/core/html/anchor_element_metrics.cc
    • M third_party/blink/renderer/core/html/custom/custom_element_descriptor.h
    • M third_party/blink/renderer/core/inspector/inspector_diff.h
    • M third_party/blink/renderer/core/inspector/inspector_preload_agent.cc
    • M third_party/blink/renderer/core/inspector/invalidation_set_to_selector_map.h
    • M third_party/blink/renderer/core/inspector/legacy_dom_snapshot_agent.cc
    • M third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
    • M third_party/blink/renderer/core/scheduler/scripted_idle_task_controller.h
    • M third_party/blink/renderer/core/script/module_record_resolver_impl.cc
    • M third_party/blink/renderer/core/svg/svg_element.h
    • M third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
    • M third_party/blink/renderer/modules/gamepad/navigator_gamepad.h
    • M third_party/blink/renderer/modules/webcodecs/video_frame_monitor.h
    • M third_party/blink/renderer/modules/xr/xr_frame_request_callback_collection.h
    • M third_party/blink/renderer/platform/fonts/fallback_list_composite_key.h
    • M third_party/blink/renderer/platform/fonts/shaping/shape_cache.h
    • M third_party/blink/renderer/platform/heap/collection_support/heap_hash_table_backing.h
    • M third_party/blink/renderer/platform/heap/heap_test_objects.h
    • M third_party/blink/renderer/platform/heap/test/heap_compact_test.cc
    • M third_party/blink/renderer/platform/network/blink_schemeful_site.h
    • M third_party/blink/renderer/platform/network/ip_address_test.cc
    • M third_party/blink/renderer/platform/network/network_state_notifier.cc
    • M third_party/blink/renderer/platform/privacy_budget/identifiability_digest_helpers.cc
    • M third_party/blink/renderer/platform/storage/blink_storage_key_hash.h
    • M third_party/blink/renderer/platform/weborigin/kurl.h
    • M third_party/blink/renderer/platform/weborigin/security_origin.h
    • M third_party/blink/renderer/platform/weborigin/security_origin_test.cc
    • M third_party/blink/renderer/platform/wtf/hash_traits.h
    Change size: M
    Delta: 41 files changed, 76 insertions(+), 97 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Fredrik Söderquist
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib306c0bf37f9b896e880f2b18d3c857235ada1b1
    Gerrit-Change-Number: 6795724
    Gerrit-PatchSet: 3
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages