[M144-LTS] blink: Make HeapBarrierCallback thread-safe by default [chromium/src : refs/branch-heads/7559]
0 views
Skip to first unread message
Gyuyoung Kim (xWF) (Gerrit)
May 28, 2026, 2:27:58 AM (3 days ago) May 28
to Eugene Zemtsov, Nate Chapin, Fahad Mansoor, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Kentaro Hara, kouhe...@chromium.org, blink-...@chromium.org, oilpan-rev...@chromium.org, kinuko...@chromium.org
Attention needed from Eugene Zemtsov, Fahad Mansoor and Nate Chapin
Gyuyoung Kim (xWF) added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Gyuyoung Kim (xWF) . resolved
The bug was approved for M144 LTS. PTAL.
Related details
Attention is currently required from:
- Eugene Zemtsov
- Fahad Mansoor
- Nate Chapin
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fahad Mansoor (Gerrit)
May 28, 2026, 3:01:00 AM (3 days ago) May 28
to Gyuyoung Kim (xWF), Eugene Zemtsov, Nate Chapin, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Kentaro Hara, kouhe...@chromium.org, blink-...@chromium.org, oilpan-rev...@chromium.org, kinuko...@chromium.org
Attention needed from Eugene Zemtsov, Gyuyoung Kim (xWF) and Nate Chapin
Fahad Mansoor voted and added 1 comment![]( "Open in Gerrit")
Votes added by Fahad Mansoor
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Eugene Zemtsov
- Gyuyoung Kim (xWF)
- Nate Chapin
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Chapin (Gerrit)
May 28, 2026, 1:37:00 PM (3 days ago) May 28
to Gyuyoung Kim (xWF), Eugene Zemtsov, Fahad Mansoor, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Kentaro Hara, kouhe...@chromium.org, blink-...@chromium.org, oilpan-rev...@chromium.org, kinuko...@chromium.org
Attention needed from Eugene Zemtsov and Gyuyoung Kim (xWF)
Nate Chapin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Eugene Zemtsov
- Gyuyoung Kim (xWF)
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (xWF) (Gerrit)
May 28, 2026, 10:31:21 PM (2 days ago) May 28
to Eugene Zemtsov, Nate Chapin, Fahad Mansoor, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Kentaro Hara, kouhe...@chromium.org, blink-...@chromium.org, oilpan-rev...@chromium.org, kinuko...@chromium.org
Attention needed from Eugene Zemtsov and Gyuyoung Kim (xWF)
Gyuyoung Kim (xWF) removed a vote from this change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Eugene Zemtsov
- Gyuyoung Kim (xWF)
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (xWF) (Gerrit)
May 28, 2026, 10:31:38 PM (2 days ago) May 28
to Eugene Zemtsov, Nate Chapin, Fahad Mansoor, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Kentaro Hara, kouhe...@chromium.org, blink-...@chromium.org, oilpan-rev...@chromium.org, kinuko...@chromium.org
Attention needed from Eugene Zemtsov
Gyuyoung Kim (xWF) voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 29, 2026, 12:25:59 AM (2 days ago) May 29
to Gyuyoung Kim (xWF), Eugene Zemtsov, Nate Chapin, Fahad Mansoor, android-bu...@system.gserviceaccount.com, Kentaro Hara, kouhe...@chromium.org, blink-...@chromium.org, oilpan-rev...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[M144-LTS] blink: Make HeapBarrierCallback thread-safe by default
HeapBarrierCallback was using Persistent to store aggregated results.
Since Persistent handles are thread-affine, destroying or clearing them
on another thread (e.g. when a PostTask fails due to worker thread
shutdown) results in free-list corruption of the calling thread's
PersistentRegion.
This change replaces Persistent with UnwrappingCrossThreadHandle to
ensure safe cross-thread destruction while strictly enforcing that the
underlying vector is only dereferenced on its creation thread,
preventing data races.
(cherry picked from commit 6fd20a57fccfaf70f2b472c7f1246033011af527)
Bug: 514715455
Change-Id: I44930a8d0d742a6194c6380c7b94abc8cf03dab7
Reviewed-by: Nate Chapin <jap...@chromium.org>
Commit-Queue: Eugene Zemtsov <eug...@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1633752}
Reviewed-by: Fahad Mansoor <fahadm...@google.com>
Commit-Queue: Gyuyoung Kim (xWF) <qk...@google.com>
Cr-Commit-Position: refs/branch-heads/7559@{#4914}
Cr-Branched-From: 223dfbac1c7542a06b422390d954afe5b560b607-refs/heads/main@{#1552494}
Files:
- M third_party/blink/renderer/platform/heap/heap_barrier_callback.h
Change size: S
Delta: 1 file changed, 7 insertions(+), 5 deletions(-)
Branch: refs/branch-heads/7559
Submit Requirements:
Code-Review: +1 by Nate Chapin, +1 by Fahad Mansoor
Lint: +0 by android-bu...@system.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages