Move wtf/hash_table.h and wtf/key_value_pair.h to "blink" namespace [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Jul 16, 2025, 9:29:52 PMJul 16
to Kent Tamura, Koji Ishii, Alexis Menard, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Chromium LUCI CQ, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Koji Ishii

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Kent Tamura . resolved

kojii@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Koji Ishii
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia5b4f5d97c1e7c5c23d6a6f3f6e44384e8f64c3b
Gerrit-Change-Number: 6763155
Gerrit-PatchSet: 2
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Koji Ishii <ko...@chromium.org>
Gerrit-Comment-Date: Thu, 17 Jul 2025 01:29:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Koji Ishii (Gerrit)

unread,
Jul 17, 2025, 4:18:44 AMJul 17
to Kent Tamura, Alexis Menard, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Chromium LUCI CQ, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Kent Tamura

Koji Ishii voted and added 1 comment

Votes added by Koji Ishii

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia5b4f5d97c1e7c5c23d6a6f3f6e44384e8f64c3b
    Gerrit-Change-Number: 6763155
    Gerrit-PatchSet: 3
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Thu, 17 Jul 2025 08:18:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 17, 2025, 4:23:42 AMJul 17
    to Kent Tamura, Koji Ishii, Alexis Menard, chromium...@chromium.org, Kentaro Hara, Nate Chapin, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading...@chromium.org, oilpan-rev...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Move wtf/hash_table.h and wtf/key_value_pair.h to "blink" namespace

    * This CL removes `WTF::swap`, which is an alias of `std::swap`.
      It's not used.

    This CL has no behavior changes.
    Bug: 422768753
    Change-Id: Ia5b4f5d97c1e7c5c23d6a6f3f6e44384e8f64c3b
    Commit-Queue: Koji Ishii <ko...@chromium.org>
    Reviewed-by: Koji Ishii <ko...@chromium.org>
    Auto-Submit: Kent Tamura <tk...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1488101}
    Files:
    • M third_party/blink/renderer/core/css/rule_set.h
    • M third_party/blink/renderer/core/html/forms/radio_button_group_scope.cc
    • M third_party/blink/renderer/core/loader/anchor_element_interaction_tracker.cc
    • M third_party/blink/renderer/platform/heap/collection_support/heap_hash_table_backing.h
    • M third_party/blink/renderer/platform/heap/heap_allocator_impl.h
    • M third_party/blink/renderer/platform/heap/trace_traits.h
    • M third_party/blink/renderer/platform/wtf/hash_map.h
    • M third_party/blink/renderer/platform/wtf/hash_map_test.cc
    • M third_party/blink/renderer/platform/wtf/hash_set.h
    • M third_party/blink/renderer/platform/wtf/hash_table.h
    • M third_party/blink/renderer/platform/wtf/key_value_pair.h
    • M third_party/blink/renderer/platform/wtf/type_traits.h
    • M third_party/blink/tools/gdb/blink.py
    • M third_party/blink/tools/lldb/lldb_blink.py
    • M tools/win/DebugVisualizers/blink.natvis
    Change size: M
    Delta: 15 files changed, 55 insertions(+), 57 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Koji Ishii
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia5b4f5d97c1e7c5c23d6a6f3f6e44384e8f64c3b
    Gerrit-Change-Number: 6763155
    Gerrit-PatchSet: 4
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages