[cleanup] Delete test-only CppHeapPointerTable method [v8/v8 : main]

0 views
Skip to first unread message

Andreas Haas (Gerrit)

unread,
Oct 14, 2025, 12:48:44 PM (7 days ago) Oct 14
to Michael Lippautz, V8 LUCI CQ, AyeAye, oilpan-r...@chromium.org
Attention needed from Michael Lippautz

Andreas Haas added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Andreas Haas . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I79290034ea3cdf9bb360c843ad3767bd6b1861b3
Gerrit-Change-Number: 7040944
Gerrit-PatchSet: 1
Gerrit-Owner: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Tue, 14 Oct 2025 16:48:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
Oct 15, 2025, 3:47:09 AM (6 days ago) Oct 15
to Andreas Haas, V8 LUCI CQ, AyeAye, oilpan-r...@chromium.org
Attention needed from Andreas Haas

Michael Lippautz voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andreas Haas
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I79290034ea3cdf9bb360c843ad3767bd6b1861b3
Gerrit-Change-Number: 7040944
Gerrit-PatchSet: 1
Gerrit-Owner: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Attention: Andreas Haas <ah...@chromium.org>
Gerrit-Comment-Date: Wed, 15 Oct 2025 07:46:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Andreas Haas (Gerrit)

unread,
Oct 15, 2025, 4:31:56 AM (6 days ago) Oct 15
to Michael Lippautz, V8 LUCI CQ, AyeAye, oilpan-r...@chromium.org

Andreas Haas voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I79290034ea3cdf9bb360c843ad3767bd6b1861b3
Gerrit-Change-Number: 7040944
Gerrit-PatchSet: 1
Gerrit-Owner: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Wed, 15 Oct 2025 08:31:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Oct 15, 2025, 4:36:13 AM (6 days ago) Oct 15
to Andreas Haas, Michael Lippautz, AyeAye, oilpan-r...@chromium.org

V8 LUCI CQ submitted the change

Change information

Commit message:
[cleanup] Delete test-only CppHeapPointerTable method

The method WriteLazilyInitializedCppHeapPointerField<> got obsolete
during a recent refactoring, and since then was only called in tests.
With this CL, the new version of
WriteLazilyInitializedCppHeapPointerField is used in the tests, and the
obsolete version gets deleted.
Change-Id: I79290034ea3cdf9bb360c843ad3767bd6b1861b3
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Andreas Haas <ah...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103124}
Files:
  • M src/objects/cpp-heap-object-wrapper-inl.h
  • M src/objects/cpp-heap-object-wrapper.h
  • M src/objects/heap-object.h
  • M src/objects/objects-inl.h
  • M src/sandbox/cppheap-pointer-inl.h
  • M src/sandbox/cppheap-pointer.h
  • M test/unittests/heap/cppgc-js/unified-heap-utils.cc
Change size: M
Delta: 7 files changed, 4 insertions(+), 53 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Michael Lippautz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I79290034ea3cdf9bb360c843ad3767bd6b1861b3
Gerrit-Change-Number: 7040944
Gerrit-PatchSet: 2
Gerrit-Owner: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages