Move wtf/thread_safe_ref_counted.h to "blink" namespace [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Jul 21, 2025, 11:08:02 PMJul 21
to Kent Tamura, Koji Ishii, chromium...@chromium.org, Chromium LUCI CQ, Nate Chapin, Kentaro Hara, Dirk Schulze, Hirokazu Honda, Raphael Kubo da Costa, Hiroki Nakagawa, srirama chandra sekhar, Stephen Chenney, AyeAye, fuzzin...@chromium.org, video-networking...@google.com, oilpan-rev...@chromium.org, drott+bl...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, shimazu+se...@chromium.org, servicewor...@chromium.org, cblume+im...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, horo+...@chromium.org, loading...@chromium.org, eric.c...@apple.com, kinuko+ser...@chromium.org, fserb...@chromium.org, scheduler-...@chromium.org, loading-re...@chromium.org, fmalit...@chromium.org, chikamu...@chromium.org, blink-work...@chromium.org, kouhe...@chromium.org, gavinp...@chromium.org, shimazu...@chromium.org, blink-revie...@chromium.org, feature-me...@chromium.org, tommyw+w...@chromium.org, blink-...@chromium.org
Attention needed from Koji Ishii

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Kent Tamura . resolved

kojii@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Koji Ishii
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia252c4fd3d594e3535487e85a0e8ca53cfac630f
Gerrit-Change-Number: 6775002
Gerrit-PatchSet: 2
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Hirokazu Honda <hi...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Koji Ishii <ko...@chromium.org>
Gerrit-Comment-Date: Tue, 22 Jul 2025 03:07:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Koji Ishii (Gerrit)

unread,
Jul 22, 2025, 2:15:51 AMJul 22
to Kent Tamura, chromium...@chromium.org, Chromium LUCI CQ, Nate Chapin, Kentaro Hara, Dirk Schulze, Hirokazu Honda, Raphael Kubo da Costa, Hiroki Nakagawa, srirama chandra sekhar, Stephen Chenney, AyeAye, fuzzin...@chromium.org, video-networking...@google.com, oilpan-rev...@chromium.org, drott+bl...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, shimazu+se...@chromium.org, servicewor...@chromium.org, cblume+im...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, horo+...@chromium.org, loading...@chromium.org, eric.c...@apple.com, kinuko+ser...@chromium.org, fserb...@chromium.org, scheduler-...@chromium.org, loading-re...@chromium.org, fmalit...@chromium.org, chikamu...@chromium.org, blink-work...@chromium.org, kouhe...@chromium.org, gavinp...@chromium.org, shimazu...@chromium.org, blink-revie...@chromium.org, feature-me...@chromium.org, tommyw+w...@chromium.org, blink-...@chromium.org
Attention needed from Kent Tamura

Koji Ishii voted and added 1 comment

Votes added by Koji Ishii

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Koji Ishii . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia252c4fd3d594e3535487e85a0e8ca53cfac630f
    Gerrit-Change-Number: 6775002
    Gerrit-PatchSet: 2
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Hirokazu Honda <hi...@chromium.org>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Tue, 22 Jul 2025 06:15:28 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 22, 2025, 2:18:49 AMJul 22
    to Kent Tamura, Koji Ishii, chromium...@chromium.org, Nate Chapin, Kentaro Hara, Dirk Schulze, Hirokazu Honda, Raphael Kubo da Costa, Hiroki Nakagawa, srirama chandra sekhar, Stephen Chenney, AyeAye, fuzzin...@chromium.org, video-networking...@google.com, oilpan-rev...@chromium.org, drott+bl...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, shimazu+se...@chromium.org, servicewor...@chromium.org, cblume+im...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, horo+...@chromium.org, loading...@chromium.org, eric.c...@apple.com, kinuko+ser...@chromium.org, fserb...@chromium.org, scheduler-...@chromium.org, loading-re...@chromium.org, fmalit...@chromium.org, chikamu...@chromium.org, blink-work...@chromium.org, kouhe...@chromium.org, gavinp...@chromium.org, shimazu...@chromium.org, blink-revie...@chromium.org, feature-me...@chromium.org, tommyw+w...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Move wtf/thread_safe_ref_counted.h to "blink" namespace

    This CL has no behavior changes.
    Bug: 422768753
    Change-Id: Ia252c4fd3d594e3535487e85a0e8ca53cfac630f
    Reviewed-by: Koji Ishii <ko...@chromium.org>
    Commit-Queue: Koji Ishii <ko...@chromium.org>
    Auto-Submit: Kent Tamura <tk...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1489948}
    Files:
    • M third_party/blink/public/platform/modules/service_worker/web_service_worker_provider_context.h
    • M third_party/blink/public/platform/web_private_ptr.h
    • M third_party/blink/public/web/modules/mediastream/encoded_video_frame.h
    • M third_party/blink/renderer/bindings/core/v8/script_streamer.h
    • M third_party/blink/renderer/bindings/core/v8/v8_compile_hints_consumer.h
    • M third_party/blink/renderer/core/html/media/media_source_attachment.h
    • M third_party/blink/renderer/core/workers/worker_thread.cc
    • M third_party/blink/renderer/modules/breakout_box/frame_queue.h
    • M third_party/blink/renderer/modules/breakout_box/pushable_media_stream_audio_source.h
    • M third_party/blink/renderer/modules/breakout_box/pushable_media_stream_video_source.h
    • M third_party/blink/renderer/modules/imagecapture/image_capture_frame_grabber.cc
    • M third_party/blink/renderer/modules/mediasource/handle_attachment_provider.h
    • M third_party/blink/renderer/modules/mediastream/media_stream_video_track.cc
    • M third_party/blink/renderer/modules/mediastream/remote_media_stream_track_adapter.h
    • M third_party/blink/renderer/modules/mediastream/video_track_adapter.cc
    • M third_party/blink/renderer/modules/mediastream/video_track_adapter.h
    • M third_party/blink/renderer/modules/peerconnection/media_stream_remote_video_source.cc
    • M third_party/blink/renderer/modules/peerconnection/media_stream_video_webrtc_sink.cc
    • M third_party/blink/renderer/modules/peerconnection/mock_rtc_peer_connection_handler_platform.cc
    • M third_party/blink/renderer/modules/peerconnection/rtc_certificate_generator.cc
    • M third_party/blink/renderer/modules/peerconnection/rtc_data_channel.h
    • M third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_frame_delegate.h
    • M third_party/blink/renderer/modules/peerconnection/rtc_encoded_video_frame_delegate.h
    • M third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver_impl.cc
    • M third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender_impl.cc
    • M third_party/blink/renderer/modules/peerconnection/rtc_rtp_transceiver_impl.cc
    • M third_party/blink/renderer/modules/peerconnection/rtc_rtp_transport.h
    • M third_party/blink/renderer/modules/peerconnection/test_webrtc_stats_report_obtainer.h
    • M third_party/blink/renderer/modules/peerconnection/webrtc_media_stream_track_adapter.h
    • M third_party/blink/renderer/modules/peerconnection/webrtc_media_stream_track_adapter_map.h
    • M third_party/blink/renderer/modules/peerconnection/webrtc_set_description_observer.h
    • M third_party/blink/renderer/modules/service_worker/thread_safe_script_container.h
    • M third_party/blink/renderer/modules/webcodecs/background_readback.cc
    • M third_party/blink/renderer/modules/webcodecs/video_frame_handle.h
    • M third_party/blink/renderer/modules/webcodecs/webcodecs_logger.h
    • M third_party/blink/renderer/platform/bindings/parkable_string.h
    • M third_party/blink/renderer/platform/graphics/canvas_resource.h
    • M third_party/blink/renderer/platform/heap/test/cross_thread_handle_test.cc
    • M third_party/blink/renderer/platform/image-decoders/rw_buffer.h
    • M third_party/blink/renderer/platform/loader/fetch/url_loader/background_url_loader.cc
    • M third_party/blink/renderer/platform/loader/fetch/url_loader/background_url_loader_unittest.cc
    • M third_party/blink/renderer/platform/peerconnection/gpu_codec_support_waiter.cc
    • M third_party/blink/renderer/platform/peerconnection/rtc_dtmf_sender_handler.cc
    • M third_party/blink/renderer/platform/peerconnection/rtc_encoded_audio_stream_transformer.h
    • M third_party/blink/renderer/platform/peerconnection/rtc_encoded_video_stream_transformer.h
    • M third_party/blink/renderer/platform/peerconnection/rtc_video_encoder.cc
    • M third_party/blink/renderer/platform/scheduler/common/post_cancellable_task.cc
    • M third_party/blink/renderer/platform/scheduler/common/single_thread_idle_task_runner.h
    • M third_party/blink/renderer/platform/scheduler/test/fake_task_runner.cc
    • M third_party/blink/renderer/platform/scheduler/test/fuzzer/task_queue_with_voters.h
    • M third_party/blink/renderer/platform/webrtc/track_observer.cc
    • M third_party/blink/renderer/platform/wtf/thread_safe_ref_counted.h
    • M third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
    Change size: M
    Delta: 53 files changed, 97 insertions(+), 104 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Koji Ishii
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia252c4fd3d594e3535487e85a0e8ca53cfac630f
    Gerrit-Change-Number: 6775002
    Gerrit-PatchSet: 3
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages