Destroy TestCompositorFrameReportingController first in test teardown [chromium/src : main]

0 views
Skip to first unread message

Elly FJ (Gerrit)

unread,
May 27, 2024, 7:08:58 PMMay 27
to Daniel Cheng, Elly FJ, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-re...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from Daniel Cheng

Elly FJ voted and added 1 comment

Votes added by Elly FJ

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Elly FJ . resolved

lgtm despite wip :)

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifef463419d136b88ab4283443e44a45b9cc36262
Gerrit-Change-Number: 5572601
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Mon, 27 May 2024 23:08:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
May 28, 2024, 4:06:38 AMMay 28
to Daniel Cheng, Elly FJ, chromotin...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, alexmo...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blundell+...@chromium.org, cblume+im...@chromium.org, creis...@chromium.org, mbarowsky+watc...@chromium.org, navigation...@chromium.org, zhangwen...@google.com, zol...@webkit.org, blink-re...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

Daniel Cheng added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Daniel Cheng . resolved

(Sorry Elly, this wasn't meant to be sent to you. CQ+2ing a CL in a chain has some interesting side effects now, one of which is adding you to the entire ancestor chain. I've filed a bug about this, but I don't think it was properly addressed yet)

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifef463419d136b88ab4283443e44a45b9cc36262
Gerrit-Change-Number: 5572601
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Elly FJ <elly...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Comment-Date: Tue, 28 May 2024 08:06:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

mmenke (Gerrit)

unread,
May 30, 2024, 1:22:29 PMMay 30
to Daniel Cheng, Rijubrata Bhaumik, Elly FJ, chromotin...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, odejesu...@chromium.org, yigu+...@chromium.org, alexmo...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blundell+...@chromium.org, cblume+im...@chromium.org, creis...@chromium.org, mbarowsky+watc...@chromium.org, navigation...@chromium.org, zhangwen...@google.com, zol...@webkit.org, blink-re...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from Daniel Cheng

mmenke added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifef463419d136b88ab4283443e44a45b9cc36262
Gerrit-Change-Number: 5572601
Gerrit-PatchSet: 5
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: mmenke <mme...@chromium.org>
Gerrit-CC: Elly FJ <elly...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Thu, 30 May 2024 17:22:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jun 13, 2024, 1:58:22 PMJun 13
to Daniel Cheng, Peter Kasting, Rijubrata Bhaumik, Elly FJ, chromotin...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, andysjl...@chromium.org, armalhotra+a...@google.com, druber...@chromium.org, feliciac+au...@google.com, jsaul+aut...@google.com, nwoked...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vakh+safe_br...@chromium.org, vinnypersky+...@google.com, xinghui...@chromium.org, zackha...@chromium.org, lwinston+watc...@google.com, trewin...@google.com, browser-comp...@chromium.org, rouslan+au...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, odejesu...@chromium.org, yigu+...@chromium.org, alexmo...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blundell+...@chromium.org, cblume+im...@chromium.org, creis...@chromium.org, mbarowsky+watc...@chromium.org, navigation...@chromium.org, zhangwen...@google.com, zol...@webkit.org, blink-re...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from Daniel Cheng

Daniel Cheng removed Peter Kasting from this change

Deleted Reviewers:
  • Peter Kasting
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteReviewer
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifef463419d136b88ab4283443e44a45b9cc36262
Gerrit-Change-Number: 5572601
Gerrit-PatchSet: 15
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
satisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jun 13, 2024, 4:36:51 PMJun 13
to Daniel Cheng, Min Qin, Rijubrata Bhaumik, Elly FJ, chromotin...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, andysjl...@chromium.org, armalhotra+a...@google.com, druber...@chromium.org, feliciac+au...@google.com, jsaul+aut...@google.com, nwoked...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vakh+safe_br...@chromium.org, vinnypersky+...@google.com, xinghui...@chromium.org, zackha...@chromium.org, lwinston+watc...@google.com, trewin...@google.com, browser-comp...@chromium.org, rouslan+au...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, odejesu...@chromium.org, yigu+...@chromium.org, alexmo...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blundell+...@chromium.org, cblume+im...@chromium.org, creis...@chromium.org, mbarowsky+watc...@chromium.org, navigation...@chromium.org, zhangwen...@google.com, zol...@webkit.org, blink-re...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from Daniel Cheng

Daniel Cheng removed Min Qin from this change

Deleted Reviewers:
  • Min Qin
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteReviewer
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifef463419d136b88ab4283443e44a45b9cc36262
Gerrit-Change-Number: 5572601
Gerrit-PatchSet: 16
satisfied_requirement
open
diffy

David Baron (Gerrit)

unread,
Jun 14, 2024, 7:20:17 AMJun 14
to Daniel Cheng, David Baron, Rijubrata Bhaumik, Elly FJ, chromotin...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, penghu...@chromium.org, andysjl...@chromium.org, armalhotra+a...@google.com, druber...@chromium.org, feliciac+au...@google.com, jsaul+aut...@google.com, nwoked...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vakh+safe_br...@chromium.org, vinnypersky+...@google.com, xinghui...@chromium.org, zackha...@chromium.org, lwinston+watc...@google.com, trewin...@google.com, browser-comp...@chromium.org, rouslan+au...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, odejesu...@chromium.org, yigu+...@chromium.org, alexmo...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blundell+...@chromium.org, cblume+im...@chromium.org, creis...@chromium.org, mbarowsky+watc...@chromium.org, navigation...@chromium.org, zhangwen...@google.com, zol...@webkit.org, blink-re...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from Daniel Cheng

David Baron voted and added 2 comments

Votes added by David Baron

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 17 (Latest):
David Baron . resolved

LGTM (technically an owner but I don't know anything about this code, but I think that's fine in this case)

File cc/metrics/compositor_frame_reporting_controller_unittest.cc
Line 336, Patchset 17 (Latest): TestCompositorFrameReportingController reporting_controller_;
David Baron . unresolved

Maybe add a "must be destroyed before `dropped_counter_`, therefore after it" comment or something along those lines?

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifef463419d136b88ab4283443e44a45b9cc36262
    Gerrit-Change-Number: 5572601
    Gerrit-PatchSet: 17
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: David Baron <dba...@chromium.org>
    Gerrit-CC: Elly FJ <elly...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Fri, 14 Jun 2024 11:20:05 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Jun 14, 2024, 11:22:25 AMJun 14
    to Daniel Cheng, David Baron, Rijubrata Bhaumik, Elly FJ, chromotin...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, penghu...@chromium.org, andysjl...@chromium.org, armalhotra+a...@google.com, druber...@chromium.org, feliciac+au...@google.com, jsaul+aut...@google.com, nwoked...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vakh+safe_br...@chromium.org, vinnypersky+...@google.com, xinghui...@chromium.org, zackha...@chromium.org, lwinston+watc...@google.com, trewin...@google.com, browser-comp...@chromium.org, rouslan+au...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, odejesu...@chromium.org, yigu+...@chromium.org, alexmo...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blundell+...@chromium.org, cblume+im...@chromium.org, creis...@chromium.org, mbarowsky+watc...@chromium.org, navigation...@chromium.org, zhangwen...@google.com, zol...@webkit.org, blink-re...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
    Attention needed from David Baron

    Daniel Cheng added 1 comment

    File cc/metrics/compositor_frame_reporting_controller_unittest.cc
    Line 336, Patchset 17 (Latest): TestCompositorFrameReportingController reporting_controller_;
    David Baron . unresolved

    Maybe add a "must be destroyed before `dropped_counter_`, therefore after it" comment or something along those lines?

    Daniel Cheng

    I've mostly avoided adding these comments because:

    • they often encode implementation details of other classes that can easily shift
    • there are likely many other instances of fields that are dependent on the current ordering, but aren't documented because MSan or ASan hasn't noticed

    At some point, we should be able to enable the use-after-dtor checks and this will be tooling enforced. If you feel strongly, I can add the comment, but overall, I think it will be too easy for it to become stale.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • David Baron
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifef463419d136b88ab4283443e44a45b9cc36262
    Gerrit-Change-Number: 5572601
    Gerrit-PatchSet: 17
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: David Baron <dba...@chromium.org>
    Gerrit-CC: Elly FJ <elly...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: David Baron <dba...@chromium.org>
    Gerrit-Comment-Date: Fri, 14 Jun 2024 15:22:11 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: David Baron <dba...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    David Baron (Gerrit)

    unread,
    Jun 14, 2024, 11:25:35 AMJun 14
    to Daniel Cheng, David Baron, Rijubrata Bhaumik, Elly FJ, chromotin...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, penghu...@chromium.org, andysjl...@chromium.org, armalhotra+a...@google.com, druber...@chromium.org, feliciac+au...@google.com, jsaul+aut...@google.com, nwoked...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vakh+safe_br...@chromium.org, vinnypersky+...@google.com, xinghui...@chromium.org, zackha...@chromium.org, lwinston+watc...@google.com, trewin...@google.com, browser-comp...@chromium.org, rouslan+au...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, odejesu...@chromium.org, yigu+...@chromium.org, alexmo...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blundell+...@chromium.org, cblume+im...@chromium.org, creis...@chromium.org, mbarowsky+watc...@chromium.org, navigation...@chromium.org, zhangwen...@google.com, zol...@webkit.org, blink-re...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
    Attention needed from Daniel Cheng

    David Baron added 1 comment

    File cc/metrics/compositor_frame_reporting_controller_unittest.cc
    Line 336, Patchset 17 (Latest): TestCompositorFrameReportingController reporting_controller_;
    David Baron . resolved

    Maybe add a "must be destroyed before `dropped_counter_`, therefore after it" comment or something along those lines?

    Daniel Cheng

    I've mostly avoided adding these comments because:

    • they often encode implementation details of other classes that can easily shift
    • there are likely many other instances of fields that are dependent on the current ordering, but aren't documented because MSan or ASan hasn't noticed

    At some point, we should be able to enable the use-after-dtor checks and this will be tooling enforced. If you feel strongly, I can add the comment, but overall, I think it will be too easy for it to become stale.

    David Baron

    That's fine. I don't feel strongly.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifef463419d136b88ab4283443e44a45b9cc36262
    Gerrit-Change-Number: 5572601
    Gerrit-PatchSet: 17
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: David Baron <dba...@chromium.org>
    Gerrit-CC: Elly FJ <elly...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Fri, 14 Jun 2024 15:25:21 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: David Baron <dba...@chromium.org>
    Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>
    satisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Jun 14, 2024, 1:15:37 PMJun 14
    to Daniel Cheng, David Baron, Rijubrata Bhaumik, Elly FJ, chromotin...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, penghu...@chromium.org, andysjl...@chromium.org, armalhotra+a...@google.com, druber...@chromium.org, feliciac+au...@google.com, jsaul+aut...@google.com, nwoked...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vakh+safe_br...@chromium.org, vinnypersky+...@google.com, xinghui...@chromium.org, zackha...@chromium.org, lwinston+watc...@google.com, trewin...@google.com, browser-comp...@chromium.org, rouslan+au...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, odejesu...@chromium.org, yigu+...@chromium.org, alexmo...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blundell+...@chromium.org, cblume+im...@chromium.org, creis...@chromium.org, mbarowsky+watc...@chromium.org, navigation...@chromium.org, zhangwen...@google.com, zol...@webkit.org, blink-re...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

    Daniel Cheng voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifef463419d136b88ab4283443e44a45b9cc36262
    Gerrit-Change-Number: 5572601
    Gerrit-PatchSet: 18
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: David Baron <dba...@chromium.org>
    Gerrit-CC: Elly FJ <elly...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Comment-Date: Fri, 14 Jun 2024 17:15:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 14, 2024, 1:18:17 PMJun 14
    to Daniel Cheng, David Baron, Rijubrata Bhaumik, Elly FJ, chromotin...@chromium.org, chromium...@chromium.org, Kentaro Hara, penghu...@chromium.org, andysjl...@chromium.org, armalhotra+a...@google.com, druber...@chromium.org, feliciac+au...@google.com, jsaul+aut...@google.com, nwoked...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vakh+safe_br...@chromium.org, vinnypersky+...@google.com, xinghui...@chromium.org, zackha...@chromium.org, lwinston+watc...@google.com, trewin...@google.com, browser-comp...@chromium.org, rouslan+au...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, odejesu...@chromium.org, yigu+...@chromium.org, alexmo...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blundell+...@chromium.org, cblume+im...@chromium.org, creis...@chromium.org, mbarowsky+watc...@chromium.org, navigation...@chromium.org, zhangwen...@google.com, zol...@webkit.org, blink-re...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

    Chromium LUCI CQ submitted the change with unreviewed changes

    Unreviewed changes

    17 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    Destroy TestCompositorFrameReportingController first in test teardown

    TestCompositorFrameReportingController destroys CompositorFrameReporter,
    which ends up trying to use the already-destroyed DroppedFrameCounter.
    Bug: 40222690
    Change-Id: Ifef463419d136b88ab4283443e44a45b9cc36262
    Reviewed-by: Elly FJ <elly...@chromium.org>
    Reviewed-by: David Baron <dba...@chromium.org>
    Commit-Queue: Daniel Cheng <dch...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1315308}
    Files:
    • M cc/metrics/compositor_frame_reporting_controller_unittest.cc
    Change size: XS
    Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by David Baron, +1 by Elly FJ
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifef463419d136b88ab4283443e44a45b9cc36262
    Gerrit-Change-Number: 5572601
    Gerrit-PatchSet: 19
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: David Baron <dba...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages