cppgc: Annotate all write barrier slow paths with preserve most [v8/v8 : main]
0 views
Skip to first unread message
Michael Lippautz (Gerrit)
Jul 21, 2026, 8:09:09 AMJul 21
to Anton Bikineev, chrom...@appspot.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Anton Bikineev
Michael Lippautz voted and added 2 comments![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Auto-Submit | +1 |
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File include/cppgc/internal/write-barrier.h
Line 88, Patchset 2 (Latest):
static V8_NOINLINE V8_PRESERVE_MOST void CombinedWriteBarrierSlow(Michael Lippautz . resolved
This was the most important one and is already annotated.
Related details
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anton Bikineev (Gerrit)
Jul 21, 2026, 12:18:53 PMJul 21
to Michael Lippautz, chrom...@appspot.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Anton Bikineev voted and added 1 comment![]( "Open in Gerrit")
Votes added by Anton Bikineev
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 21, 2026, 12:21:24 PMJul 21
to Michael Lippautz, Anton Bikineev, chrom...@appspot.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
cppgc: Annotate all write barrier slow paths with preserve most
The most critical barrier (CombinedWriteBarrierSlow) was already
annotated. Add more annotations to cover all the collection use cases
as well.
Speedometer3
👍 TodoMVC-Preact-Complex-DOM [ -1.1%, -0.0%]
Bug: 537244297
Change-Id: Ie9f1823ba99f5e2ca8b15d446c10acf88b302d49
Commit-Queue: Anton Bikineev <biki...@chromium.org>
Reviewed-by: Anton Bikineev <biki...@chromium.org>
Auto-Submit: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#108791}
Files:
- M include/cppgc/internal/pointer-policies.h
- M include/cppgc/internal/write-barrier.h
Change size: M
Delta: 2 files changed, 38 insertions(+), 36 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Anton Bikineev
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages