[api] Remove deprecated CppHeap::Terminate method [v8/v8 : main]
0 views
Skip to first unread message
Olivier Flückiger (Gerrit)
Aug 6, 2026, 2:56:52 AM (4 days ago) Aug 6
to Andreas Haas, Hannes Payer, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, oilpan-r...@chromium.org, mlippau...@chromium.org, cbruni...@chromium.org
Attention needed from Andreas Haas
Olivier Flückiger voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Andreas Haas
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andreas Haas (Gerrit)
Aug 6, 2026, 3:32:40 AM (4 days ago) Aug 6
to Nikolaos Papaspyrou, Olivier Flückiger, Hannes Payer, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, oilpan-r...@chromium.org, mlippau...@chromium.org, cbruni...@chromium.org
Attention needed from Nikolaos Papaspyrou and Olivier Flückiger
Andreas Haas voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andreas Haas
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Andreas Haas . resolved
nikolaos@, please take a look at src/heap/*
Related details
Attention is currently required from:
- Nikolaos Papaspyrou
- Olivier Flückiger
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolaos Papaspyrou (Gerrit)
Aug 6, 2026, 4:57:22 AM (4 days ago) Aug 6
to Andreas Haas, Olivier Flückiger, Hannes Payer, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, oilpan-r...@chromium.org, mlippau...@chromium.org, cbruni...@chromium.org
Attention needed from Andreas Haas and Olivier Flückiger
Nikolaos Papaspyrou voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nikolaos Papaspyrou
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Nikolaos Papaspyrou . unresolved
LGTM.
Just a remark, there's a TODO calling for some more cleanup here: https://source.chromium.org/chromium/chromium/src/+/main:v8/src/heap/cppgc-js/cpp-heap.cc;drc=b55c832494d73bc5b1cc9a519ae68a9f818f0332;l=544
Related details
Attention is currently required from:
- Andreas Haas
- Olivier Flückiger
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolaos Papaspyrou (Gerrit)
Aug 6, 2026, 7:31:49 AM (4 days ago) Aug 6
to Andreas Haas, Olivier Flückiger, Hannes Payer, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, oilpan-r...@chromium.org, mlippau...@chromium.org, cbruni...@chromium.org
Attention needed from Andreas Haas and Olivier Flückiger
Nikolaos Papaspyrou voted and added 2 comments![]( "Open in Gerrit")
Votes added by Nikolaos Papaspyrou
| Code-Review | +1 |
LGTM.
Just a remark, there's a TODO calling for some more cleanup here: https://source.chromium.org/chromium/chromium/src/+/main:v8/src/heap/cppgc-js/cpp-heap.cc;drc=b55c832494d73bc5b1cc9a519ae68a9f818f0332;l=544
Nikolaos Papaspyrou
Done.
Related details
Attention is currently required from:
- Andreas Haas
- Olivier Flückiger
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andreas Haas (Gerrit)
Aug 6, 2026, 8:46:16 AM (4 days ago) Aug 6
to Nikolaos Papaspyrou, Olivier Flückiger, Hannes Payer, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, oilpan-r...@chromium.org, mlippau...@chromium.org, cbruni...@chromium.org
Attention needed from Olivier Flückiger
Andreas Haas voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Olivier Flückiger
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andreas Haas (Gerrit)
Aug 6, 2026, 8:46:19 AM (4 days ago) Aug 6
to Nikolaos Papaspyrou, Olivier Flückiger, Hannes Payer, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, oilpan-r...@chromium.org, mlippau...@chromium.org, cbruni...@chromium.org
Attention needed from Olivier Flückiger
Andreas Haas voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andreas Haas
| Auto-Submit | +1 |
Nikolaos Papaspyrou . resolved
LGTM.
Just a remark, there's a TODO calling for some more cleanup here: https://source.chromium.org/chromium/chromium/src/+/main:v8/src/heap/cppgc-js/cpp-heap.cc;drc=b55c832494d73bc5b1cc9a519ae68a9f818f0332;l=544
Andreas Haas
Done
Related details
Attention is currently required from:
- Olivier Flückiger
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Aug 6, 2026, 8:49:03 AM (4 days ago) Aug 6
to Andreas Haas, Nikolaos Papaspyrou, Olivier Flückiger, Hannes Payer, android-bu...@system.gserviceaccount.com, oilpan-r...@chromium.org, mlippau...@chromium.org, cbruni...@chromium.org
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[api] Remove deprecated CppHeap::Terminate method
Change-Id: I6671d420c030f63d8962f6110c9f9be64c4cb105
Commit-Queue: Andreas Haas <ah...@chromium.org>
Reviewed-by: Nikolaos Papaspyrou <niko...@chromium.org>
Auto-Submit: Andreas Haas <ah...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#109104}
Files:
- M include/v8-cppgc.h
- M src/heap/cppgc-js/cpp-heap.cc
- M src/heap/cppgc-js/cpp-heap.h
Change size: S
Delta: 3 files changed, 0 insertions(+), 22 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nikolaos Papaspyrou
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages