Revert "[heap] Add notes for preempting/finishing jobs" [v8/v8 : chromium/7582]

0 views

Skip to first unread message

Rubber Stamper (Gerrit)

unread,

Dec 17, 2025, 12:36:15 PM (11 days ago) Dec 17

to Omer Katz, Krishna Govind, Hannes Payer, AyeAye, oilpan-r...@chromium.org, v8-m...@googlegroups.com, mlippau...@chromium.org

Rubber Stamper voted

Bot-Commit	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Krishna Govind (Gerrit)

unread,

Dec 17, 2025, 12:36:56 PM (11 days ago) Dec 17

to Omer Katz, V8 LUCI CQ, Rubber Stamper, Hannes Payer, AyeAye, oilpan-r...@chromium.org, v8-m...@googlegroups.com, mlippau...@chromium.org

Krishna Govind submitted the change

Change information

Commit message:

Revert "[heap] Add notes for preempting/finishing jobs"

This reverts commit d61897cc21fe643b7378f538464dae866fb4841b.

Reason for revert: Speculative revert due to crashes in cppgc starting at the revision in which this CL landed (e.g. crbug.com/469686890)

Original change's description:
> [heap] Add notes for preempting/finishing jobs
>
> Help distinguish on a trace which concurrent jobs end because of
> preemption and which end because they run out of work.
> Notes are added only to jobs that can yield.
>
> Bug: 42204085
> Change-Id: If3064174cc6ccfda50230b906589f456983e46a9
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7261997
> Reviewed-by: Michael Lippautz <mlip...@chromium.org>
> Commit-Queue: Omer Katz <omer...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#104328}

Bug: 42204085
Change-Id: I3b68b5863d9d69ed3f47964b134e289f40856c3a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7269591
Auto-Submit: Omer Katz <omer...@chromium.org>
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Commit-Queue: Omer Katz <omer...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104373}
(cherry picked from commit 4f79c36b07347a1a4eeebff08246c8e1492e0e5e)
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7270226
Auto-Submit: Krishna Govind <gov...@chromium.org>
Owners-Override: Krishna Govind <gov...@chromium.org>

Files:

M src/heap/array-buffer-sweeper.cc
M src/heap/concurrent-marking.cc
M src/heap/cppgc/concurrent-marker.cc
M src/heap/cppgc/stats-collector.h
M src/heap/cppgc/sweeper.cc
M src/heap/scavenger.cc
M src/heap/sweeper.cc
M src/heap/sweeper.h

Change size: S

Delta: 8 files changed, 3 insertions(+), 34 deletions(-)

Branch: refs/heads/chromium/7582

Submit Requirements:

Code-Review: Bot-Commit+1 by Rubber Stamper

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages