Provide FakeMojoBindingContext helper for tests [chromium/src : main]
0 views
Skip to first unread message
Daniel Cheng (Gerrit)
Jun 24, 2024, 12:18:49 AM (6 days ago) Jun 24
to Daniel Cheng, Nate Chapin, Sun Shin US, chromium...@chromium.org, Kentaro Hara, agriev...@chromium.org, ajayramamurth...@google.com, blink-re...@chromium.org, blink-...@chromium.org, blundell+...@chromium.org, crisrael+w...@google.com, dclasson+w...@google.com, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, jackshira+w...@google.com, kinuko...@chromium.org, kouhe...@chromium.org, network-ser...@chromium.org, oilpan-rev...@chromium.org, pushi+wat...@google.com, suetfei+wa...@google.com, xlythe+wa...@google.com
Attention needed from Nate Chapin
Daniel Cheng voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Cheng
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Daniel Cheng . resolved
@sus...@nvidia.com as FYI
@jap...@chromium.org, as we discussed, a very barebones MojoBindingContext to simplify things for tests.
Related details
Attention is currently required from:
- Nate Chapin
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Jun 24, 2024, 5:23:03 PM (5 days ago) Jun 24
to Daniel Cheng, Dave Tapuska, Chromium LUCI CQ, Nate Chapin, Sun Shin US, chromium...@chromium.org, Kentaro Hara, agriev...@chromium.org, ajayramamurth...@google.com, blink-re...@chromium.org, blink-...@chromium.org, blundell+...@chromium.org, crisrael+w...@google.com, dclasson+w...@google.com, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, jackshira+w...@google.com, kinuko...@chromium.org, kouhe...@chromium.org, network-ser...@chromium.org, oilpan-rev...@chromium.org, pushi+wat...@google.com, suetfei+wa...@google.com, xlythe+wa...@google.com
Attention needed from Dave Tapuska and Nate Chapin
Daniel Cheng added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Dave Tapuska
- Nate Chapin
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
Jun 24, 2024, 5:38:30 PM (5 days ago) Jun 24
to Daniel Cheng, Chromium LUCI CQ, Nate Chapin, Sun Shin US, chromium...@chromium.org, Kentaro Hara, agriev...@chromium.org, ajayramamurth...@google.com, blink-re...@chromium.org, blink-...@chromium.org, blundell+...@chromium.org, crisrael+w...@google.com, dclasson+w...@google.com, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, jackshira+w...@google.com, kinuko...@chromium.org, kouhe...@chromium.org, network-ser...@chromium.org, oilpan-rev...@chromium.org, pushi+wat...@google.com, suetfei+wa...@google.com, xlythe+wa...@google.com
Attention needed from Daniel Cheng and Nate Chapin
Dave Tapuska voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dave Tapuska
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/platform/testing/fake_mojo_binding_context.cc
Line 28, Patchset 1 (Latest):
if (!IsContextDestroyed()) {Dave Tapuska . unresolved
This is kind of wacky that we don't actually attach this to an execution context. I didn't see a reason why it couldn't be done in the dependent CL. Is there a reason that I couldn't see?
Related details
Attention is currently required from:
- Daniel Cheng
- Nate Chapin
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
Jun 24, 2024, 5:43:44 PM (5 days ago) Jun 24
to Daniel Cheng, Chromium LUCI CQ, Nate Chapin, Sun Shin US, chromium...@chromium.org, Kentaro Hara, agriev...@chromium.org, ajayramamurth...@google.com, blink-re...@chromium.org, blink-...@chromium.org, blundell+...@chromium.org, crisrael+w...@google.com, dclasson+w...@google.com, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, jackshira+w...@google.com, kinuko...@chromium.org, kouhe...@chromium.org, network-ser...@chromium.org, oilpan-rev...@chromium.org, pushi+wat...@google.com, suetfei+wa...@google.com, xlythe+wa...@google.com
Attention needed from Daniel Cheng and Nate Chapin
Dave Tapuska added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/testing/fake_mojo_binding_context.cc
Line 28, Patchset 1 (Latest):
if (!IsContextDestroyed()) {Dave Tapuska . resolved
This is kind of wacky that we don't actually attach this to an execution context. I didn't see a reason why it couldn't be done in the dependent CL. Is there a reason that I couldn't see?
Dave Tapuska
Oh nevermind, the dependent patch is in platform... I didn't catch that.
Related details
Attention is currently required from:
- Daniel Cheng
- Nate Chapin
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages