Nikolaos Papaspyrou (Gerrit)

unread,

Jun 11, 2024, 10:25:34 AMJun 11

to Omer Katz, V8 LUCI CQ, oilpan-r...@chromium.org, v8-re...@googlegroups.com

Attention needed from Omer Katz

Nikolaos Papaspyrou voted and added 1 comment

Votes added by Nikolaos Papaspyrou

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Nikolaos Papaspyrou . unresolved

All changes in this CL should be trivial.

Replacements `s/Handle/DirectHandle/` (mostly by the tool, some manually)
Replacements `s/handle/direct_handle/`
Replacements `s/OpenHandle/OpenDirectHandle/`
Simplified handle initializations, e.g. `DirectHandle<T> h = Cast<T>(...);` or `DirectHandle<T> h(obj, isolate);`

Open in Gerrit

Related details

Attention is currently required from:

Omer Katz

Submit Requirements:

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Omer Katz (Gerrit)

unread,

Jun 11, 2024, 11:01:30 AMJun 11

to Nikolaos Papaspyrou, V8 LUCI CQ, oilpan-r...@chromium.org, v8-re...@googlegroups.com

Attention needed from Nikolaos Papaspyrou

Omer Katz voted and added 1 comment

Votes added by Omer Katz

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Omer Katz . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:

Nikolaos Papaspyrou

Submit Requirements:

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Nikolaos Papaspyrou (Gerrit)

unread,

Jun 11, 2024, 11:54:34 AMJun 11

to Omer Katz, V8 LUCI CQ, oilpan-r...@chromium.org, v8-re...@googlegroups.com

Nikolaos Papaspyrou voted and added 1 comment

Votes added by Nikolaos Papaspyrou

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Nikolaos Papaspyrou . resolved

All changes in this CL should be trivial.
Replacements `s/Handle/DirectHandle/` (mostly by the tool, some manually)
Replacements `s/handle/direct_handle/`
Replacements `s/OpenHandle/OpenDirectHandle/`
Simplified handle initializations, e.g. `DirectHandle<T> h = Cast<T>(...);` or `DirectHandle<T> h(obj, isolate);`

Nikolaos Papaspyrou

Acknowledged

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

V8 LUCI CQ (Gerrit)

unread,

Jun 11, 2024, 11:56:49 AMJun 11

to Nikolaos Papaspyrou, Omer Katz, oilpan-r...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:

[handles] Migration to direct handles, part 4

This CL migrates a large number of handles to direct handles. The
changes are only relevant for builds with v8_enable_direct_handle=true.

Affected directories: test.

Bug: 42203211

Change-Id: Ie9fb3d5b3c66ea9ffa0092d928256aa3891c9a9a

Cq-Include-Trybots: luci.v8.try:v8_linux64_css_dbg

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5622011

Commit-Queue: Nikolaos Papaspyrou <niko...@chromium.org>

Reviewed-by: Omer Katz <omer...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#94378}

Files:

M test/cctest/cctest.cc
M test/cctest/compiler/function-tester.cc
M test/cctest/compiler/function-tester.h
M test/cctest/compiler/test-code-assembler.cc
M test/cctest/compiler/test-code-generator.cc
M test/cctest/compiler/test-concurrent-shared-function-info.cc
M test/cctest/compiler/test-js-context-specialization.cc
M test/cctest/compiler/test-js-typed-lowering.cc
M test/cctest/compiler/test-multiple-return.cc
M test/cctest/compiler/test-run-machops.cc
M test/cctest/compiler/test-run-native-calls.cc
M test/cctest/heap/test-alloc.cc
M test/cctest/heap/test-array-buffer-tracker.cc
M test/cctest/heap/test-compaction.cc
M test/cctest/heap/test-concurrent-allocation.cc
M test/cctest/heap/test-external-string-tracker.cc
M test/cctest/heap/test-heap.cc
M test/cctest/heap/test-mark-compact.cc
M test/cctest/heap/test-memory-measurement.cc
M test/cctest/heap/test-spaces.cc
M test/cctest/heap/test-weak-references.cc
M test/cctest/heap/test-write-barrier.cc
M test/cctest/test-accessor-assembler.cc
M test/cctest/test-api-array-buffer.cc
M test/cctest/test-api-interceptors.cc
M test/cctest/test-api-typed-array.cc
M test/cctest/test-api.cc
M test/cctest/test-api.h
M test/cctest/test-code-stub-assembler.cc
M test/cctest/test-cpu-profiler.cc
M test/cctest/test-debug-helper.cc
M test/cctest/test-debug.cc
M test/cctest/test-descriptor-array.cc
M test/cctest/test-disasm-regex-helper.cc
M test/cctest/test-field-type-tracking.cc
M test/cctest/test-func-name-inference.cc
M test/cctest/test-heap-profiler.cc
M test/cctest/test-inobject-slack-tracking.cc
M test/cctest/test-js-weak-refs.cc
M test/cctest/test-mementos.cc
M test/cctest/test-orderedhashtable.cc
M test/cctest/test-profile-generator.cc
M test/cctest/test-ptr-compr-cage.cc
M test/cctest/test-regexp.cc
M test/cctest/test-serialize.cc
M test/cctest/test-shared-strings.cc
M test/cctest/test-strings.cc
M test/cctest/test-swiss-name-dictionary-csa.cc
M test/cctest/test-swiss-name-dictionary-infra.cc
M test/cctest/test-swiss-name-dictionary-infra.h
M test/cctest/test-swiss-name-dictionary.cc
M test/cctest/test-transitions.cc
M test/cctest/test-transitions.h
M test/cctest/test-unwinder-code-pages.cc
M test/cctest/test-verifiers.cc
M test/cctest/torque/test-torque.cc
M test/cctest/wasm/test-c-wasm-entry.cc
M test/cctest/wasm/test-compilation-cache.cc
M test/cctest/wasm/test-gc.cc
M test/cctest/wasm/test-grow-memory.cc
M test/cctest/wasm/test-run-wasm-bulk-memory.cc
M test/cctest/wasm/test-run-wasm-module.cc
M test/cctest/wasm/test-run-wasm-wrappers.cc
M test/cctest/wasm/test-streaming-compilation.cc
M test/cctest/wasm/test-wasm-breakpoints.cc
M test/cctest/wasm/test-wasm-metrics.cc
M test/cctest/wasm/test-wasm-serialization.cc
M test/cctest/wasm/test-wasm-shared-engine.cc
M test/cctest/wasm/test-wasm-stack.cc
M test/cctest/wasm/wasm-run-utils.cc
M test/cctest/wasm/wasm-run-utils.h
M test/common/call-tester.h
M test/common/types-fuzz.h
M test/fuzzer/multi-return.cc
M test/fuzzer/wasm-fuzzer-common.cc
M test/fuzzer/wasm-init-expr.cc
M test/fuzzer/wasm-streaming.cc
M test/unittests/api/access-check-unittest.cc
M test/unittests/api/deserialize-unittest.cc
M test/unittests/assembler/assembler-x64-unittest.cc
M test/unittests/assembler/macro-assembler-x64-unittest.cc
M test/unittests/codegen/code-layout-unittest.cc
M test/unittests/codegen/code-pages-unittest.cc
M test/unittests/codegen/code-stub-assembler-unittest.cc
M test/unittests/codegen/factory-unittest.cc
M test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc
M test/unittests/compiler/codegen-unittest.cc
M test/unittests/compiler/compiler-unittest.cc
M test/unittests/compiler/function-tester.cc
M test/unittests/compiler/function-tester.h
M test/unittests/compiler/graph-unittest.cc
M test/unittests/compiler/run-bytecode-graph-builder-unittest.cc
M test/unittests/compiler/run-jsobjects-unittest.cc
M test/unittests/compiler/run-tail-calls-unittest.cc
M test/unittests/execution/microtask-queue-unittest.cc
M test/unittests/heap/cppgc-js/unified-heap-unittest.cc
M test/unittests/heap/cppgc-js/unified-heap-utils.cc
M test/unittests/heap/global-handles-unittest.cc
M test/unittests/heap/heap-unittest.cc
M test/unittests/heap/local-factory-unittest.cc
M test/unittests/heap/local-handles-unittest.cc
M test/unittests/heap/persistent-handles-unittest.cc
M test/unittests/heap/shared-heap-unittest.cc
M test/unittests/interpreter/bytecode-array-builder-unittest.cc
M test/unittests/interpreter/bytecode-array-writer-unittest.cc
M test/unittests/interpreter/bytecode-expectations-printer.cc
M test/unittests/interpreter/bytecode-expectations-printer.h
M test/unittests/interpreter/constant-array-builder-unittest.cc
M test/unittests/interpreter/interpreter-tester.cc
M test/unittests/interpreter/interpreter-unittest.cc
M test/unittests/interpreter/source-positions-unittest.cc
M test/unittests/logging/log-unittest.cc
M test/unittests/maglev/maglev-test.cc
M test/unittests/numbers/bigint-unittest.cc
M test/unittests/numbers/conversions-unittest.cc
M test/unittests/objects/concurrent-descriptor-array-unittest.cc
M test/unittests/objects/concurrent-feedback-vector-unittest.cc
M test/unittests/objects/concurrent-js-array-unittest.cc
M test/unittests/objects/concurrent-prototype-unittest.cc
M test/unittests/objects/concurrent-script-context-table-unittest.cc
M test/unittests/objects/concurrent-string-unittest.cc
M test/unittests/objects/concurrent-transition-array-unittest.cc
M test/unittests/objects/dictionary-unittest.cc
M test/unittests/objects/elements-kind-unittest.cc
M test/unittests/objects/feedback-vector-unittest.cc
M test/unittests/objects/hashcode-unittest.cc
M test/unittests/objects/intl-unittest.cc
M test/unittests/objects/object-unittest.cc
M test/unittests/objects/roots-unittest.cc
M test/unittests/objects/value-serializer-unittest.cc
M test/unittests/objects/weakarraylist-unittest.cc
M test/unittests/objects/weakmaps-unittest.cc
M test/unittests/objects/weaksets-unittest.cc
M test/unittests/parser/parse-decision-unittest.cc
M test/unittests/parser/parsing-unittest.cc
M test/unittests/parser/preparser-unittest.cc
M test/unittests/profiler/strings-storage-unittest.cc
M test/unittests/regexp/regexp-unittest.cc
M test/unittests/regress/regress-crbug-1056054-unittest.cc
M test/unittests/runtime/runtime-debug-unittest.cc
M test/unittests/strings/unicode-unittest.cc
M test/unittests/tasks/background-compile-task-unittest.cc
M test/unittests/temporal/temporal-parser-unittest.cc
M test/unittests/test-helpers.cc
M test/unittests/test-helpers.h
M test/unittests/test-utils.h
M test/unittests/utils/identity-map-unittest.cc

Change size: XL

Delta: 147 files changed, 1999 insertions(+), 1847 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Omer Katz

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[handles] Migration to direct handles, part 4 [v8/v8 : main]

Nikolaos Papaspyrou (Gerrit)

Nikolaos Papaspyrou voted and added 1 comment

Votes added by Nikolaos Papaspyrou

1 comment

Related details

Omer Katz (Gerrit)

Omer Katz voted and added 1 comment

Votes added by Omer Katz

1 comment

Related details

Nikolaos Papaspyrou (Gerrit)

Nikolaos Papaspyrou voted and added 1 comment

Votes added by Nikolaos Papaspyrou

1 comment

Related details

V8 LUCI CQ (Gerrit)

V8 LUCI CQ submitted the change

Change information