Code-Review | +1 |
Generally LGTM, with a nit on the name
This macro collides with a macro defined in some versions of abseil, causing miscompiles.
nit: can you line wrap at 72 chars?
#define WTF_ANNOTATE_CONTIGUOUS_CONTAINER
Perhaps `SANITIZER_ANNOTATE_CONTIGUOUS_CONTAINER` instead of `WTF_`?
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Auto-Submit | +1 |
This macro collides with a macro defined in some versions of abseil, causing miscompiles.
nit: can you line wrap at 72 chars?
Done
Perhaps `SANITIZER_ANNOTATE_CONTIGUOUS_CONTAINER` instead of `WTF_`?
i've named it WTF_ to minimize the likelihood of it colliding with anything else, ever. Your proposal does not have that property. But generally i think it would be cleaner as a BUILDFLAG() (but such a refactor would be outside the scope of this PR
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Code-Review | +1 |
#define WTF_ANNOTATE_CONTIGUOUS_CONTAINER
Bruno PitrusPerhaps `SANITIZER_ANNOTATE_CONTIGUOUS_CONTAINER` instead of `WTF_`?
i've named it WTF_ to minimize the likelihood of it colliding with anything else, ever. Your proposal does not have that property. But generally i think it would be cleaner as a BUILDFLAG() (but such a refactor would be outside the scope of this PR
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |