Rename ANNOTATE_CONTIGUOUS_CONTAINER macro [chromium/src : main]

0 views
Skip to first unread message

Mason Freed (Gerrit)

unread,
Sep 3, 2025, 8:04:08 PMSep 3
to Bruno Pitrus, Kentaro Hara, AyeAye, Chromium LUCI CQ, Yoav Weiss (@Shopify), blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-rev...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org
Attention needed from Bruno Pitrus and Yoav Weiss (@Shopify)

Mason Freed voted and added 3 comments

Votes added by Mason Freed

Code-Review+1

3 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Mason Freed . resolved

Generally LGTM, with a nit on the name

Commit Message
Line 9, Patchset 1 (Latest):This macro collides with a macro defined in some versions of abseil, causing miscompiles.
Mason Freed . unresolved

nit: can you line wrap at 72 chars?

File third_party/blink/renderer/platform/wtf/container_annotations.h
Line 21, Patchset 1 (Latest):#define WTF_ANNOTATE_CONTIGUOUS_CONTAINER
Mason Freed . unresolved

Perhaps `SANITIZER_ANNOTATE_CONTIGUOUS_CONTAINER` instead of `WTF_`?

Open in Gerrit

Related details

Attention is currently required from:
  • Bruno Pitrus
  • Yoav Weiss (@Shopify)
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ice4bae3d23f8cb7bc5324e8c1ce6557bdc1673dc
Gerrit-Change-Number: 6913443
Gerrit-PatchSet: 1
Gerrit-Owner: Bruno Pitrus <bruno...@hotmail.com>
Gerrit-Reviewer: Bruno Pitrus <bruno...@hotmail.com>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Bruno Pitrus <bruno...@hotmail.com>
Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Sep 2025 00:03:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Bruno Pitrus (Gerrit)

unread,
Sep 4, 2025, 1:22:32 PMSep 4
to Mason Freed, Kentaro Hara, AyeAye, Chromium LUCI CQ, Yoav Weiss (@Shopify), blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-rev...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org
Attention needed from Yoav Weiss (@Shopify)

Bruno Pitrus voted and added 2 comments

Votes added by Bruno Pitrus

Auto-Submit+1

2 comments

Commit Message
Line 9, Patchset 1:This macro collides with a macro defined in some versions of abseil, causing miscompiles.
Mason Freed . resolved

nit: can you line wrap at 72 chars?

Bruno Pitrus

Done

File third_party/blink/renderer/platform/wtf/container_annotations.h
Line 21, Patchset 1:#define WTF_ANNOTATE_CONTIGUOUS_CONTAINER
Mason Freed . resolved

Perhaps `SANITIZER_ANNOTATE_CONTIGUOUS_CONTAINER` instead of `WTF_`?

Bruno Pitrus

i've named it WTF_ to minimize the likelihood of it colliding with anything else, ever. Your proposal does not have that property. But generally i think it would be cleaner as a BUILDFLAG() (but such a refactor would be outside the scope of this PR

Open in Gerrit

Related details

Attention is currently required from:
  • Yoav Weiss (@Shopify)
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ice4bae3d23f8cb7bc5324e8c1ce6557bdc1673dc
Gerrit-Change-Number: 6913443
Gerrit-PatchSet: 2
Gerrit-Owner: Bruno Pitrus <bruno...@hotmail.com>
Gerrit-Reviewer: Bruno Pitrus <bruno...@hotmail.com>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Sep 2025 17:22:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Mason Freed <mas...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Mason Freed (Gerrit)

unread,
Sep 4, 2025, 6:22:45 PMSep 4
to Bruno Pitrus, Kentaro Hara, AyeAye, Chromium LUCI CQ, Yoav Weiss (@Shopify), blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-rev...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org
Attention needed from Bruno Pitrus and Yoav Weiss (@Shopify)

Mason Freed voted and added 1 comment

Votes added by Mason Freed

Code-Review+1

1 comment

File third_party/blink/renderer/platform/wtf/container_annotations.h
Line 21, Patchset 1:#define WTF_ANNOTATE_CONTIGUOUS_CONTAINER
Mason Freed . resolved

Perhaps `SANITIZER_ANNOTATE_CONTIGUOUS_CONTAINER` instead of `WTF_`?

Bruno Pitrus

i've named it WTF_ to minimize the likelihood of it colliding with anything else, ever. Your proposal does not have that property. But generally i think it would be cleaner as a BUILDFLAG() (but such a refactor would be outside the scope of this PR

Mason Freed

Yeah ok, that makes sense. LGTM as WTF_.

Open in Gerrit

Related details

Attention is currently required from:
  • Bruno Pitrus
  • Yoav Weiss (@Shopify)
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ice4bae3d23f8cb7bc5324e8c1ce6557bdc1673dc
Gerrit-Change-Number: 6913443
Gerrit-PatchSet: 2
Gerrit-Owner: Bruno Pitrus <bruno...@hotmail.com>
Gerrit-Reviewer: Bruno Pitrus <bruno...@hotmail.com>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Bruno Pitrus <bruno...@hotmail.com>
Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Sep 2025 22:22:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Bruno Pitrus <bruno...@hotmail.com>
Comment-In-Reply-To: Mason Freed <mas...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Charlie Harrison (Gerrit)

unread,
Sep 23, 2025, 10:45:51 AM (7 days ago) Sep 23
to Bruno Pitrus, Mason Freed, Kentaro Hara, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-rev...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org
Attention needed from Bruno Pitrus

Charlie Harrison voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Bruno Pitrus
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ice4bae3d23f8cb7bc5324e8c1ce6557bdc1673dc
    Gerrit-Change-Number: 6913443
    Gerrit-PatchSet: 2
    Gerrit-Owner: Bruno Pitrus <bruno...@hotmail.com>
    Gerrit-Reviewer: Bruno Pitrus <bruno...@hotmail.com>
    Gerrit-Reviewer: Charlie Harrison <cshar...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-Attention: Bruno Pitrus <bruno...@hotmail.com>
    Gerrit-Comment-Date: Tue, 23 Sep 2025 14:45:38 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Bruno Pitrus (Gerrit)

    unread,
    Sep 23, 2025, 4:22:28 PM (7 days ago) Sep 23
    to Charlie Harrison, Mason Freed, Kentaro Hara, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-rev...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org

    Bruno Pitrus voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ice4bae3d23f8cb7bc5324e8c1ce6557bdc1673dc
    Gerrit-Change-Number: 6913443
    Gerrit-PatchSet: 2
    Gerrit-Owner: Bruno Pitrus <bruno...@hotmail.com>
    Gerrit-Reviewer: Bruno Pitrus <bruno...@hotmail.com>
    Gerrit-Reviewer: Charlie Harrison <cshar...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-Comment-Date: Tue, 23 Sep 2025 20:22:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages