blink: Pass StackStartMarker to cppgc [chromium/src : main]
0 views
Skip to first unread message
Dominik Inführ (Gerrit)
Mar 17, 2026, 6:06:10 AM (14 days ago) Mar 17
to Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Michael Lippautz
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Mar 17, 2026, 9:15:04 AM (14 days ago) Mar 17
to Dominik Inführ, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Dominik Inführ and Kentaro Hara
Michael Lippautz voted and added 4 comments![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
4 comments
Patchset-level comments
Michael Lippautz . resolved
Generally lgtm
+haraken for owners and more advice on how to structure the layering here. Should we add type aliases for just one use here?
File content/renderer/renderer_main.cc
Line 144, Patchset 4 (Latest):
cppgc::StackStartMarker cppgc_stack_start_marker;Michael Lippautz . unresolved
I think this needs a comment saying roughly what we do here. (E.g., narrow down the native stack that is interesting to cppgc).
Line 211, Patchset 4 (Latest):
Michael Lippautz . unresolved
Since we enter the runloop below. Wouldn't right before the init be a better place?
File third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
Line 1444, Patchset 4 (Latest):
'cppgc::StackStartMarker',Michael Lippautz . unresolved
This should have a comment saying that we need to set the stack marker from outside.
Related details
Attention is currently required from:
- Dominik Inführ
- Kentaro Hara
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kentaro Hara (Gerrit)
Mar 17, 2026, 11:51:08 AM (13 days ago) Mar 17
to Dominik Inführ, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Dominik Inführ
Kentaro Hara voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kentaro Hara
| Code-Review | +1 |
1 comment
File third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
Line 1444, Patchset 4 (Latest):
'cppgc::StackStartMarker',Michael Lippautz . unresolved
This should have a comment saying that we need to set the stack marker from outside.
Kentaro Hara
Adding this here LGTM
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Mar 18, 2026, 5:57:52 AM (13 days ago) Mar 18
to Kentaro Hara, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Kentaro Hara and Michael Lippautz
Dominik Inführ added 3 comments![]( "Open in Gerrit")
File content/renderer/renderer_main.cc
I think this needs a comment saying roughly what we do here. (E.g., narrow down the native stack that is interesting to cppgc).
Dominik Inführ
Done
Since we enter the runloop below. Wouldn't right before the init be a better place?
Dominik Inführ
Done
File third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
Kentaro HaraThis should have a comment saying that we need to set the stack marker from outside.
Adding this here LGTM
Attention is currently required from:
- Kentaro Hara
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Mar 18, 2026, 7:20:09 AM (13 days ago) Mar 18
to Dominik Inführ, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Dominik Inführ and Kentaro Hara
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Dominik Inführ
- Kentaro Hara
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Mar 19, 2026, 3:34:16 PM (11 days ago) Mar 19
to Michael Lippautz, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Kentaro Hara
Dominik Inführ added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Kentaro Hara
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kentaro Hara (Gerrit)
Mar 19, 2026, 7:21:20 PM (11 days ago) Mar 19
to Dominik Inführ, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Dominik Inführ
Kentaro Hara voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Mar 20, 2026, 2:21:22 AM (11 days ago) Mar 20
to Kentaro Hara, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Dominik Inführ . resolved
Thanks a lot for the reviews!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 20, 2026, 3:24:50 AM (11 days ago) Mar 20
to Dominik Inführ, Kentaro Hara, Michael Lippautz, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
blink: Pass StackStartMarker to cppgc
Set up cppgc::StackStartMarker in RendererMain and pass it to
v8::CppHeap::Create. We use that as marker for the stack start, so
that we don't need to scan the stack frames above that during
conservative stack scanning. So far we were using the actual stack
start provided by the system. But that includes potentially large
stack frames like _start on Darwin. This reduces false positives
in conservative stack scanning in Jetstream.
Bug: 492198560
Change-Id: Ied7e925dffecb1a6d681d472e829f644bdcbb655
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Commit-Queue: Dominik Inführ <dinf...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1602449}
Files:
- M content/renderer/renderer_main.cc
- M third_party/blink/public/platform/platform.h
- M third_party/blink/renderer/platform/exported/platform.cc
- M third_party/blink/renderer/platform/heap/thread_state.cc
- M third_party/blink/renderer/platform/heap/thread_state.h
- M third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
Change size: M
Delta: 6 files changed, 46 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kentaro Hara, +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages