Kent Tamura (Gerrit)

unread,

Jul 17, 2025, 9:41:57 PMJul 17

to Kent Tamura, Koji Ishii, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, Raphael Kubo da Costa, Stephen Chenney, blink-re...@chromium.org, blink-revie...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org

Attention needed from Koji Ishii

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit	+1
Commit-Queue	+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Kent Tamura . resolved

kojii@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:

Koji Ishii

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Koji Ishii (Gerrit)

unread,

Jul 18, 2025, 1:16:20 AMJul 18

to Kent Tamura, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, Raphael Kubo da Costa, Stephen Chenney, blink-re...@chromium.org, blink-revie...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org

Attention needed from Kent Tamura

Koji Ishii voted and added 1 comment

Votes added by Koji Ishii

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Koji Ishii . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:

Kent Tamura

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jul 18, 2025, 1:19:06 AMJul 18

to Kent Tamura, Koji Ishii, AyeAye, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, Raphael Kubo da Costa, Stephen Chenney, blink-re...@chromium.org, blink-revie...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Move wtf/type_trails.h to "blink" namespace

This CL also introduces blink::GarbageCollectedTypeV<>,
blink::IsTraceableV<>, and blink::IsWeakV<> to simplify replacement
results.

This CL has no behavior changes.

Bug: 422768753

Change-Id: I88f4cc5baffceefa180fe78f4120468bd5b6c717

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6768052

Reviewed-by: Koji Ishii <ko...@chromium.org>

Commit-Queue: Koji Ishii <ko...@chromium.org>

Auto-Submit: Kent Tamura <tk...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1488645}

Files:

M third_party/blink/public/platform/web_private_ptr.h
M third_party/blink/renderer/bindings/core/v8/native_value_traits_impl.h
M third_party/blink/renderer/bindings/core/v8/promise_all.h
M third_party/blink/renderer/bindings/core/v8/script_promise_tester.h
M third_party/blink/renderer/bindings/core/v8/to_v8_traits.h
M third_party/blink/renderer/core/style/gap_data.h
M third_party/blink/renderer/core/typed_arrays/array_buffer_view_helpers.h
M third_party/blink/renderer/platform/bindings/trace_wrapper_v8_reference.h
M third_party/blink/renderer/platform/graphics/paint/display_item_list.h
M third_party/blink/renderer/platform/heap/collection_support/heap_deque.h
M third_party/blink/renderer/platform/heap/collection_support/heap_hash_counted_set.h
M third_party/blink/renderer/platform/heap/collection_support/heap_hash_map.h
M third_party/blink/renderer/platform/heap/collection_support/heap_hash_set.h
M third_party/blink/renderer/platform/heap/collection_support/heap_hash_table_backing.h
M third_party/blink/renderer/platform/heap/collection_support/heap_linked_hash_set.h
M third_party/blink/renderer/platform/heap/collection_support/heap_linked_stack.h
M third_party/blink/renderer/platform/heap/collection_support/heap_vector.h
M third_party/blink/renderer/platform/heap/collection_support/heap_vector_backing.h
M third_party/blink/renderer/platform/heap/disallow_new_wrapper.h
M third_party/blink/renderer/platform/heap/heap_allocator_impl.h
M third_party/blink/renderer/platform/heap/heap_traits.h
M third_party/blink/renderer/platform/heap/member.h
M third_party/blink/renderer/platform/heap/persistent.h
M third_party/blink/renderer/platform/heap/test/heap_compact_test.cc
M third_party/blink/renderer/platform/heap/test/heap_test.cc
M third_party/blink/renderer/platform/heap/trace_traits.h
M third_party/blink/renderer/platform/heap/write_barrier.h
M third_party/blink/renderer/platform/sparse_vector.h
M third_party/blink/renderer/platform/timer.h
M third_party/blink/renderer/platform/wtf/allocator/allocator.h
M third_party/blink/renderer/platform/wtf/allocator/allocator_test.cc
M third_party/blink/renderer/platform/wtf/cross_thread_copier_base.h
M third_party/blink/renderer/platform/wtf/deque.h
M third_party/blink/renderer/platform/wtf/deque_test.cc
M third_party/blink/renderer/platform/wtf/doubly_linked_list.h
M third_party/blink/renderer/platform/wtf/functional.h
M third_party/blink/renderer/platform/wtf/hash_counted_set.h
M third_party/blink/renderer/platform/wtf/hash_map.h
M third_party/blink/renderer/platform/wtf/hash_map_test.cc
M third_party/blink/renderer/platform/wtf/hash_set_test.cc
M third_party/blink/renderer/platform/wtf/hash_table.h
M third_party/blink/renderer/platform/wtf/key_value_pair.h
M third_party/blink/renderer/platform/wtf/linked_hash_set.h
M third_party/blink/renderer/platform/wtf/linked_hash_set_test.cc
M third_party/blink/renderer/platform/wtf/std_lib_extras.h
M third_party/blink/renderer/platform/wtf/type_traits.h
M third_party/blink/renderer/platform/wtf/type_traits_test.cc
M third_party/blink/renderer/platform/wtf/vector.h
M third_party/blink/renderer/platform/wtf/vector_backed_linked_list.h
M third_party/blink/renderer/platform/wtf/vector_traits.h

Change size: L

Delta: 50 files changed, 233 insertions(+), 306 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Koji Ishii

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Stephen Chenney (Gerrit)

unread,

Jul 27, 2025, 9:52:36 PMJul 27

to Kent Tamura, Chromium LUCI CQ, Koji Ishii, AyeAye, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org

Stephen Chenney added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Stephen Chenney . resolved

This, or one of the earlier related CLs, seems to have broken the Mac precompiled header build, i.e. the mac build for everyone who is not a Googler. There are a whole slew of errors like this for each generated xpath file.

build step: cxx "./obj/third_party/blink/renderer/core/xml/xpath_generated/xpath_grammar_generated.o"
stderr:
In file included from ../../third_party/blink/renderer/core/xml/xpath_grammar_generated.cc:1:
In file included from /Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/core/precompile_core.h:27:
In file included from /Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/core/dom/document.h:61:
In file included from /Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/bindings/core/v8/script_promise.h:36:
In file included from /Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/bindings/core/v8/idl_types.h:14:
In file included from /Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/platform/heap/heap_traits.h:10:
In file included from /Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/platform/heap/collection_support/heap_vector.h:14:
In file included from /Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/platform/heap/heap_allocator_impl.h:9:
In file included from /Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/platform/heap/collection_support/heap_hash_table_backing.h:20:
In file included from /Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/platform/heap/trace_traits.h:14:
/Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/platform/wtf/hash_table.h:642:1: error: [blink-gc] Class 'HashTable<cppgc::internal::BasicMember<blink::TreeScope, cppgc::internal::WeakMemberTag, cppgc::internal::DijkstraWriteBarrierPolicy>, blink::KeyValuePair<cppgc::internal::BasicMember<blink::TreeScope, cppgc::internal::WeakMemberTag, cppgc::internal::DijkstraWriteBarrierPolicy>, unsigned long>, blink::KeyValuePairExtractor, blink::HashMapValueTraits<blink::HashTraits<cppgc::internal::BasicMember<blink::TreeScope, cppgc::internal::WeakMemberTag, cppgc::internal::DijkstraWriteBarrierPolicy>>, blink::HashTraits<unsigned long>>, blink::HashTraits<cppgc::internal::BasicMember<blink::TreeScope, cppgc::internal::WeakMemberTag, cppgc::internal::DijkstraWriteBarrierPolicy>>, blink::HeapAllocator>' contains invalid fields.
  642 | class HashTable final {
      | ^
/Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/platform/wtf/hash_table.h:904:3: note: [blink-gc] Raw pointer field 'table_' to a traceable class declared here:
  904 |   ValueType* table_;
      |   ^

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Kent Tamura (Gerrit)

unread,

Jul 27, 2025, 10:53:58 PMJul 27

to Kent Tamura, Chromium LUCI CQ, Koji Ishii, AyeAye, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, Raphael Kubo da Costa, Stephen Chenney, blink-re...@chromium.org, blink-revie...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org

Kent Tamura added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Stephen Chenney . resolved

This, or one of the earlier related CLs, seems to have broken the Mac precompiled header build, i.e. the mac build for everyone who is not a Googler. There are a whole slew of errors like this for each generated xpath file.

build step: cxx "./obj/third_party/blink/renderer/core/xml/xpath_generated/xpath_grammar_generated.o"
stderr:
In file included from ../../third_party/blink/renderer/core/xml/xpath_grammar_generated.cc:1:
In file included from /Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/core/precompile_core.h:27:
In file included from /Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/core/dom/document.h:61:
In file included from /Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/bindings/core/v8/script_promise.h:36:
In file included from /Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/bindings/core/v8/idl_types.h:14:
In file included from /Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/platform/heap/heap_traits.h:10:
In file included from /Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/platform/heap/collection_support/heap_vector.h:14:
In file included from /Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/platform/heap/heap_allocator_impl.h:9:
In file included from /Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/platform/heap/collection_support/heap_hash_table_backing.h:20:
In file included from /Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/platform/heap/trace_traits.h:14:
/Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/platform/wtf/hash_table.h:642:1: error: [blink-gc] Class 'HashTable<cppgc::internal::BasicMember<blink::TreeScope, cppgc::internal::WeakMemberTag, cppgc::internal::DijkstraWriteBarrierPolicy>, blink::KeyValuePair<cppgc::internal::BasicMember<blink::TreeScope, cppgc::internal::WeakMemberTag, cppgc::internal::DijkstraWriteBarrierPolicy>, unsigned long>, blink::KeyValuePairExtractor, blink::HashMapValueTraits<blink::HashTraits<cppgc::internal::BasicMember<blink::TreeScope, cppgc::internal::WeakMemberTag, cppgc::internal::DijkstraWriteBarrierPolicy>>, blink::HashTraits<unsigned long>>, blink::HashTraits<cppgc::internal::BasicMember<blink::TreeScope, cppgc::internal::WeakMemberTag, cppgc::internal::DijkstraWriteBarrierPolicy>>, blink::HeapAllocator>' contains invalid fields.
  642 | class HashTable final {
      | ^
/Users/schenney/development/chromium_1/src/out/ReleaseGN/../../third_party/blink/renderer/platform/wtf/hash_table.h:904:3: note: [blink-gc] Raw pointer field 'table_' to a traceable class declared here:
  904 |   ValueType* table_;
      |   ^

Kent Tamura

Sorry for the trouble and thank you for notifying me.
Would you file a bug and cc to me and omerkatz@ please?

satisfied_requirement

open

diffy

Omer Katz (Gerrit)

unread,

Jul 28, 2025, 5:57:19 AMJul 28

to Kent Tamura, Chromium LUCI CQ, Koji Ishii, AyeAye, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, Raphael Kubo da Costa, Stephen Chenney, blink-re...@chromium.org, blink-revie...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org

Omer Katz added 1 comment

Patchset-level comments

Omer Katz

Someone external reached out to me last week about this exact failure, but we didn't connect it to the precompiled headers. Without the headers I couldn't reproduce the issue. Maybe this is the hint we needed to get it to repro.
I'm assuming the underlying issue is that the precompiled headers are missing the `__clang__` define and so the plugin ignore annotations become nops.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Move wtf/type_trails.h to "blink" namespace [chromium/src : main]

Kent Tamura (Gerrit)

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

1 comment

Related details

Koji Ishii (Gerrit)

Koji Ishii voted and added 1 comment

Votes added by Koji Ishii

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

Stephen Chenney (Gerrit)

Stephen Chenney added 1 comment

Related details

Kent Tamura (Gerrit)

Kent Tamura added 1 comment

Omer Katz (Gerrit)

Omer Katz added 1 comment

Related details