[cppgc-js] Process weakness at the end of marking [v8/v8 : main]
0 views
Skip to first unread message
Michael Lippautz (Gerrit)
Jun 18, 2024, 2:54:35 PMJun 18
to Omer Katz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Omer Katz
Michael Lippautz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Omer Katz
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
Jun 18, 2024, 5:51:48 PMJun 18
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Omer Katz voted and added 2 comments![]( "Open in Gerrit")
Votes added by Omer Katz
| Code-Review | +1 |
2 comments
Patchset-level comments
Omer Katz . resolved
lgtm
File src/heap/mark-compact.cc
Line 449, Patchset 2 (Latest):
cpp_heap->FinishMarkingAndProcessWeakness();Omer Katz . unresolved
nit: Probably negligible but can this be above the call to `memory_measurement()->FinishProcessing`?
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Jun 19, 2024, 3:28:27 AMJun 19
to Omer Katz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Commit-Queue | +1 |
1 comment
File src/heap/mark-compact.cc
nit: Probably negligible but can this be above the call to `memory_measurement()->FinishProcessing`?
Michael Lippautz
Done
I think the memory measurement stuff is likely anyways misplaced a bit. It should probably go into `Finish()` but maybe there's constraints that don't want sweeping to be active.
Related details
Attention set is empty
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Jun 19, 2024, 9:12:45 AMJun 19
to AyeAye, Omer Katz, V8 LUCI CQ, Hannes Payer, verwaes...@chromium.org, cbruni...@chromium.org, victorgo...@chromium.org, dmercadi...@chromium.org, was...@google.com, leszek...@chromium.org, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Omer Katz
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Commit-Queue | +1 |
Attention is currently required from:
- Omer Katz
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
Jun 19, 2024, 9:18:50 AMJun 19
to Michael Lippautz, AyeAye, V8 LUCI CQ, Hannes Payer, verwaes...@chromium.org, cbruni...@chromium.org, victorgo...@chromium.org, dmercadi...@chromium.org, was...@google.com, leszek...@chromium.org, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Omer Katz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Omer Katz
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Jun 20, 2024, 8:36:36 AMJun 20
to Omer Katz, AyeAye, V8 LUCI CQ, Hannes Payer, verwaes...@chromium.org, cbruni...@chromium.org, victorgo...@chromium.org, dmercadi...@chromium.org, was...@google.com, leszek...@chromium.org, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Michael Lippautz voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jun 20, 2024, 8:38:01 AMJun 20
to Michael Lippautz, Omer Katz, AyeAye, Hannes Payer, verwaes...@chromium.org, cbruni...@chromium.org, victorgo...@chromium.org, dmercadi...@chromium.org, was...@google.com, leszek...@chromium.org, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[cppgc-js] Process weakness at the end of marking
Until weakness is processed in CppHeap the GC must hold a global mutex
to guard against creating cross-thread references.
This patch moves the weakness processing directly after marking which
is also where JS weakness is handled.
Bug: 347686125, 345117891
Change-Id: I6d8ab797cf2dcf2b724911c9d3455c6354997ca4
Commit-Queue: Michael Lippautz <mlip...@chromium.org>
Reviewed-by: Omer Katz <omer...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#94560}
Files:
- M src/heap/cppgc-js/cpp-heap.cc
- M src/heap/cppgc-js/cpp-heap.h
- M src/heap/heap.cc
- M src/heap/mark-compact.cc
- M src/heap/minor-mark-sweep.cc
Change size: S
Delta: 5 files changed, 23 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Omer Katz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages