Reland "[Heap] Unify allocation retry loops" [v8/v8 : main]

0 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
Oct 10, 2025, 2:48:09 PM (11 days ago) Oct 10
to AyeAye, V8 LUCI CQ, Dominik Inführ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org
Attention needed from Dominik Inführ

Etienne Pierre-Doray added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Etienne Pierre-Doray . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Dominik Inführ
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If8e317d590b5f465828836232bd69b49709a390e
Gerrit-Change-Number: 7026473
Gerrit-PatchSet: 5
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Dominik Inführ <dinf...@chromium.org>
Gerrit-Comment-Date: Fri, 10 Oct 2025 18:48:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Dominik Inführ (Gerrit)

unread,
Oct 13, 2025, 9:00:15 AM (8 days ago) Oct 13
to Etienne Pierre-Doray, AyeAye, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org
Attention needed from Etienne Pierre-Doray

Dominik Inführ voted and added 1 comment

Votes added by Dominik Inführ

Code-Review+1

1 comment

Patchset-level comments
Dominik Inführ . resolved

Thanks, LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If8e317d590b5f465828836232bd69b49709a390e
Gerrit-Change-Number: 7026473
Gerrit-PatchSet: 5
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Mon, 13 Oct 2025 12:59:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Oct 13, 2025, 9:16:49 AM (8 days ago) Oct 13
to Dominik Inführ, AyeAye, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org

Etienne Pierre-Doray voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If8e317d590b5f465828836232bd69b49709a390e
Gerrit-Change-Number: 7026473
Gerrit-PatchSet: 5
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Comment-Date: Mon, 13 Oct 2025 13:16:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Oct 13, 2025, 10:11:13 AM (8 days ago) Oct 13
to Etienne Pierre-Doray, Dominik Inführ, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org

V8 LUCI CQ submitted the change

Change information

Commit message:
Reland "[Heap] Unify allocation retry loops"

This is a reland of commit 8ad091e5727571d635aca4ce37cf134ca235140c
Revert: https://chromium-review.googlesource.com/c/v8/v8/+/7021158
Fix: https://chromium-review.googlesource.com/c/chromium/src/+/7026578

Original change's description:
> [Heap] Unify allocation retry loops
>
> This CL reuses HeapAllocator retry loop in several places, including
> oilpan. This ensure they are all aligned under 1 implementation.
> Follow-up: this should also be exposed on v8-isolate so that it can be used here: https://chromium-review.googlesource.com/c/chromium/src/+/6164814
>
> Bug: 448848875
> Change-Id: I646f05b052fa70cae151c1c5ba019f3e9aa5aa37
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7011414
> Reviewed-by: Dominik Inführ <dinf...@chromium.org>
> Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#102997}
Bug: 448848875, 450361757
Change-Id: If8e317d590b5f465828836232bd69b49709a390e
Reviewed-by: Dominik Inführ <dinf...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103089}
Files:
  • M src/heap/cppgc-js/cpp-heap.cc
  • M src/heap/cppgc-js/cpp-heap.h
  • M src/heap/cppgc/garbage-collector.h
  • M src/heap/cppgc/gc-invoker.cc
  • M src/heap/cppgc/gc-invoker.h
  • M src/heap/cppgc/heap.cc
  • M src/heap/cppgc/heap.h
  • M src/heap/cppgc/object-allocator.cc
  • M src/heap/factory-base.cc
  • M src/heap/heap-allocator-inl.h
  • M src/heap/heap-allocator.cc
  • M src/heap/heap-allocator.h
  • M src/heap/heap.cc
  • M test/unittests/heap/cppgc/gc-invoker-unittest.cc
  • M test/unittests/heap/cppgc/heap-growing-unittest.cc
Change size: L
Delta: 15 files changed, 150 insertions(+), 144 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Dominik Inführ
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If8e317d590b5f465828836232bd69b49709a390e
Gerrit-Change-Number: 7026473
Gerrit-PatchSet: 6
open
diffy
satisfied_requirement

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Oct 14, 2025, 10:05:52 AM (7 days ago) Oct 14
to V8 LUCI CQ, Etienne Pierre-Doray, Dominik Inführ, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/speedometer3.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/147bf485510000

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If8e317d590b5f465828836232bd69b49709a390e
Gerrit-Change-Number: 7026473
Gerrit-PatchSet: 6
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Comment-Date: Tue, 14 Oct 2025 14:05:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Oct 14, 2025, 10:06:47 AM (7 days ago) Oct 14
to V8 LUCI CQ, Etienne Pierre-Doray, Dominik Inführ, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/speedometer3.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/156036df510000

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If8e317d590b5f465828836232bd69b49709a390e
Gerrit-Change-Number: 7026473
Gerrit-PatchSet: 6
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Comment-Date: Tue, 14 Oct 2025 14:06:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Oct 14, 2025, 10:08:56 AM (7 days ago) Oct 14
to V8 LUCI CQ, Etienne Pierre-Doray, Dominik Inführ, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org

Message from chrom...@appspot.gserviceaccount.com

😿 Job mac-m1_mini_2020-perf/speedometer3 failed.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/15a10c17510000

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If8e317d590b5f465828836232bd69b49709a390e
Gerrit-Change-Number: 7026473
Gerrit-PatchSet: 6
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Comment-Date: Tue, 14 Oct 2025 14:08:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Oct 14, 2025, 10:09:12 AM (7 days ago) Oct 14
to V8 LUCI CQ, Etienne Pierre-Doray, Dominik Inführ, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/speedometer3 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/16a036df510000

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If8e317d590b5f465828836232bd69b49709a390e
Gerrit-Change-Number: 7026473
Gerrit-PatchSet: 6
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Comment-Date: Tue, 14 Oct 2025 14:09:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages