Reland "[Heap] Unify allocation retry loops" [v8/v8 : main]
0 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Oct 10, 2025, 2:48:09 PM (11 days ago) Oct 10
to AyeAye, V8 LUCI CQ, Dominik Inführ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org
Attention needed from Dominik Inführ
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Oct 13, 2025, 9:00:15 AM (8 days ago) Oct 13
to Etienne Pierre-Doray, AyeAye, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org
Attention needed from Etienne Pierre-Doray
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Oct 13, 2025, 9:16:49 AM (8 days ago) Oct 13
to Dominik Inführ, AyeAye, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Oct 13, 2025, 10:11:13 AM (8 days ago) Oct 13
to Etienne Pierre-Doray, Dominik Inführ, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reland "[Heap] Unify allocation retry loops"
This is a reland of commit 8ad091e5727571d635aca4ce37cf134ca235140c
Revert: https://chromium-review.googlesource.com/c/v8/v8/+/7021158
Fix: https://chromium-review.googlesource.com/c/chromium/src/+/7026578
Original change's description:
> [Heap] Unify allocation retry loops
>
> This CL reuses HeapAllocator retry loop in several places, including
> oilpan. This ensure they are all aligned under 1 implementation.
> Follow-up: this should also be exposed on v8-isolate so that it can be used here: https://chromium-review.googlesource.com/c/chromium/src/+/6164814
>
> Bug: 448848875
> Change-Id: I646f05b052fa70cae151c1c5ba019f3e9aa5aa37
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7011414
> Reviewed-by: Dominik Inführ <dinf...@chromium.org>
> Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#102997}
Bug: 448848875, 450361757
Change-Id: If8e317d590b5f465828836232bd69b49709a390e
Reviewed-by: Dominik Inführ <dinf...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103089}
Files:
- M src/heap/cppgc-js/cpp-heap.cc
- M src/heap/cppgc-js/cpp-heap.h
- M src/heap/cppgc/garbage-collector.h
- M src/heap/cppgc/gc-invoker.cc
- M src/heap/cppgc/gc-invoker.h
- M src/heap/cppgc/heap.cc
- M src/heap/cppgc/heap.h
- M src/heap/cppgc/object-allocator.cc
- M src/heap/factory-base.cc
- M src/heap/heap-allocator-inl.h
- M src/heap/heap-allocator.cc
- M src/heap/heap-allocator.h
- M src/heap/heap.cc
- M test/unittests/heap/cppgc/gc-invoker-unittest.cc
- M test/unittests/heap/cppgc/heap-growing-unittest.cc
Change size: L
Delta: 15 files changed, 150 insertions(+), 144 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dominik Inführ
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Oct 14, 2025, 10:05:52 AM (7 days ago) Oct 14
to V8 LUCI CQ, Etienne Pierre-Doray, Dominik Inführ, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/speedometer3.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/147bf485510000
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Oct 14, 2025, 10:06:47 AM (7 days ago) Oct 14
to V8 LUCI CQ, Etienne Pierre-Doray, Dominik Inführ, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/speedometer3.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/156036df510000
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Oct 14, 2025, 10:08:56 AM (7 days ago) Oct 14
to V8 LUCI CQ, Etienne Pierre-Doray, Dominik Inführ, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
😿 Job mac-m1_mini_2020-perf/speedometer3 failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/15a10c17510000
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Oct 14, 2025, 10:09:12 AM (7 days ago) Oct 14
to V8 LUCI CQ, Etienne Pierre-Doray, Dominik Inführ, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/speedometer3 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/16a036df510000
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages