Allow intentional use-after-dtor in VectorBuffer tests [chromium/src : main]

0 views
Skip to first unread message

Daniel Cheng (Gerrit)

unread,
May 27, 2024, 4:53:13 AMMay 27
to Daniel Cheng, danakj, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from danakj

Daniel Cheng added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Daniel Cheng . unresolved

... would be interested in other options too :)

Open in Gerrit

Related details

Attention is currently required from:
  • danakj
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0913c782a3c999d5aef8d565051ffa0685702a22
Gerrit-Change-Number: 5572567
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: danakj <dan...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: danakj <dan...@chromium.org>
Gerrit-Comment-Date: Mon, 27 May 2024 08:53:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

danakj (Gerrit)

unread,
May 27, 2024, 9:59:27 AMMay 27
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Daniel Cheng

danakj added 1 comment

File base/containers/vector_buffer_unittest.cc
Line 79, Patchset 2 (Latest): // Delete should have reset all of the values to 0. This dereferences the
danakj . unresolved

Can we observe the dtor running instead (have it increment something)?

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0913c782a3c999d5aef8d565051ffa0685702a22
Gerrit-Change-Number: 5572567
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: danakj <dan...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Mon, 27 May 2024 13:59:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

mmenke (Gerrit)

unread,
May 30, 2024, 1:15:12 PMMay 30
to Daniel Cheng, Rijubrata Bhaumik, chromotin...@chromium.org, Elly FJ, danakj, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, odejesu...@chromium.org, yigu+...@chromium.org, alexmo...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blundell+...@chromium.org, cblume+im...@chromium.org, creis...@chromium.org, mbarowsky+watc...@chromium.org, navigation...@chromium.org, zhangwen...@google.com, zol...@webkit.org, cc-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Daniel Cheng and Elly FJ

mmenke added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
mmenke . resolved

Erm...I commented and CQed on another of Daniel's CL, and somehow I ended up magically CQing this one as well? Filing a gerrit bug, but that is very concerning

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
  • Elly FJ
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0913c782a3c999d5aef8d565051ffa0685702a22
Gerrit-Change-Number: 5572567
Gerrit-PatchSet: 6
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: danakj <dan...@chromium.org>
Gerrit-Reviewer: mmenke <mme...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Elly FJ <elly...@chromium.org>
Gerrit-Comment-Date: Thu, 30 May 2024 17:15:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

danakj (Gerrit)

unread,
May 30, 2024, 1:18:20 PMMay 30
to Daniel Cheng, Rijubrata Bhaumik, chromotin...@chromium.org, Elly FJ, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, odejesu...@chromium.org, yigu+...@chromium.org, alexmo...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blundell+...@chromium.org, cblume+im...@chromium.org, creis...@chromium.org, mbarowsky+watc...@chromium.org, navigation...@chromium.org, zhangwen...@google.com, zol...@webkit.org, cc-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Daniel Cheng and Elly FJ

danakj added 1 comment

Patchset-level comments
mmenke . resolved

Erm...I commented and CQed on another of Daniel's CL, and somehow I ended up magically CQing this one as well? Filing a gerrit bug, but that is very concerning

danakj

there's a bunch of CLs that depend on this one, submitting any of them will submit this (chained submits) fbofw

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
  • Elly FJ
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0913c782a3c999d5aef8d565051ffa0685702a22
Gerrit-Change-Number: 5572567
Gerrit-PatchSet: 6
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: danakj <dan...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Elly FJ <elly...@chromium.org>
Gerrit-Comment-Date: Thu, 30 May 2024 17:18:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: mmenke <mme...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
May 30, 2024, 1:26:47 PMMay 30
to Daniel Cheng, Rijubrata Bhaumik, chromotin...@chromium.org, Elly FJ, danakj, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, odejesu...@chromium.org, yigu+...@chromium.org, alexmo...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blundell+...@chromium.org, cblume+im...@chromium.org, creis...@chromium.org, mbarowsky+watc...@chromium.org, navigation...@chromium.org, zhangwen...@google.com, zol...@webkit.org, cc-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Elly FJ

Daniel Cheng added 1 comment

Patchset-level comments
mmenke . resolved

Erm...I commented and CQed on another of Daniel's CL, and somehow I ended up magically CQing this one as well? Filing a gerrit bug, but that is very concerning

danakj

there's a bunch of CLs that depend on this one, submitting any of them will submit this (chained submits) fbofw

Daniel Cheng

I filed a bug for this already (but I can't find it because I have no idea which buganizer silo it's in)

Open in Gerrit

Related details

Attention is currently required from:
  • Elly FJ
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0913c782a3c999d5aef8d565051ffa0685702a22
Gerrit-Change-Number: 5572567
Gerrit-PatchSet: 6
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: danakj <dan...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Elly FJ <elly...@chromium.org>
Gerrit-Comment-Date: Thu, 30 May 2024 17:26:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: danakj <dan...@chromium.org>
Comment-In-Reply-To: mmenke <mme...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
May 30, 2024, 1:27:51 PMMay 30
to Daniel Cheng, Rijubrata Bhaumik, chromotin...@chromium.org, Elly FJ, danakj, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, odejesu...@chromium.org, yigu+...@chromium.org, alexmo...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blundell+...@chromium.org, cblume+im...@chromium.org, creis...@chromium.org, mbarowsky+watc...@chromium.org, navigation...@chromium.org, zhangwen...@google.com, zol...@webkit.org, cc-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Elly FJ

Daniel Cheng added 1 comment

Patchset-level comments
mmenke . unresolved

Erm...I commented and CQed on another of Daniel's CL, and somehow I ended up magically CQing this one as well? Filing a gerrit bug, but that is very concerning

danakj

there's a bunch of CLs that depend on this one, submitting any of them will submit this (chained submits) fbofw

Daniel Cheng

I filed a bug for this already (but I can't find it because I have no idea which buganizer silo it's in)

Daniel Cheng

Ah-ha it's https://crbug.com/339682316. I was expecting it to show up in the first page of reported by me bugs, but I guess someone did a bunch of bulk updates recently and pushed it off

Gerrit-Comment-Date: Thu, 30 May 2024 17:27:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jun 13, 2024, 1:58:38 PMJun 13
to Daniel Cheng, Peter Kasting, Rijubrata Bhaumik, chromotin...@chromium.org, danakj, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, andysjl...@chromium.org, armalhotra+a...@google.com, druber...@chromium.org, feliciac+au...@google.com, jsaul+aut...@google.com, nwoked...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vakh+safe_br...@chromium.org, vinnypersky+...@google.com, xinghui...@chromium.org, zackha...@chromium.org, lwinston+watc...@google.com, trewin...@google.com, browser-comp...@chromium.org, rouslan+au...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, odejesu...@chromium.org, yigu+...@chromium.org, alexmo...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blundell+...@chromium.org, cblume+im...@chromium.org, creis...@chromium.org, mbarowsky+watc...@chromium.org, navigation...@chromium.org, zhangwen...@google.com, zol...@webkit.org, cc-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Daniel Cheng

Daniel Cheng removed Peter Kasting from this change

Deleted Reviewers:
  • Peter Kasting
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteReviewer
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0913c782a3c999d5aef8d565051ffa0685702a22
Gerrit-Change-Number: 5572567
Gerrit-PatchSet: 16
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: danakj <dan...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jun 13, 2024, 4:37:04 PMJun 13
to Daniel Cheng, Min Qin, Rijubrata Bhaumik, chromotin...@chromium.org, danakj, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, andysjl...@chromium.org, armalhotra+a...@google.com, druber...@chromium.org, feliciac+au...@google.com, jsaul+aut...@google.com, nwoked...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vakh+safe_br...@chromium.org, vinnypersky+...@google.com, xinghui...@chromium.org, zackha...@chromium.org, lwinston+watc...@google.com, trewin...@google.com, browser-comp...@chromium.org, rouslan+au...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, odejesu...@chromium.org, yigu+...@chromium.org, alexmo...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blundell+...@chromium.org, cblume+im...@chromium.org, creis...@chromium.org, mbarowsky+watc...@chromium.org, navigation...@chromium.org, zhangwen...@google.com, zol...@webkit.org, cc-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Daniel Cheng

Daniel Cheng removed Min Qin from this change

Deleted Reviewers:
  • Min Qin
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteReviewer
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0913c782a3c999d5aef8d565051ffa0685702a22
Gerrit-Change-Number: 5572567
Gerrit-PatchSet: 17
satisfied_requirement
unsatisfied_requirement
open
diffy

Dominic Battré (Gerrit)

unread,
Jun 14, 2024, 5:16:27 AMJun 14
to Daniel Cheng, Rijubrata Bhaumik, chromotin...@chromium.org, danakj, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, penghu...@chromium.org, andysjl...@chromium.org, armalhotra+a...@google.com, druber...@chromium.org, feliciac+au...@google.com, jsaul+aut...@google.com, nwoked...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vakh+safe_br...@chromium.org, vinnypersky+...@google.com, xinghui...@chromium.org, zackha...@chromium.org, lwinston+watc...@google.com, trewin...@google.com, browser-comp...@chromium.org, rouslan+au...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, odejesu...@chromium.org, yigu+...@chromium.org, alexmo...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blundell+...@chromium.org, cblume+im...@chromium.org, creis...@chromium.org, mbarowsky+watc...@chromium.org, navigation...@chromium.org, zhangwen...@google.com, zol...@webkit.org, cc-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Daniel Cheng

Dominic Battré added 1 comment

Patchset-level comments
File-level comment, Patchset 18 (Latest):
Dominic Battré . resolved

I did not mean to add myself as a reviewer

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0913c782a3c999d5aef8d565051ffa0685702a22
Gerrit-Change-Number: 5572567
Gerrit-PatchSet: 18
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: danakj <dan...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Fri, 14 Jun 2024 09:16:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages