Add checks for thread-unsafe refcounted types in `CrossThreadBind*()` [chromium/src : main]

0 views
Skip to first unread message

Daniel Cheng (Gerrit)

unread,
Nov 26, 2025, 3:19:16 AM (12 days ago) Nov 26
to Daniel Cheng, Dave Tapuska, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Kentaro Hara, Hirokazu Honda, Hongchan Choi, Nate Chapin, Raphael Kubo da Costa, Stephen Chenney, srirama chandra sekhar, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, devtools-re...@chromium.org, dom+...@chromium.org, drott+bl...@chromium.org, emircan+watch...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kouhei...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, oilpan-rev...@chromium.org, shimazu...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com
Attention needed from Dave Tapuska

Daniel Cheng added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Daniel Cheng . resolved

Note that I'm intentionally landing the test separately, because that way I don't have to add a bunch of temporary error assertions or a bunch of temporary boilerplate to make things happy.

Open in Gerrit

Related details

Attention is currently required from:
  • Dave Tapuska
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I45e4608b1ffa338c0597855634952d8c1bce38c0
Gerrit-Change-Number: 7204750
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Hirokazu Honda <hi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
Gerrit-Comment-Date: Wed, 26 Nov 2025 08:19:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dave Tapuska (Gerrit)

unread,
Nov 26, 2025, 10:11:17 AM (12 days ago) Nov 26
to Daniel Cheng, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Kentaro Hara, Hirokazu Honda, Hongchan Choi, Nate Chapin, Raphael Kubo da Costa, Stephen Chenney, srirama chandra sekhar, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, devtools-re...@chromium.org, dom+...@chromium.org, drott+bl...@chromium.org, emircan+watch...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kouhei...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, oilpan-rev...@chromium.org, shimazu...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com
Attention needed from Daniel Cheng

Dave Tapuska voted and added 2 comments

Votes added by Dave Tapuska

Code-Review+1

2 comments

Patchset-level comments
Dave Tapuska . unresolved

Any chance we can add a test or two in third_party/blink/renderer/platform/wtf/functional_nocompile.nc

?

File third_party/blink/renderer/platform/wtf/functional_internal.h
Line 1, Patchset 3 (Latest):#ifndef THIRD_PARTY_BLINK_RENDERER_PLATFORM_WTF_FUNCTIONAL_INTERNAL_H_
Dave Tapuska . unresolved

Requires copyright

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I45e4608b1ffa338c0597855634952d8c1bce38c0
    Gerrit-Change-Number: 7204750
    Gerrit-PatchSet: 3
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Hirokazu Honda <hi...@chromium.org>
    Gerrit-CC: Hongchan Choi <hong...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Wed, 26 Nov 2025 15:11:08 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Nov 26, 2025, 11:34:57 AM (12 days ago) Nov 26
    to Daniel Cheng, Dave Tapuska, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Kentaro Hara, Hirokazu Honda, Hongchan Choi, Nate Chapin, Raphael Kubo da Costa, Stephen Chenney, srirama chandra sekhar, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, devtools-re...@chromium.org, dom+...@chromium.org, drott+bl...@chromium.org, emircan+watch...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kouhei...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, oilpan-rev...@chromium.org, shimazu...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com

    Daniel Cheng added 2 comments

    Patchset-level comments
    Dave Tapuska . resolved

    Any chance we can add a test or two in third_party/blink/renderer/platform/wtf/functional_nocompile.nc

    ?

    Daniel Cheng

    This is intentionally added in a followup because the CrossThreadCopier removal affects error messages, and I don't want to add a bunch of temporary boilerplate just to remove it in a followup.

    File third_party/blink/renderer/platform/wtf/functional_internal.h
    Line 1, Patchset 3 (Latest):#ifndef THIRD_PARTY_BLINK_RENDERER_PLATFORM_WTF_FUNCTIONAL_INTERNAL_H_
    Dave Tapuska . resolved

    Requires copyright

    Daniel Cheng

    Oops fixed.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Gerrit-Comment-Date: Wed, 26 Nov 2025 16:34:45 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Dave Tapuska <dtap...@chromium.org>
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Nov 26, 2025, 12:40:02 PM (12 days ago) Nov 26
      to Daniel Cheng, Dave Tapuska, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Kentaro Hara, Hirokazu Honda, Hongchan Choi, Nate Chapin, Raphael Kubo da Costa, Stephen Chenney, srirama chandra sekhar, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, devtools-re...@chromium.org, dom+...@chromium.org, drott+bl...@chromium.org, emircan+watch...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kouhei...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, oilpan-rev...@chromium.org, shimazu...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com

      Chromium LUCI CQ submitted the change with unreviewed changes

      Unreviewed changes

      3 is the latest approved patch-set.
      The change was submitted with unreviewed changes in the following files:

      ```
      The name of the file: third_party/blink/renderer/platform/wtf/functional_internal.h
      Insertions: 4, Deletions: 0.

      @@ -1,3 +1,7 @@
      +// Copyright 2025 The ChromiumOS Authors
      +// Use of this source code is governed by a BSD-style license that can be
      +// found in the LICENSE file.
      +
       #ifndef THIRD_PARTY_BLINK_RENDERER_PLATFORM_WTF_FUNCTIONAL_INTERNAL_H_
       #define THIRD_PARTY_BLINK_RENDERER_PLATFORM_WTF_FUNCTIONAL_INTERNAL_H_
       
      ```

      Change information

      Commit message:
      Add checks for thread-unsafe refcounted types in `CrossThreadBind*()`

      Currently, this is checked by `CrossThreadCopier` specializations;
      however, `CrossThreadCopier` will be removed in a followup.
      Bug: 460743390
      Change-Id: I45e4608b1ffa338c0597855634952d8c1bce38c0
      Reviewed-by: Dave Tapuska <dtap...@chromium.org>
      Commit-Queue: Daniel Cheng <dch...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1550582}
      Files:
      • M third_party/blink/renderer/platform/wtf/BUILD.gn
      • M third_party/blink/renderer/platform/wtf/DEPS
      • M third_party/blink/renderer/platform/wtf/cross_thread_functional.h
      • M third_party/blink/renderer/platform/wtf/functional.h
      • A third_party/blink/renderer/platform/wtf/functional_internal.h
      Change size: M
      Delta: 5 files changed, 113 insertions(+), 43 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Dave Tapuska
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I45e4608b1ffa338c0597855634952d8c1bce38c0
      Gerrit-Change-Number: 7204750
      Gerrit-PatchSet: 5
      Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages