Migrate various base::Contains() to contains() in blink [chromium/src : main]

0 views
Skip to first unread message

Victor Vianna (Gerrit)

unread,
Jan 6, 2026, 2:25:31 AM (12 days ago) Jan 6
to Mike West, chromium...@chromium.org, Kentaro Hara, Hirokazu Honda, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Mike Taylor, prerendering-reviews, Rijubrata Bhaumik, Victor Tan, Yoav Weiss (@Shopify), Chromium LUCI CQ, abigailbk...@google.com, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, gavinp+p...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, loading-re...@chromium.org, loading...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, nektar...@chromium.org, oilpan-rev...@chromium.org, speed-metrics...@chromium.org, video-networking...@google.com, yuzo+...@chromium.org
Attention needed from Mike West

Victor Vianna voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mike West
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If3f563967ff4a3ba73e398c6016004eb16a02298
Gerrit-Change-Number: 7368552
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Mike West <mk...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Hirokazu Honda <hi...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Mike Taylor <mike...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Victor Tan <vict...@chromium.org>
Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Mike West <mk...@chromium.org>
Gerrit-Comment-Date: Tue, 06 Jan 2026 07:25:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Mike West (Gerrit)

unread,
Jan 7, 2026, 3:30:04 AM (11 days ago) Jan 7
to Victor Vianna, chromium...@chromium.org, Kentaro Hara, Hirokazu Honda, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Mike Taylor, prerendering-reviews, Rijubrata Bhaumik, Victor Tan, Yoav Weiss (@Shopify), Chromium LUCI CQ, abigailbk...@google.com, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, gavinp+p...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, loading-re...@chromium.org, loading...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, nektar...@chromium.org, oilpan-rev...@chromium.org, speed-metrics...@chromium.org, video-networking...@google.com, yuzo+...@chromium.org
Attention needed from Victor Vianna

Mike West voted and added 1 comment

Votes added by Mike West

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Gerrit-Attention: Victor Vianna <victor...@google.com>
Gerrit-Comment-Date: Wed, 07 Jan 2026 08:29:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 7, 2026, 3:34:19 AM (11 days ago) Jan 7
to Victor Vianna, Mike West, Akihiro Ota, chromium...@chromium.org, Kentaro Hara, Hirokazu Honda, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Mike Taylor, prerendering-reviews, Rijubrata Bhaumik, Victor Tan, Yoav Weiss (@Shopify), abigailbk...@google.com, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, gavinp+p...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, loading-re...@chromium.org, loading...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, nektar...@chromium.org, oilpan-rev...@chromium.org, speed-metrics...@chromium.org, video-networking...@google.com, yuzo+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Migrate various base::Contains() to contains() in blink
Bug: 470391351
Change-Id: If3f563967ff4a3ba73e398c6016004eb16a02298
Auto-Submit: Victor Vianna <victor...@google.com>
Reviewed-by: Mike West <mk...@chromium.org>
Commit-Queue: Mike West <mk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1565469}
Files:
  • M third_party/blink/common/associated_interfaces/associated_interface_provider.cc
  • M third_party/blink/common/interest_group/auction_config_mojom_traits.cc
  • M third_party/blink/common/mime_util/mime_util.cc
  • M third_party/blink/common/scheme_registry.cc
  • M third_party/blink/common/service_worker/service_worker_scope_match.cc
  • M third_party/blink/renderer/core/frame/local_dom_window.cc
  • M third_party/blink/renderer/core/html/anchor_element_metrics_sender_test.cc
  • M third_party/blink/renderer/core/html/client_hints_util.cc
  • M third_party/blink/renderer/core/speculation_rules/speculation_rules_header.cc
  • M third_party/blink/renderer/core/timing/performance.cc
  • M third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc
  • M third_party/blink/renderer/modules/accessibility/ax_node_object.cc
  • M third_party/blink/renderer/modules/accessibility/blink_ax_tree_source.cc
  • M third_party/blink/renderer/modules/ad_auction/navigator_auction.cc
  • M third_party/blink/renderer/modules/document_picture_in_picture/picture_in_picture_controller_test.cc
  • M third_party/blink/renderer/modules/font_access/font_access.cc
  • M third_party/blink/renderer/modules/nfc/ndef_record.cc
  • M third_party/blink/renderer/platform/disk_data_allocator.cc
  • M third_party/blink/renderer/platform/heap/test/blink_gc_memory_dump_provider_test.cc
  • M third_party/blink/renderer/platform/loader/cors/cors.cc
  • M third_party/blink/renderer/platform/loader/fetch/resource_response.cc
  • M third_party/blink/renderer/platform/media/cache_util.cc
  • M third_party/blink/renderer/platform/media/cdm_session_adapter.cc
  • M third_party/blink/renderer/platform/media/resource_multi_buffer_data_provider.cc
  • M third_party/blink/renderer/platform/media/resource_multi_buffer_data_provider_unittest.cc
  • M third_party/blink/renderer/platform/peerconnection/rtc_stats.cc
  • M third_party/blink/renderer/platform/peerconnection/video_encoder_state_observer_impl.cc
Change size: M
Delta: 27 files changed, 31 insertions(+), 63 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mike West
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If3f563967ff4a3ba73e398c6016004eb16a02298
Gerrit-Change-Number: 7368552
Gerrit-PatchSet: 2
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Mike West <mk...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages