Revert "Pass heap snapshot source locations through blink::WebNode (and subclasses), autofill::FormRef, and autofill::FieldRef." [chromium/src : main]

0 views
Skip to first unread message

Victor Tan (Gerrit)

unread,
Dec 11, 2025, 4:45:45 PMDec 11
to Rubber Stamper, Dominic Farolino, Chromium LUCI CQ, David Baron, Daniel Cheng, AyeAye, Michael Lippautz, chromium...@chromium.org, Kentaro Hara, kouhe...@chromium.org, oilpan-rev...@chromium.org, browser-comp...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org
Attention needed from Christoph Schwering, Daniel Cheng, David Baron and Dominic Farolino

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Christoph Schwering
  • Daniel Cheng
  • David Baron
  • Dominic Farolino
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I36ea76418694757cdc9e24582a801a70aeb47e7c
Gerrit-Change-Number: 7253393
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Tan <vict...@chromium.org>
Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: David Baron <dba...@chromium.org>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Michael Lippautz <mlip...@chromium.org>
Gerrit-Attention: Dominic Farolino <d...@chromium.org>
Gerrit-Attention: Christoph Schwering <schw...@google.com>
Gerrit-Attention: David Baron <dba...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Thu, 11 Dec 2025 21:45:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Dec 11, 2025, 4:46:15 PMDec 11
to Victor Tan, Dominic Farolino, Chromium LUCI CQ, David Baron, Daniel Cheng, AyeAye, Michael Lippautz, chromium...@chromium.org, Kentaro Hara, kouhe...@chromium.org, oilpan-rev...@chromium.org, browser-comp...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org
Attention needed from Christoph Schwering, Daniel Cheng, David Baron and Dominic Farolino

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Christoph Schwering
  • Daniel Cheng
  • David Baron
  • Dominic Farolino
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I36ea76418694757cdc9e24582a801a70aeb47e7c
    Gerrit-Change-Number: 7253393
    Gerrit-PatchSet: 1
    Gerrit-Owner: Victor Tan <vict...@chromium.org>
    Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Michael Lippautz <mlip...@chromium.org>
    Gerrit-Attention: Dominic Farolino <d...@chromium.org>
    Gerrit-Attention: Christoph Schwering <schw...@google.com>
    Gerrit-Attention: David Baron <dba...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Thu, 11 Dec 2025 21:46:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Victor Tan (Gerrit)

    unread,
    Dec 11, 2025, 4:48:56 PMDec 11
    to Rubber Stamper, Dominic Farolino, Chromium LUCI CQ, David Baron, Daniel Cheng, AyeAye, Michael Lippautz, chromium...@chromium.org, Kentaro Hara, kouhe...@chromium.org, oilpan-rev...@chromium.org, browser-comp...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org
    Attention needed from Christoph Schwering, Daniel Cheng, David Baron and Dominic Farolino

    Victor Tan voted Owners-Override+1

    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Christoph Schwering
    • Daniel Cheng
    • David Baron
    • Dominic Farolino
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I36ea76418694757cdc9e24582a801a70aeb47e7c
    Gerrit-Change-Number: 7253393
    Gerrit-PatchSet: 1
    Gerrit-Owner: Victor Tan <vict...@chromium.org>
    Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Victor Tan <vict...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Michael Lippautz <mlip...@chromium.org>
    Gerrit-Attention: Dominic Farolino <d...@chromium.org>
    Gerrit-Attention: Christoph Schwering <schw...@google.com>
    Gerrit-Attention: David Baron <dba...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Thu, 11 Dec 2025 21:48:48 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Victor Tan (Gerrit)

    unread,
    Dec 11, 2025, 4:50:38 PMDec 11
    to Rubber Stamper, Dominic Farolino, Chromium LUCI CQ, David Baron, Daniel Cheng, AyeAye, Michael Lippautz, chromium...@chromium.org, Kentaro Hara, kouhe...@chromium.org, oilpan-rev...@chromium.org, browser-comp...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org
    Attention needed from Christoph Schwering, Daniel Cheng, David Baron and Dominic Farolino

    Victor Tan voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Thu, 11 Dec 2025 21:50:32 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 11, 2025, 4:51:05 PMDec 11
    to Victor Tan, Rubber Stamper, Dominic Farolino, David Baron, Daniel Cheng, AyeAye, Michael Lippautz, chromium...@chromium.org, Kentaro Hara, kouhe...@chromium.org, oilpan-rev...@chromium.org, browser-comp...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "Pass heap snapshot source locations through blink::WebNode (and subclasses), autofill::FormRef, and autofill::FieldRef."

    This reverts commit 4156d6460349a7c1520136ff2be479065ad7c7cd.

    Reason for revert: tree close https://ci.chromium.org/ui/p/chromium/builders/ci/Android%20arm%20Builder%20(dbg)/84021/overview

    Original change's description:
    > Pass heap snapshot source locations through blink::WebNode (and subclasses), autofill::FormRef, and autofill::FieldRef.
    >
    > Bug: 342247579
    > Change-Id: Ieb2a490455048063184fb0c79a539093b5d26b2b
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7224596
    > Reviewed-by: Daniel Cheng <dch...@chromium.org>
    > Reviewed-by: Christoph Schwering <schw...@google.com>
    > Commit-Queue: David Baron <dba...@chromium.org>
    > Reviewed-by: Dominic Farolino <d...@chromium.org>
    > Owners-Override: Daniel Cheng <dch...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1557625}
    Bug: 342247579
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Change-Id: I36ea76418694757cdc9e24582a801a70aeb47e7c
    Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Commit-Queue: Victor Tan <vict...@chromium.org>
    Owners-Override: Victor Tan <vict...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1557668}
    Files:
    • M components/autofill/content/renderer/autofill_agent.cc
    • M components/autofill/content/renderer/form_tracker.cc
    • M components/autofill/content/renderer/form_tracker.h
    • M third_party/blink/public/BUILD.gn
    • M third_party/blink/public/web/web_document.h
    • M third_party/blink/public/web/web_element.h
    • M third_party/blink/public/web/web_form_control_element.h
    • M third_party/blink/public/web/web_form_element.h
    • M third_party/blink/public/web/web_input_element.h
    • M third_party/blink/public/web/web_label_element.h
    • M third_party/blink/public/web/web_meta_element.h
    • M third_party/blink/public/web/web_node.h
    • M third_party/blink/public/web/web_option_element.h
    • M third_party/blink/public/web/web_select_element.h
    • M third_party/blink/renderer/core/exported/web_node.cc
    • M third_party/blink/renderer/platform/heap/BUILD.gn
    • M third_party/blink/renderer/platform/heap/cross_thread_handle_internal.h
    • M third_party/blink/renderer/platform/heap/persistent.h
    • M third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
    Change size: M
    Delta: 19 files changed, 21 insertions(+), 69 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: Bot-Commit+1 by Rubber Stamper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I36ea76418694757cdc9e24582a801a70aeb47e7c
    Gerrit-Change-Number: 7253393
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages