[profiler] Add suffix to C++ Window object in DevTools heap snapshot [v8/v8 : main]

0 views

Skip to first unread message

Andreas Haas (Gerrit)

unread,

Nov 19, 2025, 8:10:56 AMNov 19

to Igor Sheludko, Dominik Inführ, Michael Lippautz, V8 LUCI CQ, AyeAye, oilpan-r...@chromium.org, devtools-...@chromium.org

Attention needed from Michael Lippautz

Andreas Haas voted and added 1 comment

Votes added by Andreas Haas

Commit-Queue

1 comment

Commit Message

Line 7, Patchset 4:Reland "[profiler] Add postfix to C++ objects in DevTools heap snapshot"

Igor Sheludko . resolved

Please update the comment. This is not a reland this is a completely different CL. Also the suffix you add is different.

Andreas Haas

Done

Open in Gerrit

Related details

Attention is currently required from:

Michael Lippautz

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

V8 LUCI CQ (Gerrit)

unread,

Nov 19, 2025, 8:46:59 AMNov 19

to Andreas Haas, Igor Sheludko, Dominik Inführ, Michael Lippautz, AyeAye, oilpan-r...@chromium.org, devtools-...@chromium.org

V8 LUCI CQ submitted the change

Unreviewed changes

4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

[profiler] Add suffix to C++ Window object in DevTools heap snapshot

In a Chrome DevTools heap snapshot, both JavaScript and C++ objects are
shown. In some instances, both a JavaScript object and a C++ object can
even have the same name, e.g. "Window" objects. With this CL, the suffix
"cppgc" is added to C++ Window objects so that they can be distinguished
from JavaScript objects.

Bug: 454073115

Change-Id: Ia47ce671b4c15971921821a12be46f0a63be550a

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7156718

Reviewed-by: Dominik Inführ <dinf...@chromium.org>

Reviewed-by: Igor Sheludko <ish...@chromium.org>

Commit-Queue: Andreas Haas <ah...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#103822}

Files:

M src/profiler/heap-snapshot-generator.cc

Change size: S

Delta: 1 file changed, 12 insertions(+), 3 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Dominik Inführ, +1 by Igor Sheludko

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages