[heap] Unify young and old epochs to a single epoch [v8/v8 : main]

0 views
Skip to first unread message

Dominik Inführ (Gerrit)

unread,
Nov 13, 2025, 9:01:30 AMNov 13
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz

Dominik Inführ added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Dominik Inführ . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I400aef02ace44d251415083edac74573e7940a3c
Gerrit-Change-Number: 7150844
Gerrit-PatchSet: 2
Gerrit-Owner: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Thu, 13 Nov 2025 14:01:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
Nov 13, 2025, 11:18:31 AMNov 13
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ

Michael Lippautz voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dominik Inführ
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I400aef02ace44d251415083edac74573e7940a3c
Gerrit-Change-Number: 7150844
Gerrit-PatchSet: 2
Gerrit-Owner: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Dominik Inführ <dinf...@chromium.org>
Gerrit-Comment-Date: Thu, 13 Nov 2025 16:18:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Dominik Inführ (Gerrit)

unread,
Nov 14, 2025, 2:44:53 AMNov 14
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com

Dominik Inführ voted and added 1 comment

Votes added by Dominik Inführ

Commit-Queue+2

1 comment

Patchset-level comments
Dominik Inführ . resolved

Thanks for the review!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I400aef02ace44d251415083edac74573e7940a3c
Gerrit-Change-Number: 7150844
Gerrit-PatchSet: 2
Gerrit-Owner: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Comment-Date: Fri, 14 Nov 2025 07:44:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Nov 14, 2025, 2:46:43 AMNov 14
to Dominik Inführ, Michael Lippautz, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[heap] Unify young and old epochs to a single epoch

Scavenger can't run during incremental marking anymore, so we can
unify epoch_young_ and epoch_old now to a single epoch_.
Bug: 456384548
Change-Id: I400aef02ace44d251415083edac74573e7940a3c
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Dominik Inführ <dinf...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103715}
Files:
  • M src/handles/traced-handles.cc
  • M src/heap/array-buffer-sweeper.cc
  • M src/heap/array-buffer-sweeper.h
  • M src/heap/concurrent-marking.cc
  • M src/heap/gc-tracer-inl.h
  • M src/heap/gc-tracer.cc
  • M src/heap/gc-tracer.h
  • M src/heap/heap.cc
  • M src/heap/incremental-marking.cc
  • M src/heap/mark-compact.cc
  • M src/heap/scavenger.cc
  • M src/heap/sweeper.cc
  • M test/cctest/heap/heap-utils.cc
  • M test/unittests/heap/cppgc-js/unified-heap-unittest.cc
  • M test/unittests/heap/heap-unittest.cc
  • M test/unittests/heap/heap-utils.cc
Change size: M
Delta: 16 files changed, 43 insertions(+), 85 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Michael Lippautz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I400aef02ace44d251415083edac74573e7940a3c
Gerrit-Change-Number: 7150844
Gerrit-PatchSet: 3
Gerrit-Owner: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages