[casting] Remove Foo::cast [v8/v8 : main]

0 views

Skip to first unread message

Leszek Swirski (Gerrit)

unread,

Jun 12, 2024, 7:50:07 AMJun 12

to V8 LUCI CQ, Fadi Meawad, Hannes Payer, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, lpy+v8...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com

Leszek Swirski voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Leszek Swirski (Gerrit)

unread,

Jun 12, 2024, 1:37:46 PMJun 12

to Michael Lippautz, V8 LUCI CQ, Fadi Meawad, Hannes Payer, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, lpy+v8...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com

Attention needed from Michael Lippautz

Leszek Swirski added 1 comment

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Leszek Swirski . resolved

One more mega CL (but notice the net 600 lines removed!)

Open in Gerrit

Related details

Attention is currently required from:

Michael Lippautz

Submit Requirements:

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Leszek Swirski (Gerrit)

unread,

Jun 12, 2024, 1:58:18 PMJun 12

Attention needed from Michael Lippautz

Leszek Swirski voted Auto-Submit+1

Auto-Submit

Open in Gerrit

Related details

Attention is currently required from:

Michael Lippautz

Submit Requirements:

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Michael Lippautz (Gerrit)

unread,

Jun 12, 2024, 2:48:41 PMJun 12

to Leszek Swirski, V8 LUCI CQ, Fadi Meawad, Hannes Payer, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, lpy+v8...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com

Attention needed from Leszek Swirski

Michael Lippautz voted and added 1 comment

Votes added by Michael Lippautz

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Michael Lippautz . resolved

lgtm, lets go

Open in Gerrit

Related details

Attention is currently required from:

Leszek Swirski

Submit Requirements:

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Leszek Swirski (Gerrit)

unread,

Jun 13, 2024, 6:02:19 AMJun 13

Attention needed from Michael Lippautz

Leszek Swirski voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Michael Lippautz

Submit Requirements:

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

V8 LUCI CQ (Gerrit)

unread,

Jun 13, 2024, 6:05:07 AMJun 13

to Leszek Swirski, Michael Lippautz, Fadi Meawad, Hannes Payer, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, lpy+v8...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com

V8 LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

13 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/wasm/module-instantiate.cc
Insertions: 6, Deletions: 7.

The diff is too large to show. Please review the diff.
```
```
The name of the file: src/heap/setup-heap-internal.cc
Insertions: 2, Deletions: 0.

The diff is too large to show. Please review the diff.
```
```
The name of the file: test/cctest/test-shared-strings.cc
Insertions: 8, Deletions: 8.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

[casting] Remove Foo::cast

Replace Foo::cast with Cast<Foo>. This is, blessedly, the same number of
characters, and allows us to remove the need to declare cast functions
in every type (instead using instance-type based type checks for most
things, and a few template specializations of CastTraits for the
remainder).

Bug: 345640551

Change-Id: Ic215e2d4519f3128457db8a828a73c18204714bd

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5614630

Reviewed-by: Michael Lippautz <mlip...@chromium.org>

Auto-Submit: Leszek Swirski <les...@chromium.org>

Commit-Queue: Leszek Swirski <les...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#94425}

Files:

M src/api/api-arguments-inl.h
M src/api/api-inl.h
M src/api/api-natives.cc
M src/api/api.cc
M src/asmjs/asm-js.cc
M src/ast/ast.cc
M src/baseline/baseline-batch-compiler.cc
M src/builtins/accessors.cc
M src/builtins/builtins-api.cc
M src/builtins/builtins-array.cc
M src/builtins/builtins-async-module.cc
M src/builtins/builtins-bigint.cc
M src/builtins/builtins-callsite.cc
M src/builtins/builtins-console.cc
M src/builtins/builtins-function.cc
M src/builtins/builtins-intl.cc
M src/builtins/builtins-object.cc
M src/builtins/builtins-shared-array.cc
M src/builtins/builtins-symbol.cc
M src/builtins/builtins-typed-array.cc
M src/builtins/builtins.cc
M src/builtins/constants-table-builder.cc
M src/builtins/setup-builtins-internal.cc
M src/codegen/arm/assembler-arm-inl.h
M src/codegen/arm64/assembler-arm64-inl.h
M src/codegen/code-stub-assembler.cc
M src/codegen/code-stub-assembler.h
M src/codegen/compilation-cache.cc
M src/codegen/compiler.cc
M src/codegen/external-reference.cc
M src/codegen/ia32/assembler-ia32-inl.h
M src/codegen/ia32/macro-assembler-ia32.cc
M src/codegen/loong64/assembler-loong64-inl.h
M src/codegen/mips64/assembler-mips64-inl.h
M src/codegen/pending-optimization-table.cc
M src/codegen/ppc/assembler-ppc-inl.h
M src/codegen/riscv/assembler-riscv-inl.h
M src/codegen/s390/assembler-s390-inl.h
M src/codegen/source-position.cc
M src/codegen/x64/assembler-x64-inl.h
M src/codegen/x64/macro-assembler-x64.cc
M src/compiler-dispatcher/lazy-compile-dispatcher.cc
M src/compiler/access-info.cc
M src/compiler/code-assembler.cc
M src/compiler/compilation-dependencies.cc
M src/compiler/graph-visualizer.cc
M src/compiler/heap-refs.cc
M src/compiler/js-call-reducer.cc
M src/compiler/js-heap-broker.cc
M src/compiler/pipeline.cc
M src/compiler/wasm-compiler.cc
M src/d8/d8.cc
M src/debug/debug-coverage.cc
M src/debug/debug-evaluate.cc
M src/debug/debug-interface.cc
M src/debug/debug-scopes.cc
M src/debug/debug-stack-trace-iterator.cc
M src/debug/debug-wasm-objects-inl.h
M src/debug/debug-wasm-objects.cc
M src/debug/debug-wasm-objects.h
M src/debug/debug.cc
M src/debug/liveedit.cc
M src/debug/wasm/gdb-server/wasm-module-debug.cc
M src/deoptimizer/deoptimizer.cc
M src/deoptimizer/translated-state.cc
M src/diagnostics/basic-block-profiler.cc
M src/diagnostics/etw-jit-win.cc
M src/diagnostics/gdb-jit.cc
M src/diagnostics/objects-debug.cc
M src/diagnostics/objects-printer.cc
M src/diagnostics/perf-jit.cc
M src/execution/arguments-inl.h
M src/execution/arm/simulator-arm.cc
M src/execution/arm64/simulator-arm64.cc
M src/execution/execution.cc
M src/execution/frames-inl.h
M src/execution/frames.cc
M src/execution/isolate-inl.h
M src/execution/isolate.cc
M src/execution/loong64/simulator-loong64.cc
M src/execution/messages.cc
M src/execution/microtask-queue.cc
M src/execution/mips64/simulator-mips64.cc
M src/execution/ppc/simulator-ppc.cc
M src/execution/protectors-inl.h
M src/execution/riscv/simulator-riscv.cc
M src/execution/s390/simulator-s390.cc
M src/extensions/statistics-extension.cc
M src/handles/global-handles-inl.h
M src/handles/global-handles.cc
M src/handles/global-handles.h
M src/handles/handles.cc
M src/heap/allocation-result.h
M src/heap/code-stats.cc
M src/heap/cppgc-js/cpp-snapshot.cc
M src/heap/cppgc-js/unified-heap-marking-state-inl.h
M src/heap/factory-base-inl.h
M src/heap/factory-base.cc
M src/heap/factory-inl.h
M src/heap/factory.cc
M src/heap/free-list.cc
M src/heap/heap-inl.h
M src/heap/heap-verifier.cc
M src/heap/heap-write-barrier-inl.h
M src/heap/heap-write-barrier.cc
M src/heap/heap.cc
M src/heap/incremental-marking-inl.h
M src/heap/local-factory-inl.h
M src/heap/mark-compact-inl.h
M src/heap/mark-compact.cc
M src/heap/mark-sweep-utilities.cc
M src/heap/marking-barrier.cc
M src/heap/marking-visitor-inl.h
M src/heap/memory-measurement.cc
M src/heap/minor-mark-sweep.cc
M src/heap/new-spaces-inl.h
M src/heap/new-spaces.cc
M src/heap/object-stats.cc
M src/heap/objects-visiting-inl.h
M src/heap/objects-visiting.cc
M src/heap/paged-spaces.cc
M src/heap/pretenuring-handler-inl.h
M src/heap/pretenuring-handler.cc
M src/heap/read-only-promotion.cc
M src/heap/remembered-set-inl.h
M src/heap/remembered-set.h
M src/heap/scavenger-inl.h
M src/heap/scavenger.cc
M src/heap/setup-heap-internal.cc
M src/heap/traced-handles-marking-visitor.cc
M src/heap/young-generation-marking-visitor-inl.h
M src/ic/call-optimization.cc
M src/ic/handler-configuration-inl.h
M src/ic/handler-configuration.cc
M src/ic/handler-configuration.h
M src/ic/ic-inl.h
M src/ic/ic-stats.cc
M src/ic/ic.cc
M src/ic/stub-cache.cc
M src/init/bootstrapper.cc
M src/interpreter/bytecode-array-iterator.cc
M src/interpreter/interpreter.cc
M src/json/json-parser.cc
M src/json/json-stringifier.cc
M src/logging/log-file.cc
M src/logging/log.cc
M src/maglev/maglev-code-generator.cc
M src/maglev/maglev-graph-builder.cc
M src/maglev/maglev-graph-printer.cc
M src/numbers/conversions-inl.h
M src/numbers/math-random.cc
M src/objects/abstract-code-inl.h
M src/objects/abstract-code.h
M src/objects/allocation-site-inl.h
M src/objects/allocation-site-scopes-inl.h
M src/objects/allocation-site.h
M src/objects/arguments-inl.h
M src/objects/arguments.h
M src/objects/backing-store.cc
M src/objects/bigint-inl.h
M src/objects/bigint.cc
M src/objects/bigint.h
M src/objects/bytecode-array-inl.h
M src/objects/bytecode-array.h
M src/objects/call-site-info-inl.h
M src/objects/call-site-info.cc
M src/objects/casting.h
M src/objects/code-inl.h
M src/objects/code.cc
M src/objects/code.h
M src/objects/compilation-cache-table-inl.h
M src/objects/compilation-cache-table.cc
M src/objects/compilation-cache-table.h
M src/objects/compressed-slots-inl.h
M src/objects/contexts-inl.h
M src/objects/contexts.cc
M src/objects/contexts.h
M src/objects/debug-objects-inl.h
M src/objects/debug-objects.cc
M src/objects/deoptimization-data-inl.h
M src/objects/deoptimization-data.cc
M src/objects/deoptimization-data.h
M src/objects/dependent-code-inl.h
M src/objects/dependent-code.cc
M src/objects/dependent-code.h
M src/objects/descriptor-array-inl.h
M src/objects/dictionary-inl.h
M src/objects/dictionary.h
M src/objects/elements.cc
M src/objects/embedder-data-slot-inl.h
M src/objects/feedback-cell-inl.h
M src/objects/feedback-vector-inl.h
M src/objects/feedback-vector.cc
M src/objects/feedback-vector.h
M src/objects/field-type.cc
M src/objects/field-type.h
M src/objects/fixed-array-inl.h
M src/objects/fixed-array.h
M src/objects/free-space-inl.h
M src/objects/free-space.h
M src/objects/hash-table-inl.h
M src/objects/hash-table.h
M src/objects/heap-number-inl.h
M src/objects/heap-number.h
M src/objects/heap-object.h
M src/objects/hole-inl.h
M src/objects/hole.h
M src/objects/instruction-stream-inl.h
M src/objects/instruction-stream.cc
M src/objects/instruction-stream.h
M src/objects/intl-objects.cc
M src/objects/js-array-buffer-inl.h
M src/objects/js-array-buffer.cc
M src/objects/js-array-inl.h
M src/objects/js-array.h
M src/objects/js-atomics-synchronization-inl.h
M src/objects/js-atomics-synchronization.h
M src/objects/js-collection-inl.h
M src/objects/js-collection.h
M src/objects/js-date-time-format.cc
M src/objects/js-disposable-stack-inl.h
M src/objects/js-disposable-stack.cc
M src/objects/js-disposable-stack.h
M src/objects/js-function-inl.h
M src/objects/js-function.cc
M src/objects/js-iterator-helpers-inl.h
M src/objects/js-iterator-helpers.h
M src/objects/js-number-format.cc
M src/objects/js-objects-inl.h
M src/objects/js-objects.cc
M src/objects/js-objects.h
M src/objects/js-regexp-inl.h
M src/objects/js-regexp.cc
M src/objects/js-segment-iterator-inl.h
M src/objects/js-segment-iterator.cc
M src/objects/js-segment-iterator.h
M src/objects/js-segments.cc
M src/objects/js-shared-array-inl.h
M src/objects/js-shared-array.h
M src/objects/js-struct-inl.h
M src/objects/js-struct.cc
M src/objects/js-struct.h
M src/objects/js-temporal-objects.cc
M src/objects/js-weak-refs-inl.h
M src/objects/keys.cc
M src/objects/literal-objects-inl.h
M src/objects/literal-objects.cc
M src/objects/literal-objects.h
M src/objects/lookup-inl.h
M src/objects/lookup.cc
M src/objects/managed.h
M src/objects/map-inl.h
M src/objects/map-updater.cc
M src/objects/map.cc
M src/objects/map.h
M src/objects/module-inl.h
M src/objects/module.cc
M src/objects/name-inl.h
M src/objects/name.h
M src/objects/object-macros-undef.h
M src/objects/object-macros.h
M src/objects/object-type.cc
M src/objects/objects-body-descriptors-inl.h
M src/objects/objects-inl.h
M src/objects/objects.cc
M src/objects/objects.h
M src/objects/oddball-inl.h
M src/objects/oddball.h
M src/objects/ordered-hash-table-inl.h
M src/objects/ordered-hash-table.cc
M src/objects/ordered-hash-table.h
M src/objects/primitive-heap-object-inl.h
M src/objects/primitive-heap-object.h
M src/objects/property-cell-inl.h
M src/objects/property-descriptor.cc
M src/objects/prototype-inl.h
M src/objects/prototype.h
M src/objects/regexp-match-info-inl.h
M src/objects/regexp-match-info.h
M src/objects/scope-info-inl.h
M src/objects/scope-info.cc
M src/objects/script-inl.h
M src/objects/shared-function-info-inl.h
M src/objects/shared-function-info.cc
M src/objects/shared-function-info.h
M src/objects/simd.cc
M src/objects/slots-inl.h
M src/objects/smi.h
M src/objects/source-text-module.cc
M src/objects/source-text-module.h
M src/objects/string-forwarding-table-inl.h
M src/objects/string-forwarding-table.cc
M src/objects/string-inl.h
M src/objects/string-set-inl.h
M src/objects/string-set.h
M src/objects/string-table.cc
M src/objects/string.cc
M src/objects/string.h
M src/objects/swiss-name-dictionary-inl.h
M src/objects/swiss-name-dictionary.cc
M src/objects/swiss-name-dictionary.h
M src/objects/synthetic-module.cc
M src/objects/tagged-impl-inl.h
M src/objects/tagged-impl.cc
M src/objects/tagged-impl.h
M src/objects/tagged-index.h
M src/objects/tagged.h
M src/objects/template-objects.cc
M src/objects/templates-inl.h
M src/objects/templates.cc
M src/objects/transitions-inl.h
M src/objects/transitions.cc
M src/objects/transitions.h
M src/objects/trusted-object-inl.h
M src/objects/trusted-object.h
M src/objects/value-serializer.cc
M src/objects/visitors-inl.h
M src/objects/visitors.h
M src/parsing/parse-info.cc
M src/parsing/parser.cc
M src/parsing/parsing.cc
M src/parsing/scanner-character-streams.cc
M src/profiler/allocation-tracker.cc
M src/profiler/heap-profiler.cc
M src/profiler/heap-snapshot-generator.cc
M src/profiler/profile-generator.cc
M src/profiler/profiler-listener.cc
M src/profiler/sampling-heap-profiler.cc
M src/profiler/strings-storage.cc
M src/profiler/tick-sample.cc
M src/regexp/arm/regexp-macro-assembler-arm.cc
M src/regexp/arm64/regexp-macro-assembler-arm64.cc
M src/regexp/experimental/experimental.cc
M src/regexp/ia32/regexp-macro-assembler-ia32.cc
M src/regexp/loong64/regexp-macro-assembler-loong64.cc
M src/regexp/mips64/regexp-macro-assembler-mips64.cc
M src/regexp/ppc/regexp-macro-assembler-ppc.cc
M src/regexp/regexp-interpreter.cc
M src/regexp/regexp-macro-assembler.cc
M src/regexp/regexp-utils.cc
M src/regexp/regexp.cc
M src/regexp/riscv/regexp-macro-assembler-riscv.cc
M src/regexp/s390/regexp-macro-assembler-s390.cc
M src/regexp/x64/regexp-macro-assembler-x64.cc
M src/roots/roots-inl.h
M src/roots/roots.cc
M src/runtime/runtime-array.cc
M src/runtime/runtime-classes.cc
M src/runtime/runtime-collections.cc
M src/runtime/runtime-compiler.cc
M src/runtime/runtime-debug.cc
M src/runtime/runtime-function.cc
M src/runtime/runtime-futex.cc
M src/runtime/runtime-generator.cc
M src/runtime/runtime-literals.cc
M src/runtime/runtime-module.cc
M src/runtime/runtime-object.cc
M src/runtime/runtime-proxy.cc
M src/runtime/runtime-regexp.cc
M src/runtime/runtime-scopes.cc
M src/runtime/runtime-strings.cc
M src/runtime/runtime-symbol.cc
M src/runtime/runtime-test-wasm.cc
M src/runtime/runtime-test.cc
M src/runtime/runtime-trace.cc
M src/runtime/runtime-typedarray.cc
M src/runtime/runtime-wasm.cc
M src/runtime/runtime-weak-refs.cc
M src/sandbox/indirect-pointer-tag.h
M src/sandbox/testing.cc
M src/snapshot/code-serializer.cc
M src/snapshot/context-serializer.cc
M src/snapshot/deserializer.cc
M src/snapshot/read-only-deserializer.cc
M src/snapshot/read-only-serializer.cc
M src/snapshot/serializer-deserializer.cc
M src/snapshot/serializer.cc
M src/snapshot/shared-heap-serializer.cc
M src/snapshot/snapshot.cc
M src/snapshot/startup-serializer.cc
M src/strings/string-builder-inl.h
M src/strings/string-builder.cc
M src/strings/string-stream.cc
M src/torque/cc-generator.cc
M src/torque/implementation-visitor.cc
M src/tracing/code-data-source.cc
M src/tracing/perfetto-logger.cc
M src/utils/address-map.cc
M src/wasm/c-api.cc
M src/wasm/constant-expression-interface.cc
M src/wasm/module-compiler.cc
M src/wasm/module-instantiate.cc
M src/wasm/wasm-code-manager.cc
M src/wasm/wasm-debug.cc
M src/wasm/wasm-engine.cc
M src/wasm/wasm-external-refs.cc
M src/wasm/wasm-js.cc
M src/wasm/wasm-objects-inl.h
M src/wasm/wasm-objects.cc
M src/wasm/wasm-objects.h
M test/cctest/compiler/test-code-generator.cc
M test/cctest/compiler/test-concurrent-shared-function-info.cc
M test/cctest/compiler/test-js-context-specialization.cc
M test/cctest/heap/test-alloc.cc
M test/cctest/heap/test-array-buffer-tracker.cc
M test/cctest/heap/test-compaction.cc
M test/cctest/heap/test-concurrent-allocation.cc
M test/cctest/heap/test-heap.cc
M test/cctest/heap/test-mark-compact.cc
M test/cctest/heap/test-spaces.cc
M test/cctest/heap/test-weak-references.cc
M test/cctest/heap/test-write-barrier.cc
M test/cctest/test-accessor-assembler.cc
M test/cctest/test-api-interceptors.cc
M test/cctest/test-api.cc
M test/cctest/test-assembler-ppc.cc
M test/cctest/test-code-stub-assembler.cc
M test/cctest/test-cpu-profiler.cc
M test/cctest/test-debug-helper.cc
M test/cctest/test-debug.cc
M test/cctest/test-field-type-tracking.cc
M test/cctest/test-func-name-inference.cc
M test/cctest/test-heap-profiler.cc
M test/cctest/test-inobject-slack-tracking.cc
M test/cctest/test-js-weak-refs.cc
M test/cctest/test-liveedit.cc
M test/cctest/test-log-stack-tracer.cc
M test/cctest/test-mementos.cc
M test/cctest/test-regexp.cc
M test/cctest/test-serialize.cc
M test/cctest/test-shared-strings.cc
M test/cctest/test-strings.cc
M test/cctest/torque/test-torque.cc
M test/cctest/wasm/test-gc.cc
M test/cctest/wasm/test-run-wasm-bulk-memory.cc
M test/cctest/wasm/test-run-wasm-wrappers.cc
M test/cctest/wasm/test-streaming-compilation.cc
M test/cctest/wasm/test-wasm-serialization.cc
M test/cctest/wasm/test-wasm-stack.cc
M test/cctest/wasm/test-wasm-trap-position.cc
M test/cctest/wasm/wasm-run-utils.cc
M test/cctest/wasm/wasm-run-utils.h
M test/common/wasm/wasm-module-runner.cc
M test/fuzzer/wasm-init-expr.cc
M test/mjsunit/es6/proxies-has.js
M test/mkgrokdump/mkgrokdump.cc
M test/unittests/api/deserialize-unittest.cc
M test/unittests/compiler/codegen-unittest.cc
M test/unittests/compiler/compiler-unittest.cc
M test/unittests/compiler/run-bytecode-graph-builder-unittest.cc
M test/unittests/compiler/run-jsobjects-unittest.cc
M test/unittests/compiler/run-tail-calls-unittest.cc
M test/unittests/heap/cppgc-js/traced-reference-unittest.cc
M test/unittests/heap/cppgc-js/unified-heap-unittest.cc
M test/unittests/heap/cppgc-js/unified-heap-utils.cc
M test/unittests/heap/inner-pointer-resolution-unittest.cc
M test/unittests/heap/local-handles-unittest.cc
M test/unittests/heap/marking-worklist-unittest.cc
M test/unittests/heap/shared-heap-unittest.cc
M test/unittests/interpreter/bytecode-expectations-printer.cc
M test/unittests/interpreter/constant-array-builder-unittest.cc
M test/unittests/interpreter/interpreter-unittest.cc
M test/unittests/logging/log-unittest.cc
M test/unittests/maglev/node-type-unittest.cc
M test/unittests/objects/concurrent-js-array-unittest.cc
M test/unittests/objects/intl-unittest.cc
M test/unittests/objects/object-unittest.cc
M test/unittests/objects/roots-unittest.cc
M test/unittests/objects/weakmaps-unittest.cc
M test/unittests/objects/weaksets-unittest.cc
M test/unittests/parser/parse-decision-unittest.cc
M test/unittests/parser/parsing-unittest.cc
M test/unittests/regexp/regexp-unittest.cc
M test/unittests/runtime/runtime-debug-unittest.cc
M test/unittests/tasks/background-compile-task-unittest.cc
M test/unittests/test-helpers.cc
M tools/gcmole/gcmole-test.cc
M tools/gcmole/gcmole.cc
M tools/gcmole/test-expectations.txt

Change size: XL

Delta: 479 files changed, 3926 insertions(+), 4519 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Michael Lippautz

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages