[cleanup] Clean up includes [chromium/src : main]

0 views
Skip to first unread message

Andreas Haas (Gerrit)

unread,
Aug 5, 2025, 7:46:24 AMAug 5
to Kentaro Hara, Chromium LUCI CQ, AyeAye, blink-re...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, blink-...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Kentaro Hara

Andreas Haas added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Andreas Haas . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Kentaro Hara
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id96bec4466ac3e7fe91b57b7c687a62a33304fc2
Gerrit-Change-Number: 6818943
Gerrit-PatchSet: 1
Gerrit-Owner: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Kentaro Hara <har...@chromium.org>
Gerrit-Comment-Date: Tue, 05 Aug 2025 11:46:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kentaro Hara (Gerrit)

unread,
Aug 5, 2025, 7:57:41 AMAug 5
to Andreas Haas, Chromium LUCI CQ, AyeAye, blink-re...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, blink-...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Andreas Haas

Kentaro Hara voted and added 1 comment

Votes added by Kentaro Hara

Code-Review+1

1 comment

Patchset-level comments
Kentaro Hara . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Andreas Haas
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id96bec4466ac3e7fe91b57b7c687a62a33304fc2
Gerrit-Change-Number: 6818943
Gerrit-PatchSet: 1
Gerrit-Owner: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Andreas Haas <ah...@chromium.org>
Gerrit-Comment-Date: Tue, 05 Aug 2025 11:57:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Andreas Haas (Gerrit)

unread,
Aug 5, 2025, 8:00:13 AMAug 5
to Kentaro Hara, Chromium LUCI CQ, AyeAye, blink-re...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, blink-...@chromium.org, oilpan-rev...@chromium.org

Andreas Haas voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id96bec4466ac3e7fe91b57b7c687a62a33304fc2
Gerrit-Change-Number: 6818943
Gerrit-PatchSet: 1
Gerrit-Owner: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Comment-Date: Tue, 05 Aug 2025 12:00:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Aug 5, 2025, 8:03:28 AMAug 5
to Andreas Haas, Kentaro Hara, AyeAye, blink-re...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, blink-...@chromium.org, oilpan-rev...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[cleanup] Clean up includes

The include in persistent.h was not needed in persistent.h itself, but only in files that included persistent.h. This CL moves down the includes.
Change-Id: Id96bec4466ac3e7fe91b57b7c687a62a33304fc2
Reviewed-by: Kentaro Hara <har...@chromium.org>
Commit-Queue: Andreas Haas <ah...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1496853}
Files:
  • M third_party/blink/renderer/platform/heap/cross_thread_persistent.h
  • M third_party/blink/renderer/platform/heap/persistent.h
  • M third_party/blink/renderer/platform/wtf/hash_functions.h
Change size: XS
Delta: 3 files changed, 2 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kentaro Hara
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id96bec4466ac3e7fe91b57b7c687a62a33304fc2
Gerrit-Change-Number: 6818943
Gerrit-PatchSet: 2
Gerrit-Owner: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages