Revert "[heap] Refactor new space containment calls" [v8/v8 : main]
0 views
Skip to first unread message
Michael Lippautz (Gerrit)
Aug 26, 2025, 2:36:11 AMAug 26
to Rubber Stamper, Dominik Inführ, V8 LUCI CQ, Hannes Payer, AyeAye, oilpan-r...@chromium.org, mlippau...@chromium.org
Attention needed from Dominik Inführ
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Aug 26, 2025, 2:37:07 AMAug 26
to Michael Lippautz, Dominik Inführ, V8 LUCI CQ, Hannes Payer, AyeAye, oilpan-r...@chromium.org, mlippau...@chromium.org
Attention needed from Dominik Inführ
Rubber Stamper voted![]( "Open in Gerrit")
| Bot-Commit | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Aug 26, 2025, 2:37:14 AMAug 26
to Michael Lippautz, Rubber Stamper, Dominik Inführ, Hannes Payer, AyeAye, oilpan-r...@chromium.org, mlippau...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "[heap] Refactor new space containment calls"
This reverts commit e42ce24ddcf5075586e5c1f2c56677245658bb43.
Reason for revert: Missing nullptr check for Heap. Revert unblocks V8 roll.
Bug: 429538831
Original change's description:
> [heap] Refactor new space containment calls
>
> Relay them to MemoryChunkMetadata::owner() instead of using the chunk
> flags. The calls are not as hot and this way is consistent with
> PagedSpace.
>
> Bug: 429538831
> Change-Id: I2fb533ca5f2490312cefb7a17c576b539a8fd7e3
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6879446
> Reviewed-by: Dominik Inführ <dinf...@chromium.org>
> Commit-Queue: Michael Lippautz <mlip...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#102022}
Bug: 429538831
Fixed: 441134575
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I28aa6d3bd9bfde72f4a4a57a1a68e090dd9937c3
Auto-Submit: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#102031}
Files:
- M src/heap/cppgc-js/unified-heap-marking-visitor.cc
- M src/heap/cppgc-js/unified-heap-marking-visitor.h
- M src/heap/new-spaces-inl.h
- M src/heap/new-spaces.cc
- M src/heap/new-spaces.h
Change size: M
Delta: 5 files changed, 50 insertions(+), 26 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages