Convert to UNSAFE_TODO in third_party/blink [chromium/src : main]

0 views

Skip to first unread message

Arthur Sonzogni (Gerrit)

unread,

Nov 7, 2025, 12:10:47 PM (3 days ago) Nov 7

to Stephen Chenney, Hirokazu Honda, chromium...@chromium.org, Hongchan Choi, Kentaro Hara, Dirk Schulze, kinuko...@chromium.org, video-networking...@google.com, mac-r...@chromium.org, drott+bl...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, ipc-securi...@chromium.org, blink-reviews-p...@chromium.org

Arthur Sonzogni has uploaded the change for review

Commit message

Convert to UNSAFE_TODO in third_party/blink

This is an automated #cleanup patch using the [Script] below.

We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations, allowing
the rest of the file to be enforced as safe.

This CL was uploaded by git cl split.

Script: https://docs.google.com/document/d/1ORQGBNn2R-CEvNbDTjRd-GrOBOFlCxIHdcvSUA_EhR4/edit?usp=sharing

AX-Relnotes: N/A

Cleanup: This is an automated #cleanup.

Bug: 409340989

Change-Id: I288f6783738c71a3c0ca9aede185394a8db73ed3

Change diff

Change information

Files:

M third_party/blink/public/common/input/web_gesture_event.h
M third_party/blink/renderer/modules/webaudio/cpu/arm/oscillator_kernel_neon.cc
M third_party/blink/renderer/modules/webaudio/oscillator_handler.cc
M third_party/blink/renderer/modules/webaudio/periodic_wave.cc
M third_party/blink/renderer/platform/audio/biquad.cc
M third_party/blink/renderer/platform/audio/cpu/arm/delay_neon.cc
M third_party/blink/renderer/platform/audio/cpu/arm/vector_math_neon.h
M third_party/blink/renderer/platform/audio/cpu/x86/vector_math_impl.h
M third_party/blink/renderer/platform/audio/cpu/x86/vector_math_x86.h
M third_party/blink/renderer/platform/audio/sinc_resampler.cc
M third_party/blink/renderer/platform/audio/vector_math_scalar.h
M third_party/blink/renderer/platform/graphics/cpu/arm/webgl_image_conversion_neon.h
M third_party/blink/renderer/platform/graphics/cpu/x86/webgl_image_conversion_sse.h
M third_party/blink/renderer/platform/graphics/gpu/webgl_image_conversion.cc
M third_party/blink/renderer/platform/graphics/test/mock_embedded_frame_sink_provider.h
M third_party/blink/renderer/platform/heap/collection_support/heap_hash_table_backing.h
M third_party/blink/renderer/platform/heap/collection_support/heap_vector_backing.h
M third_party/blink/renderer/platform/heap/test/concurrent_marking_test.cc
M third_party/blink/renderer/platform/mac/color_mac.mm
M third_party/blink/renderer/platform/mojo/string16_mojom_traits.h
M third_party/blink/renderer/platform/peerconnection/h265_parameter_sets_tracker.cc
M third_party/blink/renderer/platform/peerconnection/rtc_video_encoder_test.cc

Change size: XL

Delta: 22 files changed, 1438 insertions(+), 1351 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Arthur Sonzogni (Gerrit)

unread,

Nov 8, 2025, 2:39:50 AM (3 days ago) Nov 8

to chromium...@chromium.org, Dirk Schulze, Kentaro Hara, Hirokazu Honda, Hongchan Choi, Stephen Chenney, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, mac-r...@chromium.org, oilpan-rev...@chromium.org, video-networking...@google.com

Arthur Sonzogni voted Commit-Queue+1

Commit-Queue