[heap] Refactor new space containment calls [v8/v8 : main]
0 views
Skip to first unread message
Michael Lippautz (Gerrit)
Aug 25, 2025, 10:52:17 AMAug 25
to AyeAye, Dominik Inführ, V8 LUCI CQ, Hannes Payer, oilpan-r...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Michael Lippautz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Michael Lippautz . resolved
This is also fixed now, please take another look.
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Aug 25, 2025, 11:59:14 AMAug 25
to Michael Lippautz, AyeAye, V8 LUCI CQ, Hannes Payer, oilpan-r...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Aug 25, 2025, 11:59:54 AMAug 25
to Dominik Inführ, AyeAye, V8 LUCI CQ, Hannes Payer, oilpan-r...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Aug 25, 2025, 12:01:26 PMAug 25
to Michael Lippautz, Dominik Inführ, AyeAye, Hannes Payer, oilpan-r...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[heap] Refactor new space containment calls
Relay them to MemoryChunkMetadata::owner() instead of using the chunk
flags. The calls are not as hot and this way is consistent with
PagedSpace.
Bug: 429538831
Change-Id: I2fb533ca5f2490312cefb7a17c576b539a8fd7e3
Reviewed-by: Dominik Inführ <dinf...@chromium.org>
Commit-Queue: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102022}
Files:
- M src/heap/cppgc-js/unified-heap-marking-visitor.cc
- M src/heap/cppgc-js/unified-heap-marking-visitor.h
- M src/heap/new-spaces-inl.h
- M src/heap/new-spaces.cc
- M src/heap/new-spaces.h
Change size: M
Delta: 5 files changed, 26 insertions(+), 50 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dominik Inführ
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Aug 26, 2025, 2:36:11 AMAug 26
to V8 LUCI CQ, Dominik Inführ, AyeAye, Hannes Payer, oilpan-r...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com
Michael Lippautz has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages