Revert "[Heap] Unify allocation retry loops" [v8/v8 : main]
0 views
Skip to first unread message
Benoit Lize (Gerrit)
Oct 9, 2025, 7:55:32 AM (12 days ago) Oct 9
to Dominik Inführ, Andreas Haas, AyeAye, Rubber Stamper, V8 LUCI CQ, Etienne Pierre-Doray, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org
Attention needed from Andreas Haas, Benoit Lize, Dominik Inführ and Etienne Pierre-Doray
Message from Benoit Lize![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention is currently required from:
- Andreas Haas
- Benoit Lize
- Dominik Inführ
- Etienne Pierre-Doray
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Oct 9, 2025, 7:55:38 AM (12 days ago) Oct 9
to Benoit Lize, Dominik Inführ, Andreas Haas, AyeAye, Rubber Stamper, Etienne Pierre-Doray, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Revert "[Heap] Unify allocation retry loops"
This reverts commit 8ad091e5727571d635aca4ce37cf134ca235140c.
Reason for revert: WebView breakage, see crbug.com/450477451
Original change's description:
> [Heap] Unify allocation retry loops
>
> This CL reuses HeapAllocator retry loop in several places, including
> oilpan. This ensure they are all aligned under 1 implementation.
> Follow-up: this should also be exposed on v8-isolate so that it can be used here: https://chromium-review.googlesource.com/c/chromium/src/+/6164814
>
> Bug: 448848875
> Change-Id: I646f05b052fa70cae151c1c5ba019f3e9aa5aa37
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7011414
> Reviewed-by: Dominik Inführ <dinf...@chromium.org>
> Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#102997}
Bug: 448848875, chromium:450477451
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 448848875
Change-Id: Icb3ea2feef03e8f53572a3c9fd699d018dbf469b
Reviewed-by: Dominik Inführ <dinf...@chromium.org>
Reviewed-by: Andreas Haas <ah...@chromium.org>
Commit-Queue: Benoit Lize <li...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103027}
Files:
- M src/heap/cppgc-js/cpp-heap.cc
- M src/heap/cppgc-js/cpp-heap.h
- M src/heap/cppgc/garbage-collector.h
- M src/heap/cppgc/gc-invoker.cc
- M src/heap/cppgc/gc-invoker.h
- M src/heap/cppgc/heap.cc
- M src/heap/cppgc/heap.h
- M src/heap/cppgc/object-allocator.cc
- M src/heap/factory-base.cc
- M src/heap/heap-allocator-inl.h
- M src/heap/heap-allocator.cc
- M src/heap/heap-allocator.h
- M src/heap/heap.cc
- M test/unittests/heap/cppgc/gc-invoker-unittest.cc
- M test/unittests/heap/cppgc/heap-growing-unittest.cc
Change size: L
Delta: 15 files changed, 144 insertions(+), 150 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andreas Haas, +1 by Dominik Inführ
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benoit Lize (Gerrit)
Oct 9, 2025, 7:55:42 AM (12 days ago) Oct 9
to Dominik Inführ, Andreas Haas, AyeAye, Rubber Stamper, V8 LUCI CQ, Etienne Pierre-Doray, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org
Attention needed from Andreas Haas, Dominik Inführ and Etienne Pierre-Doray
Benoit Lize voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Andreas Haas
- Dominik Inführ
- Etienne Pierre-Doray
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages