DONOTCOMMIT lifetimebound [v8/v8 : main]

0 views

Skip to first unread message

Utkarsh Saxena (Gerrit)

unread,

Feb 6, 2026, 9:56:47 AM (yesterday) Feb 6

to Maksim Ivanov, V8 LUCI CQ, Hannes Payer, cbruni...@chromium.org, devtools-...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com

Attention needed from Maksim Ivanov

Utkarsh Saxena added 2 comments

File src/compiler/functional-list.h

Line 122, Patchset 9 (Latest): iterator begin() const [[clang::lifetimebound]] {

Utkarsh Saxena . unresolved

These look like a bug if they are suggested by the analysis.

Hopefully this is also manual. FunctionalList should be an owning type in this case, right ?

Line 103, Patchset 9 (Latest): class [[gsl::Pointer]] iterator

Utkarsh Saxena . unresolved

Is this done manually ?
(I believe so, just wanted to confirm)

Open in Gerrit

Related details

Attention is currently required from:

Maksim Ivanov

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Maksim Ivanov (Gerrit)

unread,

Feb 6, 2026, 10:01:04 AM (yesterday) Feb 6

to Utkarsh Saxena, V8 LUCI CQ, Hannes Payer, cbruni...@chromium.org, devtools-...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com

Attention needed from Utkarsh Saxena

Maksim Ivanov added 2 comments

File src/compiler/functional-list.h

Line 122, Patchset 9 (Latest): iterator begin() const [[clang::lifetimebound]] {

Utkarsh Saxena . unresolved

These look like a bug if they are suggested by the analysis.
Hopefully this is also manual. FunctionalList should be an owning type in this case, right ?

Maksim Ivanov

I suppose so, added by an overly ambitious Gemini take.

Line 103, Patchset 9 (Latest): class [[gsl::Pointer]] iterator

Utkarsh Saxena . unresolved

Is this done manually ?
(I believe so, just wanted to confirm)

Maksim Ivanov

I believe so. Generally, my goal here was not be 100% correctness but rather getting an upper boundary of the number of possible annotations and suspicious code findings.

Open in Gerrit

Related details

Attention is currently required from:

Utkarsh Saxena

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages