DONOTCOMMIT lifetimebound [v8/v8 : main]
Utkarsh Saxena (Gerrit)
Utkarsh Saxena added 2 comments![]( "Open in Gerrit")
iterator begin() const [[clang::lifetimebound]] {These look like a bug if they are suggested by the analysis.
Hopefully this is also manual. FunctionalList should be an owning type in this case, right ?
class [[gsl::Pointer]] iteratorIs this done manually ?
(I believe so, just wanted to confirm)
Related details
- Maksim Ivanov
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Ivanov (Gerrit)
Maksim Ivanov added 2 comments![]( "Open in Gerrit")
iterator begin() const [[clang::lifetimebound]] {These look like a bug if they are suggested by the analysis.
Hopefully this is also manual. FunctionalList should be an owning type in this case, right ?
I suppose so, added by an overly ambitious Gemini take.
class [[gsl::Pointer]] iteratorIs this done manually ?
(I believe so, just wanted to confirm)
I believe so. Generally, my goal here was not be 100% correctness but rather getting an upper boundary of the number of possible annotations and suspicious code findings.
Related details
- Utkarsh Saxena
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Ivanov (Gerrit)
Maksim Ivanov added 1 comment![]( "Open in Gerrit")
class [[gsl::Pointer]] iteratorMaksim IvanovIs this done manually ?
(I believe so, just wanted to confirm)
I believe so. Generally, my goal here was not be 100% correctness but rather getting an upper boundary of the number of possible annotations and suspicious code findings.
In case you wanted to see "clean" suggestions by Clang without manual/LLM changes, I've generated another patch: https://chromium-review.googlesource.com/c/v8/v8/+/7556410
Related details
- Utkarsh Saxena
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |