Clemens Backes (Gerrit)

unread,

Dec 17, 2025, 9:19:17 AM (11 days ago) Dec 17

to V8 LUCI CQ, Leszek Swirski, devtools-...@chromium.org, dmercadi...@chromium.org, leszek...@chromium.org, marja...@chromium.org, oilpan-r...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com

Attention needed from Leszek Swirski

Clemens Backes voted and added 1 comment

Votes added by Clemens Backes

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Clemens Backes . resolved

A little cleanup; PTAL.

Open in Gerrit

Related details

Attention is currently required from:

Leszek Swirski

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Leszek Swirski (Gerrit)

unread,

Dec 17, 2025, 10:22:12 AM (11 days ago) Dec 17

to Clemens Backes, V8 LUCI CQ, devtools-...@chromium.org, dmercadi...@chromium.org, leszek...@chromium.org, marja...@chromium.org, oilpan-r...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com

Attention needed from Clemens Backes

Leszek Swirski voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Clemens Backes

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Clemens Backes (Gerrit)

unread,

Dec 17, 2025, 10:23:11 AM (11 days ago) Dec 17

to Leszek Swirski, V8 LUCI CQ, devtools-...@chromium.org, dmercadi...@chromium.org, leszek...@chromium.org, marja...@chromium.org, oilpan-r...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com

Clemens Backes voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

V8 LUCI CQ (Gerrit)

unread,

Dec 17, 2025, 10:27:17 AM (11 days ago) Dec 17

to Clemens Backes, Leszek Swirski, devtools-...@chromium.org, dmercadi...@chromium.org, leszek...@chromium.org, marja...@chromium.org, oilpan-r...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com

V8 LUCI CQ submitted the change

Change information

Commit message:

[cleanup] Use `base::Reversed` for reversed iteration

Gemini prompt:
> Find iterations using `std::rbegin` and `std::rend` across the code
  base (`ag 'for.*rbegin.*rend'`). Replace them by range-based iteration
  via `base::Reversed`.

Follow-up:
> Look at all changes (`git diff HEAD`). Find loops that should use
  references to avoid copying, and find loops that could use structured
  binding. Fix both.

R=les...@chromium.org

Change-Id: If2ade024269e31dff94e2fe1916b30f125a25488

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7269587

Reviewed-by: Leszek Swirski <les...@chromium.org>

Commit-Queue: Clemens Backes <clem...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#104374}

Files:

M src/asmjs/asm-parser.cc
M src/builtins/arm/builtins-arm.cc
M src/builtins/ia32/builtins-ia32.cc
M src/builtins/loong64/builtins-loong64.cc
M src/builtins/ppc/builtins-ppc.cc
M src/builtins/riscv/builtins-riscv.cc
M src/builtins/s390/builtins-s390.cc
M src/builtins/x64/builtins-x64.cc
M src/codegen/code-stub-assembler.cc
M src/compiler/backend/instruction-selector.cc
M src/compiler/simplified-lowering.cc
M src/compiler/turboshaft/assembler.h
M src/compiler/turboshaft/branch-elimination-reducer.h
M src/compiler/turboshaft/wasm-shuffle-reducer.cc
M src/debug/debug-evaluate.cc
M src/execution/isolate.cc
M src/maglev/arm/maglev-assembler-arm-inl.h
M src/maglev/loong64/maglev-assembler-loong64-inl.h
M src/maglev/ppc/maglev-assembler-ppc-inl.h
M src/maglev/riscv/maglev-assembler-riscv-inl.h
M src/maglev/s390/maglev-assembler-s390-inl.h
M src/maglev/x64/maglev-assembler-x64-inl.h
M src/parsing/scanner-character-streams.cc
M src/profiler/profile-generator.cc
M src/profiler/sampling-heap-profiler.cc
M src/runtime/runtime-test.cc
M src/torque/cc-generator.cc
M src/torque/csa-generator.cc
M src/torque/earley-parser.cc
M src/torque/utils.cc
M src/wasm/fuzzing/random-module-generation.cc
M test/cctest/collector.h
M test/cctest/heap/heap-utils.cc
M test/unittests/heap/cppgc/free-list-unittest.cc
M test/unittests/heap/heap-utils.cc
M test/unittests/heap/page-promotion-unittest.cc
M test/unittests/zone/zone-chunk-list-unittest.cc

Change size: M

Delta: 37 files changed, 134 insertions(+), 112 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Leszek Swirski

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[cleanup] Use `base::Reversed` for reversed iteration [v8/v8 : main]

Clemens Backes (Gerrit)

Clemens Backes voted and added 1 comment

Votes added by Clemens Backes

1 comment

Related details

Leszek Swirski (Gerrit)

Leszek Swirski voted Code-Review+1

Related details

Clemens Backes (Gerrit)

Clemens Backes voted Commit-Queue+2

Related details

V8 LUCI CQ (Gerrit)

V8 LUCI CQ submitted the change

Change information