Add -Wshorten-64-to-32 and -Wtautological-unsigned-zero-compare to `inside_blink` config [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Jul 8, 2026, 5:54:18 AM (13 days ago) Jul 8
to Kent Tamura, Fredrik Söderquist, Ryan Hamilton, Nate Chapin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, loading...@chromium.org, gavinp...@chromium.org, net-r...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, jbroma...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org
Attention needed from Fredrik Söderquist and Ryan Hamilton

Kent Tamura added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Kent Tamura . resolved

fs@, would you review the whole CL please?
rch@ would you approve net/quic/ please?

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
  • Ryan Hamilton
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4bf0cd742df4b4ef833dee0402a08b9efa7e83d1
Gerrit-Change-Number: 8062845
Gerrit-PatchSet: 5
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Ryan Hamilton <r...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Ryan Hamilton <r...@chromium.org>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Wed, 08 Jul 2026 09:53:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Jul 8, 2026, 6:15:29 AM (13 days ago) Jul 8
to Kent Tamura, Ryan Hamilton, Nate Chapin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, loading...@chromium.org, gavinp...@chromium.org, net-r...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, jbroma...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org
Attention needed from Kent Tamura and Ryan Hamilton

Fredrik Söderquist voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
  • Ryan Hamilton
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4bf0cd742df4b4ef833dee0402a08b9efa7e83d1
    Gerrit-Change-Number: 8062845
    Gerrit-PatchSet: 6
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Ryan Hamilton <r...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Ryan Hamilton <r...@chromium.org>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 10:15:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ryan Hamilton (Gerrit)

    unread,
    Jul 9, 2026, 6:43:54 PM (12 days ago) Jul 9
    to Kent Tamura, Ryan Hamilton, Fredrik Söderquist, Nate Chapin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, loading...@chromium.org, gavinp...@chromium.org, net-r...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, jbroma...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org
    Attention needed from Fredrik Söderquist and Kent Tamura

    Ryan Hamilton voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Fredrik Söderquist
    • Kent Tamura
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4bf0cd742df4b4ef833dee0402a08b9efa7e83d1
    Gerrit-Change-Number: 8062845
    Gerrit-PatchSet: 7
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Ryan Hamilton <r...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Thu, 09 Jul 2026 22:43:41 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Kent Tamura (Gerrit)

    unread,
    Jul 9, 2026, 7:26:15 PM (12 days ago) Jul 9
    to Kent Tamura, Ryan Hamilton, Fredrik Söderquist, Nate Chapin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, loading...@chromium.org, gavinp...@chromium.org, net-r...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, jbroma...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org
    Attention needed from Fredrik Söderquist

    Kent Tamura voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Fredrik Söderquist
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4bf0cd742df4b4ef833dee0402a08b9efa7e83d1
    Gerrit-Change-Number: 8062845
    Gerrit-PatchSet: 7
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Ryan Hamilton <r...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
    Gerrit-Comment-Date: Thu, 09 Jul 2026 23:25:42 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 9, 2026, 8:52:17 PM (12 days ago) Jul 9
    to Kent Tamura, Ryan Hamilton, Fredrik Söderquist, Nate Chapin, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, loading...@chromium.org, gavinp...@chromium.org, net-r...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, jbroma...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Add -Wshorten-64-to-32 and -Wtautological-unsigned-zero-compare to `inside_blink` config
    Bug: 514751964
    Change-Id: I4bf0cd742df4b4ef833dee0402a08b9efa7e83d1
    Reviewed-by: Ryan Hamilton <r...@chromium.org>
    Commit-Queue: Kent Tamura <tk...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1659987}
    Files:
    • M net/quic/quic_proxy_datagram_client_socket.h
    • M net/quic/quic_session_pool.h
    • M third_party/blink/renderer/BUILD.gn
    • M third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_serializer.cc
    • M third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.cc
    • M third_party/blink/renderer/core/ad_tracker/ad_tracker_test.cc
    • M third_party/blink/renderer/core/annotation/annotation_agent_container_impl_test.cc
    • M third_party/blink/renderer/core/core.gni
    • M third_party/blink/renderer/core/exported/web_bundled_code_cache_generator_test.cc
    • M third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
    • M third_party/blink/renderer/core/html/fenced_frame/html_fenced_frame_element_test.cc
    • M third_party/blink/renderer/core/html/image_document_test.cc
    • M third_party/blink/renderer/core/html/media/media_fragment_uri_parser_test.cc
    • M third_party/blink/renderer/core/html/parser/html_document_parser_fastpath.cc
    • M third_party/blink/renderer/core/loader/frame_fetch_context.cc
    • M third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
    • M third_party/blink/renderer/core/loader/resource_load_observer_for_frame.cc
    • M third_party/blink/renderer/core/script_tools/model_context_test.cc
    • M third_party/blink/renderer/core/testing/internals.cc
    • M third_party/blink/renderer/core/timing/interaction_contentful_paint.cc
    • M third_party/blink/renderer/core/timing/interaction_contentful_paint.h
    • M third_party/blink/renderer/core/timing/performance_mark_conditional.cc
    • M third_party/blink/renderer/core/timing/performance_mark_conditional.h
    • M third_party/blink/renderer/core/timing/performance_measure.cc
    • M third_party/blink/renderer/core/timing/performance_measure.h
    • M third_party/blink/renderer/core/timing/performance_resource_timing.cc
    • M third_party/blink/renderer/core/timing/performance_resource_timing.h
    • M third_party/blink/renderer/core/timing/performance_script_timing.cc
    • M third_party/blink/renderer/core/timing/performance_script_timing.h
    • M third_party/blink/renderer/core/timing/performance_timing_for_reporting.cc
    • M third_party/blink/renderer/core/timing/performance_user_timing.cc
    • M third_party/blink/renderer/core/timing/performance_user_timing.h
    • M third_party/blink/renderer/core/timing/task_attribution_timing.cc
    • M third_party/blink/renderer/core/timing/task_attribution_timing.h
    • M third_party/blink/renderer/core/timing/window_performance_test.cc
    • M third_party/blink/renderer/modules/BUILD.gn
    • M third_party/blink/renderer/modules/indexeddb/idb_request_test.cc
    • M third_party/blink/renderer/modules/ml/webnn/ml_graph_test.cc
    • M third_party/blink/renderer/modules/modules.gni
    • M third_party/blink/renderer/modules/webcodecs/video_frame_test.cc
    • M third_party/blink/renderer/platform/BUILD.gn
    • M third_party/blink/renderer/platform/heap/test/weakness_marking_test.cc
    Change size: M
    Delta: 42 files changed, 83 insertions(+), 67 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Ryan Hamilton
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4bf0cd742df4b4ef833dee0402a08b9efa7e83d1
    Gerrit-Change-Number: 8062845
    Gerrit-PatchSet: 8
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Ryan Hamilton <r...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages