[cppgc] Add unmapped redzone to CagedHeap [v8/v8 : main]
0 views
Skip to first unread message
Michael Lippautz (Gerrit)
Mar 12, 2026, 7:57:28 AMMar 12
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Mar 12, 2026, 3:23:03 PMMar 12
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Dominik Inführ voted and added 2 comments![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Code-Review | +1 |
2 comments
Patchset-level comments
File src/heap/cppgc/caged-heap.cc
Line 207, Patchset 5 (Latest):
const size_t unusable_red_zone_size =Dominik Inführ . unresolved
Isn't `unusable_red_zone_size` exactly the same as `offset_to_allocatable_start`? I guess we could just use the latter below as well?
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Mar 12, 2026, 3:54:12 PMMar 12
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Commit-Queue | +2 |
1 comment
File src/heap/cppgc/caged-heap.cc
Line 207, Patchset 5 (Latest):
const size_t unusable_red_zone_size =Dominik Inführ . resolved
Isn't `unusable_red_zone_size` exactly the same as `offset_to_allocatable_start`? I guess we could just use the latter below as well?
Michael Lippautz
It also rounds up to `kPageSize` (Oilpan cage size), so it may be a bit more, depending on how the constants align up.
With the way the constants are set right now, I think it should be the same (because 32M aligns nicely with everything) but in order to stay generic, we'd probably should just keep it this way.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Mar 12, 2026, 3:55:46 PMMar 12
to Michael Lippautz, Dominik Inführ, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[cppgc] Add unmapped redzone to CagedHeap
In addition to the red zone of CagedHeapLocalData we reserve up to 32M
of unmapped memory. This aids conservative stack scanning in allowing us
to filter out more false positives.
Change-Id: I84347f6fab12f88dc2fc91cffa5c6c58fad66b05
Reviewed-by: Dominik Inführ <dinf...@chromium.org>
Commit-Queue: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105777}
Files:
- M src/heap/cppgc/caged-heap.cc
Change size: S
Delta: 1 file changed, 21 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dominik Inführ
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages