Revert "[profiler] Add postfix to C++ objects in DevTools heap snapshot" [v8/v8 : main]
0 views
Skip to first unread message
Manos Koukoutos (Gerrit)
Nov 14, 2025, 8:15:57 AMNov 14
to Rubber Stamper, Andreas Haas, Igor Sheludko, V8 LUCI CQ, Dominik Inführ, AyeAye, devtools-...@chromium.org, oilpan-r...@chromium.org
Attention needed from Andreas Haas, Dominik Inführ and Igor Sheludko
Manos Koukoutos voted![]( "Open in Gerrit")
| Commit-Queue | +2 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Andreas Haas
- Dominik Inführ
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Nov 14, 2025, 8:16:11 AMNov 14
to Manos Koukoutos, Andreas Haas, Igor Sheludko, V8 LUCI CQ, Dominik Inführ, AyeAye, devtools-...@chromium.org, oilpan-r...@chromium.org
Attention needed from Andreas Haas, Dominik Inführ, Igor Sheludko and Manos Koukoutos
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
Attention is currently required from:
- Andreas Haas
- Dominik Inführ
- Igor Sheludko
- Manos Koukoutos
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Manos Koukoutos (Gerrit)
Nov 14, 2025, 8:16:25 AMNov 14
to Rubber Stamper, Andreas Haas, Igor Sheludko, V8 LUCI CQ, Dominik Inführ, AyeAye, devtools-...@chromium.org, oilpan-r...@chromium.org
Attention needed from Andreas Haas, Dominik Inführ and Igor Sheludko
Manos Koukoutos voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Andreas Haas
- Dominik Inführ
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Nov 14, 2025, 8:16:31 AMNov 14
to Manos Koukoutos, Rubber Stamper, Andreas Haas, Igor Sheludko, Dominik Inführ, AyeAye, devtools-...@chromium.org, oilpan-r...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "[profiler] Add postfix to C++ objects in DevTools heap snapshot"
This reverts commit ade705de4f0edd04e8ea38636a95364a1571095f.
Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Blink%20Linux/40635/overview
Original change's description:
> [profiler] Add postfix to C++ objects in DevTools heap snapshot
>
> In a Chrome DevTools heap snapshot, both JavaScript and C++ objects are
> shown. In some instances, both a JavaScript object and a C++ object can
> even have the same name, e.g. "Window" objects. With this CL, the
> postfix "C++" is added to C++ objects so that they can be distinguished
> from JavaScript objects.
>
> Bug: 454073115
> Change-Id: I777419e4b4e30a9cbb53544a4b21f343445e2f85
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7139444
> Reviewed-by: Igor Sheludko <ish...@chromium.org>
> Reviewed-by: Dominik Inführ <dinf...@chromium.org>
> Commit-Queue: Andreas Haas <ah...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#103723}
Bug: 454073115
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I06e57aa4ef6f87e7e3672c37f3eb754090ee0b32
Owners-Override: Manos Koukoutos <mano...@chromium.org>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Commit-Queue: Manos Koukoutos <mano...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103725}
Files:
- M src/profiler/heap-snapshot-generator.cc
- M test/cctest/test-heap-profiler.cc
- M test/unittests/heap/cppgc-js/unified-heap-snapshot-unittest.cc
Change size: M
Delta: 3 files changed, 82 insertions(+), 104 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages