Provide FakeMojoBindingContext helper for Blink platform tests [chromium/src : main]

0 views

Skip to first unread message

Daniel Cheng (Gerrit)

unread,

Jun 24, 2024, 6:01:58 PM (5 days ago) Jun 24

to Daniel Cheng, Dave Tapuska, Chromium LUCI CQ, Nate Chapin, Sun Shin US, chromium...@chromium.org, Kentaro Hara, agriev...@chromium.org, ajayramamurth...@google.com, blink-re...@chromium.org, blink-...@chromium.org, blundell+...@chromium.org, crisrael+w...@google.com, dclasson+w...@google.com, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, jackshira+w...@google.com, kinuko...@chromium.org, kouhe...@chromium.org, network-ser...@chromium.org, oilpan-rev...@chromium.org, pushi+wat...@google.com, suetfei+wa...@google.com, xlythe+wa...@google.com

Attention needed from Nate Chapin

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

Commit-Queue

1 comment

File third_party/blink/renderer/platform/testing/fake_mojo_binding_context.cc

Line 28, Patchset 1: if (!IsContextDestroyed()) {

Dave Tapuska . resolved

This is kind of wacky that we don't actually attach this to an execution context. I didn't see a reason why it couldn't be done in the dependent CL. Is there a reason that I couldn't see?

Dave Tapuska

Oh nevermind, the dependent patch is in platform... I didn't catch that.

Daniel Cheng

I've updated the CL description so hopefully it's a bit clearer now. Sorry about that!

Open in Gerrit

Related details

Attention is currently required from:

Nate Chapin

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jun 24, 2024, 6:11:06 PM (5 days ago) Jun 24

to Daniel Cheng, Dave Tapuska, Nate Chapin, Sun Shin US, chromium...@chromium.org, Kentaro Hara, agriev...@chromium.org, ajayramamurth...@google.com, blink-re...@chromium.org, blink-...@chromium.org, blundell+...@chromium.org, crisrael+w...@google.com, dclasson+w...@google.com, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, jackshira+w...@google.com, kinuko...@chromium.org, kouhe...@chromium.org, network-ser...@chromium.org, oilpan-rev...@chromium.org, pushi+wat...@google.com, suetfei+wa...@google.com, xlythe+wa...@google.com

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Provide FakeMojoBindingContext helper for Blink platform tests

Normally, an ExecutionContext provides MojoBindingContext. However,
ExecutionContext is a core/ concept, and some platform/ tests also need
MojoBindingContexts. Provide a simple stubbed-out MojoBindingContext to
simplify writing those tests.

Change-Id: Ib4d7c99a596a6bb4448f70ff63316d4e5d6088fd

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5650065

Reviewed-by: Dave Tapuska <dtap...@chromium.org>

Commit-Queue: Daniel Cheng <dch...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1318820}

Files:

M third_party/blink/renderer/platform/BUILD.gn
A third_party/blink/renderer/platform/testing/fake_mojo_binding_context.cc
A third_party/blink/renderer/platform/testing/fake_mojo_binding_context.h

Change size: M

Delta: 3 files changed, 71 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Dave Tapuska

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages