[cppgc] Fix CycleEndHistogramReportsCorrectValues test [v8/v8 : main]

0 views
Skip to first unread message

Omer Katz (Gerrit)

unread,
Dec 4, 2025, 7:43:09 AM (4 days ago) Dec 4
to Dominik Inführ, V8 LUCI CQ, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ

Omer Katz added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Dominik Inführ
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I524ca22449309b0a2aafd7b0ee55bd9b1190660c
Gerrit-Change-Number: 7228222
Gerrit-PatchSet: 1
Gerrit-Owner: Omer Katz <omer...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
Gerrit-Attention: Dominik Inführ <dinf...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Dec 2025 12:43:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dominik Inführ (Gerrit)

unread,
Dec 4, 2025, 8:02:09 AM (4 days ago) Dec 4
to Omer Katz, V8 LUCI CQ, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Omer Katz

Dominik Inführ voted and added 1 comment

Votes added by Dominik Inführ

Code-Review+1

1 comment

Patchset-level comments
Dominik Inführ . resolved

Thanks, LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Omer Katz
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I524ca22449309b0a2aafd7b0ee55bd9b1190660c
Gerrit-Change-Number: 7228222
Gerrit-PatchSet: 1
Gerrit-Owner: Omer Katz <omer...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
Gerrit-Attention: Omer Katz <omer...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Dec 2025 13:02:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Omer Katz (Gerrit)

unread,
Dec 4, 2025, 8:11:44 AM (4 days ago) Dec 4
to Dominik Inführ, V8 LUCI CQ, oilpan-r...@chromium.org, v8-re...@googlegroups.com

Omer Katz voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I524ca22449309b0a2aafd7b0ee55bd9b1190660c
Gerrit-Change-Number: 7228222
Gerrit-PatchSet: 1
Gerrit-Owner: Omer Katz <omer...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Dec 2025 13:11:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Dec 4, 2025, 8:37:03 AM (4 days ago) Dec 4
to Omer Katz, Dominik Inführ, oilpan-r...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[cppgc] Fix CycleEndHistogramReportsCorrectValues test

The test checks that scope durations are as expected. In time of high
cpu contention, the test can get preempted while a scope is open, thus
increasing the duration and causing DCHECKs to fail.
Instead we can just check that the duration is at least the expected
value. It's less strict but shouldn't falkily crash.
Bug: 465398124
Change-Id: I524ca22449309b0a2aafd7b0ee55bd9b1190660c
Reviewed-by: Dominik Inführ <dinf...@chromium.org>
Commit-Queue: Omer Katz <omer...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104116}
Files:
  • M test/unittests/heap/cppgc/metric-recorder-unittest.cc
Change size: M
Delta: 1 file changed, 30 insertions(+), 55 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Dominik Inführ
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I524ca22449309b0a2aafd7b0ee55bd9b1190660c
Gerrit-Change-Number: 7228222
Gerrit-PatchSet: 2
Gerrit-Owner: Omer Katz <omer...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages