[M149] blink: Make HeapBarrierCallback thread-safe by default [chromium/src : refs/branch-heads/7827]
0 views
Skip to first unread message
Eugene Zemtsov (Gerrit)
May 26, 2026, 4:37:02 PM (5 days ago) May 26
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Eugene Zemtsov, Kentaro Hara, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, rubber-...@appspot.gserviceaccount.com, kinuko...@chromium.org, blink-...@chromium.org, oilpan-rev...@chromium.org, kouhe...@chromium.org
Eugene Zemtsov voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 26, 2026, 5:57:53 PM (4 days ago) May 26
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Eugene Zemtsov, Kentaro Hara, android-bu...@system.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, kinuko...@chromium.org, blink-...@chromium.org, oilpan-rev...@chromium.org, kouhe...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[M149] blink: Make HeapBarrierCallback thread-safe by default
Original change's description:
> blink: Make HeapBarrierCallback thread-safe by default
>
> HeapBarrierCallback was using Persistent to store aggregated results.
> Since Persistent handles are thread-affine, destroying or clearing them
> on another thread (e.g. when a PostTask fails due to worker thread
> shutdown) results in free-list corruption of the calling thread's
> PersistentRegion.
>
> This change replaces Persistent with UnwrappingCrossThreadHandle to
> ensure safe cross-thread destruction while strictly enforcing that the
> underlying vector is only dereferenced on its creation thread,
> preventing data races.
>
> Bug: 514715455
> Change-Id: I44930a8d0d742a6194c6380c7b94abc8cf03dab7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7860937
> Reviewed-by: Nate Chapin <jap...@chromium.org>
> Commit-Queue: Eugene Zemtsov <eug...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1633752}
(cherry picked from commit 6fd20a57fccfaf70f2b472c7f1246033011af527)
Bug: 515275802,514715455
Change-Id: I44930a8d0d742a6194c6380c7b94abc8cf03dab7
Auto-Submit: chrome-che...@chops-service-accounts.iam.gserviceaccount.com <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Eugene Zemtsov <eug...@chromium.org>
Cr-Commit-Position: refs/branch-heads/7827@{#1805}
Cr-Branched-From: 9f3e9aaccba63bd2ec30334e45e0bfd07ebcc8f1-refs/heads/main@{#1625079}
Files:
- M third_party/blink/renderer/platform/heap/heap_barrier_callback.h
Change size: S
Delta: 1 file changed, 7 insertions(+), 5 deletions(-)
Branch: refs/branch-heads/7827
Submit Requirements:
Code-Review: Bot-Commit+1 by rubber-...@appspot.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages