cppgc: Remove unused decommit_pooled_pages flag [v8/v8 : main]
0 views
Skip to first unread message
Francois Pierre Doray (Gerrit)
Nov 27, 2025, 8:40:17 PM (11 days ago) Nov 27
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Francois Pierre Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Nov 28, 2025, 5:24:02 AM (10 days ago) Nov 28
to Francois Pierre Doray, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Francois Pierre Doray
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Francois Pierre Doray (Gerrit)
Nov 28, 2025, 9:49:42 AM (10 days ago) Nov 28
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Francois Pierre Doray voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Francois Pierre Doray (Gerrit)
Nov 28, 2025, 4:32:44 PM (10 days ago) Nov 28
to Dominik Inführ, Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Francois Pierre Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Francois Pierre Doray
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Francois Pierre Doray . resolved
dinfuehr@: I'm not a V8 committer. Please take a look as V8 committer to meet the 2 committers CR+1 requirement. Thanks!
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Francois Pierre Doray (Gerrit)
Dec 1, 2025, 8:47:26 AM (7 days ago) Dec 1
to Anton Bikineev, Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Anton Bikineev
Francois Pierre Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Francois Pierre Doray . resolved
+bikineev@ (in replacement of dinfuehr who is OOO): Can you provide CR+1? I'm not a V8 committer so I need a 2nd CR+1 to land this. Thanks a lot!
Related details
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anton Bikineev (Gerrit)
Dec 1, 2025, 9:13:06 AM (7 days ago) Dec 1
to Francois Pierre Doray, Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Francois Pierre Doray
Anton Bikineev added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Dec 1, 2025, 10:01:20 AM (7 days ago) Dec 1
to Francois Pierre Doray, Anton Bikineev, Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Francois Pierre Doray
Etienne Pierre-Doray voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Dec 1, 2025, 11:02:34 AM (7 days ago) Dec 1
to Francois Pierre Doray, Etienne Pierre-Doray, Anton Bikineev, Michael Lippautz, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
cppgc: Remove unused decommit_pooled_pages flag
The `decommit_pooled_pages` flag defaults to true and is not currently
overridden by major embedders like Chromium or Node.js.
Bug: chromium:326303884
Change-Id: Iad8d3676f4e16aca46136b6118f6f3285f3e1193
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Auto-Submit: Francois Pierre Doray <fdo...@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104035}
Files:
- M src/flags/flag-definitions.h
- M src/heap/cppgc-js/cpp-heap.cc
- M src/heap/cppgc/page-memory.cc
- M src/heap/cppgc/page-memory.h
- M test/unittests/heap/cppgc/page-memory-unittest.cc
Change size: S
Delta: 5 files changed, 5 insertions(+), 42 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Etienne Pierre-Doray, +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages