Revert "Create a string_view instead of string from char*." [v8/v8 : main]

0 views
Skip to first unread message

Rubber Stamper (Gerrit)

unread,
Jan 9, 2026, 12:42:09 PM (9 days ago) Jan 9
to Jeffrey Yu, Hannes Payer, AyeAye, Darius Mercadier, Michael Lippautz, V8 LUCI CQ, Clemens Backes, oilpan-r...@chromium.org, mlippau...@chromium.org
Attention needed from Darius Mercadier and Michael Lippautz

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Darius Mercadier
  • Michael Lippautz
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ia9a8ce89b954e883e79bb238732fc1361db42038
Gerrit-Change-Number: 7421914
Gerrit-PatchSet: 1
Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: Clemens Backes <clem...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 17:42:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
Jan 9, 2026, 2:51:07 PM (8 days ago) Jan 9
to Jeffrey Yu, Rubber Stamper, Hannes Payer, AyeAye, Darius Mercadier, V8 LUCI CQ, Clemens Backes, oilpan-r...@chromium.org, mlippau...@chromium.org
Attention needed from Darius Mercadier and Jeffrey Yu

Michael Lippautz voted and added 1 comment

Votes added by Michael Lippautz

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Michael Lippautz . resolved

NameTrait is not used on any perf critical path. It's used for DevTools heap snapshots.

Open in Gerrit

Related details

Attention is currently required from:
  • Darius Mercadier
  • Jeffrey Yu
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ia9a8ce89b954e883e79bb238732fc1361db42038
Gerrit-Change-Number: 7421914
Gerrit-PatchSet: 1
Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: Clemens Backes <clem...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Attention: Jeffrey Yu <yu...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 19:51:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Jeffrey Yu (Gerrit)

unread,
Jan 15, 2026, 3:08:16 PM (2 days ago) Jan 15
to Michael Lippautz, Rubber Stamper, Hannes Payer, AyeAye, Darius Mercadier, V8 LUCI CQ, Clemens Backes, oilpan-r...@chromium.org, mlippau...@chromium.org

Jeffrey Yu abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages