Add LIFETIME_BOUND to methods returning references to members. [chromium/src : main]

0 views
Skip to first unread message

Tom Sepez (Gerrit)

unread,
Feb 27, 2025, 1:38:38 PMFeb 27
to AyeAye Python Dispatcher, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Dirk Schulze, Enterprise Policy Reviews, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Hans Wennborg, Kentaro Hara, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Sam Clegg, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Ian Vollick, James Maclean, Zijie He, abigailbk...@google.com, ajayramamurthy+w...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, apaselti...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, asumane...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, biciogl...@google.com, binji...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, chili...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-web-vita...@chromium.org, creis...@chromium.org, crisrael+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, crostin...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, cwp-review...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, dtapuska+...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, enne...@chromium.org, eric.c...@apple.com, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fenced-fra...@chromium.org, ffred...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, fuchsia...@chromium.org, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, gogerald+pa...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+wa...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jackshira+wat...@google.com, jackshira+wa...@google.com, jasonrobe...@google.com, jbauma...@chromium.org, jbroma...@chromium.org, jdonnel...@chromium.org, jessemcke...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, joeantonetti+...@google.com, jonmann+watc...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kouhe...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mahmad...@chromium.org, marimatthew+watc...@google.com, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, nator...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, npnavarro+p...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, oilpan-rev...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, pdr+svgw...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, pushi+watc...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, scheduler...@chromium.org, scheduler-...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, speed-metr...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tmartino+tran...@chromium.org, tommyw+w...@chromium.org, toshikikikuchi+...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, tsergea...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, video-networking...@google.com, webapks-...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org, zhangwen...@google.com, zol...@webkit.org

Tom Sepez added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Tom Sepez . resolved

dcheng, please take a cursory look and let me know about objections, and your thoughts on a landing strategy.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I046f20b5e9d5274f2475f83716e6024ff3b9ae8f
Gerrit-Change-Number: 6299043
Gerrit-PatchSet: 5
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sam Clegg <s...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 18:38:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
Feb 27, 2025, 1:55:49 PMFeb 27
to Daniel Cheng, AyeAye Python Dispatcher, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Dirk Schulze, Enterprise Policy Reviews, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Hans Wennborg, Kentaro Hara, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Sam Clegg, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Ian Vollick, James Maclean, Zijie He, abigailbk...@google.com, ajayramamurthy+w...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, apaselti...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, asumane...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, biciogl...@google.com, binji...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, chili...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-web-vita...@chromium.org, creis...@chromium.org, crisrael+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, crostin...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, cwp-review...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, dtapuska+...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, enne...@chromium.org, eric.c...@apple.com, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fenced-fra...@chromium.org, ffred...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, fuchsia...@chromium.org, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, gogerald+pa...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+wa...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jackshira+wat...@google.com, jackshira+wa...@google.com, jasonrobe...@google.com, jbauma...@chromium.org, jbroma...@chromium.org, jdonnel...@chromium.org, jessemcke...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, joeantonetti+...@google.com, jonmann+watc...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kouhe...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mahmad...@chromium.org, marimatthew+watc...@google.com, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, nator...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, npnavarro+p...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, oilpan-rev...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, pdr+svgw...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, pushi+watc...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, scheduler...@chromium.org, scheduler-...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, speed-metr...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tmartino+tran...@chromium.org, tommyw+w...@chromium.org, toshikikikuchi+...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, tsergea...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, video-networking...@google.com, webapks-...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org, zhangwen...@google.com, zol...@webkit.org
Attention needed from Daniel Cheng

Tom Sepez added 1 comment

Patchset-level comments
Tom Sepez . resolved

Actually adding Daniel just for spot inspection and overview of the technique, plus thoughts about how to land.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I046f20b5e9d5274f2475f83716e6024ff3b9ae8f
Gerrit-Change-Number: 6299043
Gerrit-PatchSet: 5
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Thu, 27 Feb 2025 18:55:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Feb 28, 2025, 2:08:15 PMFeb 28
to Tom Sepez, Daniel Cheng, AyeAye Python Dispatcher, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Dirk Schulze, Enterprise Policy Reviews, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Hans Wennborg, Kentaro Hara, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Sam Clegg, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Ian Vollick, James Maclean, Zijie He, abigailbk...@google.com, ajayramamurthy+w...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, apaselti...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, asumane...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, biciogl...@google.com, binji...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, chili...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-web-vita...@chromium.org, creis...@chromium.org, crisrael+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, crostin...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, cwp-review...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, dtapuska+...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, enne...@chromium.org, eric.c...@apple.com, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fenced-fra...@chromium.org, ffred...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, fuchsia...@chromium.org, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, gogerald+pa...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+wa...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jackshira+wat...@google.com, jackshira+wa...@google.com, jasonrobe...@google.com, jbauma...@chromium.org, jbroma...@chromium.org, jdonnel...@chromium.org, jessemcke...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, joeantonetti+...@google.com, jonmann+watc...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kouhe...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mahmad...@chromium.org, marimatthew+watc...@google.com, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, nator...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, npnavarro+p...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, oilpan-rev...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, pdr+svgw...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, pushi+watc...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, scheduler...@chromium.org, scheduler-...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, speed-metr...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tmartino+tran...@chromium.org, tommyw+w...@chromium.org, toshikikikuchi+...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, tsergea...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, video-networking...@google.com, webapks-...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org, zhangwen...@google.com, zol...@webkit.org
Attention needed from Tom Sepez

Daniel Cheng added 1 comment

Patchset-level comments
Daniel Cheng . resolved

1. Just curious, but how did you generate this? Was it just regexes or was there some clang tool to look for things returning pointers/references to fields?
2. Do you see a world where the compiler would implicitly do this automatically instead of us having to annotate? I imagine this could get potentially tricky with things that return std::string_view wrapping fields, but maybe we can start conservatively and expand scope over time?

Open in Gerrit

Related details

Attention is currently required from:
  • Tom Sepez
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Fri, 28 Feb 2025 19:07:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
Feb 28, 2025, 2:11:46 PMFeb 28
to Daniel Cheng, AyeAye Python Dispatcher, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Dirk Schulze, Enterprise Policy Reviews, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Hans Wennborg, Kentaro Hara, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Sam Clegg, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Ian Vollick, James Maclean, Zijie He, abigailbk...@google.com, ajayramamurthy+w...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, apaselti...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, asumane...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, biciogl...@google.com, binji...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, chili...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-web-vita...@chromium.org, creis...@chromium.org, crisrael+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, crostin...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, cwp-review...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, dtapuska+...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, enne...@chromium.org, eric.c...@apple.com, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fenced-fra...@chromium.org, ffred...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, fuchsia...@chromium.org, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, gogerald+pa...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+wa...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jackshira+wat...@google.com, jackshira+wa...@google.com, jasonrobe...@google.com, jbauma...@chromium.org, jbroma...@chromium.org, jdonnel...@chromium.org, jessemcke...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, joeantonetti+...@google.com, jonmann+watc...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kouhe...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mahmad...@chromium.org, marimatthew+watc...@google.com, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, nator...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, npnavarro+p...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, oilpan-rev...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, pdr+svgw...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, pushi+watc...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, scheduler...@chromium.org, scheduler-...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, speed-metr...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tmartino+tran...@chromium.org, tommyw+w...@chromium.org, toshikikikuchi+...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, tsergea...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, video-networking...@google.com, webapks-...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org, zhangwen...@google.com, zol...@webkit.org
Attention needed from Daniel Cheng

Tom Sepez added 1 comment

Patchset-level comments
Daniel Cheng . resolved

1. Just curious, but how did you generate this? Was it just regexes or was there some clang tool to look for things returning pointers/references to fields?
2. Do you see a world where the compiler would implicitly do this automatically instead of us having to annotate? I imagine this could get potentially tricky with things that return std::string_view wrapping fields, but maybe we can start conservatively and expand scope over time?

Tom Sepez

1. grep and sed are my favorite hammers.
2. Not really, otherwise they wouldn't have introduced the [[clang::lifetime_bound]] annotation. If this should come to pass, s/LIFETIME_BOUND// is pretty easy.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Fri, 28 Feb 2025 19:11:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
Aug 4, 2025, 1:19:26 PMAug 4
to Daniel Cheng, AyeAye Python Dispatcher, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Dirk Schulze, Enterprise Policy Reviews, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Hans Wennborg, Kentaro Hara, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Sam Clegg, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Ian Vollick, James Maclean, Zijie He, abigailbk...@google.com, ajayramamurthy+w...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, apaselti...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, asumane...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, biciogl...@google.com, binji...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, chili...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-web-vita...@chromium.org, creis...@chromium.org, crisrael+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, crostin...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, cwp-review...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, dtapuska+...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, enne...@chromium.org, eric.c...@apple.com, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fenced-fra...@chromium.org, ffred...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, fuchsia...@chromium.org, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, gogerald+pa...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+wa...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jackshira+wat...@google.com, jackshira+wa...@google.com, jasonrobe...@google.com, jbauma...@chromium.org, jbroma...@chromium.org, jdonnel...@chromium.org, jessemcke...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, joeantonetti+...@google.com, jonmann+watc...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kouhe...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mahmad...@chromium.org, marimatthew+watc...@google.com, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, nator...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, npnavarro+p...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, oilpan-rev...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, pdr+svgw...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, pushi+watc...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, scheduler...@chromium.org, scheduler-...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, speed-metr...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tmartino+tran...@chromium.org, tommyw+w...@chromium.org, toshikikikuchi+...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, tsergea...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, video-networking...@google.com, webapks-...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org, zhangwen...@google.com, zol...@webkit.org

Tom Sepez abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages