Jakob Kummerow (Gerrit)

unread,

Apr 10, 2026, 10:29:31 AM (10 days ago) Apr 10

to Jakob Kummerow, Leszek Swirski, Hannes Payer, cbruni...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, v8-risc...@chromium.org, was...@google.com

Attention needed from Leszek Swirski

Jakob Kummerow voted and added 2 comments

Votes added by Jakob Kummerow

Auto-Submit	+1
Commit-Queue	+1

2 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Jakob Kummerow . resolved

PTAL.

The biggest reason for spending time on this is that it creates an opportunity for a funny commit description. I hope you're entertained.

File src/execution/isolate.cc

Line 3129, Patchset 1 (Latest): // deoptimizer of the exception and just return the Deoptimization

Jakob Kummerow . resolved

Bonus fix!!!

Open in Gerrit

Related details

Attention is currently required from:

Leszek Swirski

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Leszek Swirski (Gerrit)

unread,

Apr 10, 2026, 10:40:45 AM (10 days ago) Apr 10

to Jakob Kummerow, V8 LUCI CQ, Hannes Payer, cbruni...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, v8-risc...@chromium.org, was...@google.com

Attention needed from Jakob Kummerow

Leszek Swirski voted and added 1 comment

Votes added by Leszek Swirski

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Jakob Kummerow . resolved

PTAL.
The biggest reason for spending time on this is that it creates an opportunity for a funny commit description. I hope you're entertained.

Leszek Swirski

You mean "the the biggest reason"? Totally worth it.

Open in Gerrit

Related details

Attention is currently required from:

Jakob Kummerow

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Jakob Kummerow (Gerrit)

unread,

Apr 10, 2026, 12:21:14 PM (10 days ago) Apr 10

to Jakob Kummerow, Leszek Swirski, V8 LUCI CQ, Hannes Payer, cbruni...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, v8-risc...@chromium.org, was...@google.com

Attention needed from Leszek Swirski

Jakob Kummerow voted and added 1 comment

Votes added by Jakob Kummerow

Auto-Submit	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Jakob Kummerow . resolved

Thanks for the the review! Fixed the the test; landing.

Open in Gerrit

Related details

Attention is currently required from:

Leszek Swirski

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

V8 LUCI CQ (Gerrit)

unread,

Apr 10, 2026, 1:08:49 PM (10 days ago) Apr 10

to Jakob Kummerow, Leszek Swirski, Hannes Payer, cbruni...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, v8-risc...@chromium.org, was...@google.com

V8 LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: test/mjsunit/unicode-test.js
Insertions: 1, Deletions: 1.

@@ -9097,7 +9097,7 @@
 assertEquals(31082, japanese.length, "japanese utf8 in source");
 assertEquals(12291, korean.length, "korean utf8 in source");
 assertEquals(13851, persian.length, "persian utf8 in source");
-assertEquals(177473, source.length, "source utf8 in source");
+assertEquals(177469, source.length, "source utf8 in source");
 assertEquals(18315, thai.length, "thai utf8 in source");
 
 munged_sizes = new Array(17197, 2511, 2645, 3820, 3086, 2609,
```

Change information

Commit message:

[cleanup] Fix the the typo

s/the the/the/g

Change-Id: Iadd29c495aa8322714bdf101b02890161d3bb034

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7748287

Commit-Queue: Jakob Kummerow <jkum...@chromium.org>

Auto-Submit: Jakob Kummerow <jkum...@chromium.org>

Reviewed-by: Leszek Swirski <les...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#106399}

Files:

M include/v8-sandbox.h
M src/ast/scopes.h
M src/base/cpu/cpu-arm.cc
M src/base/platform/platform-posix.cc
M src/base/platform/platform-win32.cc
M src/builtins/builtins-collections-gen.cc
M src/builtins/js-to-wasm.tq
M src/codegen/code-stub-assembler.h
M src/codegen/interface-descriptors.cc
M src/codegen/macro-assembler.h
M src/compiler/bytecode-graph-builder.cc
M src/compiler/c-linkage.cc
M src/compiler/code-assembler.h
M src/compiler/int64-lowering.cc
M src/compiler/js-call-reducer.cc
M src/compiler/js-native-context-specialization.cc
M src/compiler/load-elimination.cc
M src/compiler/machine-operator-reducer.cc
M src/diagnostics/disassembler.h
M src/diagnostics/gdb-jit.cc
M src/execution/isolate.cc
M src/flags/flag-definitions.h
M src/heap/cppgc/sweeper.cc
M src/heap/memory-chunk.h
M src/heap/scavenger.cc
M src/interpreter/interpreter-generator.cc
M src/numbers/conversions.h
M src/objects/compressed-slots.h
M src/objects/heap-object.h
M src/objects/keys.h
M src/objects/ordered-hash-table.h
M src/objects/script.h
M src/objects/string.cc
M src/objects/templates.tq
M src/objects/trusted-pointer.h
M src/parsing/scanner-character-streams.cc
M src/regexp/arm64/regexp-macro-assembler-arm64.cc
M src/regexp/riscv/regexp-macro-assembler-riscv.cc
M src/regexp/x64/regexp-macro-assembler-x64.cc
M src/snapshot/serializer.h
M src/wasm/wasm-js.cc
M test/cctest/test-api-interceptors.cc
M test/cctest/test-swiss-name-dictionary-infra.cc
M test/mjsunit/es6/reflect-prevent-extensions.js
M test/mjsunit/object-prevent-extensions.js
M test/mjsunit/regress/regress-2443.js
M test/mjsunit/unicode-test.js
M test/unittests/base/hashmap-unittest.cc
M test/unittests/heap/cppgc/name-trait-unittest.cc
M test/unittests/objects/object-unittest.cc
M test/unittests/profiler/circular-queue-unittest.cc

Change size: M

Delta: 51 files changed, 56 insertions(+), 56 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Leszek Swirski

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[cleanup] Fix the the typo [v8/v8 : main]

Jakob Kummerow (Gerrit)

Jakob Kummerow voted and added 2 comments

Votes added by Jakob Kummerow

2 comments

Related details

Leszek Swirski (Gerrit)

Leszek Swirski voted and added 1 comment

Votes added by Leszek Swirski

1 comment

Related details

Jakob Kummerow (Gerrit)

Jakob Kummerow voted and added 1 comment

Votes added by Jakob Kummerow

1 comment

Related details

V8 LUCI CQ (Gerrit)

V8 LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information