Convert to UNSAFE_TODO in skia [chromium/src : main]
0 views
Skip to first unread message
Arthur Sonzogni (Gerrit)
Nov 13, 2025, 6:11:19 AMNov 13
to Eric Boren, Hongchan Choi, Stephen Chenney, Dirk Schulze, Kentaro Hara, Hirokazu Honda, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, video-networking...@google.com, kouhe...@chromium.org, drott+bl...@chromium.org, kinuko...@chromium.org, fserb...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, oilpan-rev...@chromium.org, ipc-securi...@chromium.org, mac-r...@chromium.org
Attention needed from Eric Boren
Arthur Sonzogni voted and added 1 comment![]( "Open in Gerrit")
Votes added by Arthur Sonzogni
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Arthur Sonzogni . resolved
Hi @bor...@google.com,
Could you please take a look?
- *Manual change**
- I [reverted](https://chromium-review.googlesource.com/c/chromium/src/+/7132244/3..6):
- `skia/ext/convolver.cc`
- `skia/ext/convolver_neon.cc`
- Because every instruction are unchecked array accesses. There is no point to remove a file level opt-out if we are opting out every lines.
Related details
Attention is currently required from:
- Eric Boren
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eric Boren (Gerrit)
Nov 14, 2025, 8:24:16 AMNov 14
to Arthur Sonzogni, Hongchan Choi, Stephen Chenney, Dirk Schulze, Kentaro Hara, Hirokazu Honda, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, video-networking...@google.com, kouhe...@chromium.org, drott+bl...@chromium.org, kinuko...@chromium.org, fserb...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, oilpan-rev...@chromium.org, ipc-securi...@chromium.org, mac-r...@chromium.org
Attention needed from Arthur Sonzogni
Eric Boren voted![]( "Open in Gerrit")
Attention is currently required from:
- Arthur Sonzogni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Nov 14, 2025, 8:31:55 AMNov 14
to Eric Boren, Hongchan Choi, Stephen Chenney, Dirk Schulze, Kentaro Hara, Hirokazu Honda, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, video-networking...@google.com, kouhe...@chromium.org, drott+bl...@chromium.org, kinuko...@chromium.org, fserb...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, oilpan-rev...@chromium.org, ipc-securi...@chromium.org, mac-r...@chromium.org
Arthur Sonzogni voted and added 1 comment![]( "Open in Gerrit")
Votes added by Arthur Sonzogni
| Auto-Submit | +1 |
Chromium LUCI CQ (Gerrit)
Nov 14, 2025, 8:37:34 AMNov 14
to Arthur Sonzogni, Eric Boren, Hongchan Choi, Stephen Chenney, Dirk Schulze, Kentaro Hara, Hirokazu Honda, AyeAye, chromium...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, video-networking...@google.com, kouhe...@chromium.org, drott+bl...@chromium.org, kinuko...@chromium.org, fserb...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, oilpan-rev...@chromium.org, ipc-securi...@chromium.org, mac-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Convert to UNSAFE_TODO in skia
This is an automated #cleanup patch using the [Script] below.
We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations,
allowing the rest of the file to be enforced as safe.
This CL was uploaded by git cl split.
Script: https://docs.google.com/document/d/1ORQGBNn2R-CEvNbDTjRd-GrOBOFlCxIHdcvSUA_EhR4/edit?usp=sharing
AX-Relnotes: N/A
Cleanup: This is an automated #cleanup.
Bug: 409340989
Change-Id: If8392c0c00ba12eb97130eeb1376b6bca15b43c5
Reviewed-by: Eric Boren <bor...@google.com>
Commit-Queue: Eric Boren <bor...@google.com>
Auto-Submit: Arthur Sonzogni <arthurs...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1544902}
Files:
- M skia/ext/image_operations_bench.cc
- M skia/ext/image_operations_unittest.cc
- M skia/public/mojom/skcolorspace_mojom_traits.h
Change size: S
Delta: 3 files changed, 15 insertions(+), 27 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Eric Boren
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages