[cppgc] Add missing reset call for marked bytes [v8/v8 : main]
0 views
Skip to first unread message
Michael Lippautz (Gerrit)
Jun 25, 2024, 2:45:16 AM (5 days ago) Jun 25
to Omer Katz, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Omer Katz
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Michael Lippautz . resolved
I will look into whether there's a better bottleneck. For the bugfix I am leaning on the same pattern as the other calls (right before `Traverse()`).
Related details
Attention is currently required from:
- Omer Katz
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
Jun 25, 2024, 3:00:22 AM (5 days ago) Jun 25
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Omer Katz voted![]( "Open in Gerrit")
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jun 25, 2024, 3:30:23 AM (5 days ago) Jun 25
to Michael Lippautz, Omer Katz, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[cppgc] Add missing reset call for marked bytes
There's a one path that missed the reset call for marked bytes. This
can lead to counter overflow.
Bug: 333981063
Change-Id: Id6caeb8ea39674981f06fdc3a4545e331871cd53
Auto-Submit: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Omer Katz <omer...@chromium.org>
Commit-Queue: Michael Lippautz <mlip...@chromium.org>
Reviewed-by: Omer Katz <omer...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#94617}
Files:
- M src/heap/cppgc/sweeper.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Omer Katz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages