[cppgc] Add static_assert to Visitor::Trace(const T&) [v8/v8 : main]
0 views
Skip to first unread message
Omer Katz (Gerrit)
Oct 16, 2025, 2:33:51 PM (5 days ago) Oct 16
to Anton Bikineev, V8 LUCI CQ, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Anton Bikineev
Omer Katz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anton Bikineev (Gerrit)
5:13 AM (4 hours ago) 5:13 AM
to Omer Katz, Code Review Nudger, V8 LUCI CQ, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Omer Katz
Anton Bikineev voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Omer Katz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
5:13 AM (4 hours ago) 5:13 AM
to Anton Bikineev, Code Review Nudger, V8 LUCI CQ, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Omer Katz voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
6:10 AM (3 hours ago) 6:10 AM
to Omer Katz, Anton Bikineev, Code Review Nudger, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[cppgc] Add static_assert to Visitor::Trace(const T&)
Enforce that the Visitor::Trace(const T&) method that is used for
non-reference fields (e.g. embedded DISALLOW_NEW objects) is never
called for GCed types.
Change-Id: Id896ff1dcec3c42a7e9bc11c4a64e850d8e7e143
Reviewed-by: Anton Bikineev <biki...@chromium.org>
Commit-Queue: Omer Katz <omer...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103236}
Files:
- M include/cppgc/visitor.h
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Anton Bikineev
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages