[execution, heap] Remove Isolate::InFastCCall() [v8/v8 : main]

[Dominik Inführ (Gerrit)]

Attention needed from Andreas Haas

Dominik Inführ added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Dominik Inführ . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

• Andreas Haas

Submit Requirements:

• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Ib1626b30e1e8436513648c906ed4476f3cb6f77c

Gerrit-Change-Number: 6678594

Gerrit-PatchSet: 3

Gerrit-Owner: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>

Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Andreas Haas <ah...@chromium.org>

Gerrit-Comment-Date: Thu, 26 Jun 2025 08:50:43 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Andreas Haas (Gerrit)]

Attention needed from Dominik Inführ

Andreas Haas voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Dominik Inführ

Submit Requirements:

• Code-Owners

• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Ib1626b30e1e8436513648c906ed4476f3cb6f77c

Gerrit-Change-Number: 6678594

Gerrit-PatchSet: 3

Gerrit-Owner: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>

Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Dominik Inführ <dinf...@chromium.org>

Gerrit-Comment-Date: Thu, 26 Jun 2025 08:52:24 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Dominik Inführ (Gerrit)]

Attention needed from Michael Lippautz

Dominik Inführ added 2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Dominik Inführ . resolved

PTAL

File src/heap/cppgc-js/cpp-heap.cc

Line 1365, Patchset 3 (Parent):bool CppHeap::IsGCForbidden() const {

Dominik Inführ . unresolved

I suppose we don't need `isolate_ && ..` here, so we should be able to use the method directly from the base class.

Open in Gerrit

Related details

Attention is currently required from:

• Michael Lippautz

Submit Requirements:

• Code-Owners
• Code-Review

• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Ib1626b30e1e8436513648c906ed4476f3cb6f77c

Gerrit-Change-Number: 6678594

Gerrit-PatchSet: 3

Gerrit-Owner: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>

Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Comment-Date: Thu, 26 Jun 2025 08:59:06 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Dominik Inführ (Gerrit)]

Attention needed from Andreas Haas and Michael Lippautz

Dominik Inführ added 1 comment

File src/heap/cppgc-js/cpp-heap.cc

Line 1365, Patchset 3 (Parent):bool CppHeap::IsGCForbidden() const {

Dominik Inführ . resolved

I suppose we don't need `isolate_ && ..` here, so we should be able to use the method directly from the base class.

Dominik Inführ

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

• Andreas Haas
• Michael Lippautz

Submit Requirements:

• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Ib1626b30e1e8436513648c906ed4476f3cb6f77c

Gerrit-Change-Number: 6678594

Gerrit-PatchSet: 6

Gerrit-Owner: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>

Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Andreas Haas <ah...@chromium.org>

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Comment-Date: Thu, 16 Oct 2025 11:53:47 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Dominik Inführ <dinf...@chromium.org>

[Dominik Inführ (Gerrit)]

Attention needed from Andreas Haas and Michael Lippautz

Dominik Inführ added 1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Dominik Inführ . resolved

PTAL, I've rebased the CL and fixed a failing test.

Gerrit-Comment-Date: Thu, 16 Oct 2025 11:54:22 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Andreas Haas (Gerrit)]

Attention needed from Dominik Inführ and Michael Lippautz

Andreas Haas voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Dominik Inführ
• Michael Lippautz

Submit Requirements:

• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Ib1626b30e1e8436513648c906ed4476f3cb6f77c

Gerrit-Change-Number: 6678594

Gerrit-PatchSet: 6

Gerrit-Owner: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>

Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Attention: Dominik Inführ <dinf...@chromium.org>

Gerrit-Comment-Date: Thu, 16 Oct 2025 12:17:28 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Michael Lippautz (Gerrit)]

Attention needed from Dominik Inführ

Michael Lippautz voted and added 2 comments

Votes added by Michael Lippautz

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Michael Lippautz . resolved

lgtm

File src/heap/mark-compact.cc

Line 4996, Patchset 7 (Latest): if (heap_->IsGCWithStack()) {
if (!v8_flags.compact_with_stack) {

Michael Lippautz . unresolved

Combine condition

Open in Gerrit

Related details

Attention is currently required from:

• Dominik Inführ

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Ib1626b30e1e8436513648c906ed4476f3cb6f77c

Gerrit-Change-Number: 6678594

Gerrit-PatchSet: 7

Gerrit-Owner: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Andreas Haas <ah...@google.com>

Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Dominik Inführ <dinf...@chromium.org>

Gerrit-Comment-Date: Mon, 20 Oct 2025 11:12:57 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Dominik Inführ (Gerrit)]

Dominik Inführ voted and added 2 comments

Votes added by Dominik Inführ

Commit-Queue

+2

2 comments

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Dominik Inführ . resolved

Thanks for the reviews!

File src/heap/mark-compact.cc

Line 4996, Patchset 7: if (heap_->IsGCWithStack()) {
if (!v8_flags.compact_with_stack) {

Michael Lippautz . resolved

Combine condition

Dominik Inführ

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Ib1626b30e1e8436513648c906ed4476f3cb6f77c

Gerrit-Change-Number: 6678594

Gerrit-PatchSet: 8

Gerrit-Owner: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Andreas Haas <ah...@google.com>

Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Comment-Date: Mon, 20 Oct 2025 11:20:04 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Michael Lippautz <mlip...@chromium.org>

[V8 LUCI CQ (Gerrit)]

V8 LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

7 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/heap/mark-compact.cc
Insertions: 3, Deletions: 5.

@@ -4993,11 +4993,9 @@
     ReportAbortedEvacuationCandidateDueToFlags(page);
   }
 
-  if (heap_->IsGCWithStack()) {
-    if (!v8_flags.compact_with_stack) {
-      for (PageMetadata* page : old_space_evacuation_pages_) {
-        ReportAbortedEvacuationCandidateDueToFlags(page);
-      }
+  if (heap_->IsGCWithStack() && !v8_flags.compact_with_stack) {
+    for (PageMetadata* page : old_space_evacuation_pages_) {
+      ReportAbortedEvacuationCandidateDueToFlags(page);
     }
   }
 
```

Change information

Commit message:

[execution, heap] Remove Isolate::InFastCCall()

Isolate::InFastCCall() simply returns whether the latest transition
from JS to native code was a regular CEntry or a fast API call. This
also used to be the only JS to native transition that could be a fast
API call. So Isolate::InFastCCall() would correctly report whether
there was a fast API call on the stack or not and this method was used
in this way. However, now that we allow JS calls from fast api calls,
it could return false even though there is an earlier fast API call
on the stack.

This CL removes this method to clean up this confusion. It also drops
--allow_allocation_in_fast_api_call as this is now fully supported
and enabled in V8.

Bug: 424905890

Change-Id: Ib1626b30e1e8436513648c906ed4476f3cb6f77c

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6678594

Reviewed-by: Andreas Haas <ah...@google.com>

Reviewed-by: Michael Lippautz <mlip...@chromium.org>

Commit-Queue: Dominik Inführ <dinf...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#103212}

Files:

• M src/execution/isolate-inl.h
• M src/execution/isolate.cc
• M src/execution/isolate.h
• M src/flags/flag-definitions.h
• M src/heap/cppgc-js/cpp-heap.cc
• M src/heap/cppgc-js/cpp-heap.h
• M src/heap/heap.cc
• M src/heap/main-allocator-inl.h
• M src/heap/main-allocator.cc
• M src/heap/mark-compact.cc
• M test/cctest/heap/test-heap.cc
• M test/cctest/test-api.cc

Change size: M

Delta: 12 files changed, 11 insertions(+), 44 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Michael Lippautz, +1 by Andreas Haas

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Ib1626b30e1e8436513648c906ed4476f3cb6f77c

Gerrit-Change-Number: 6678594

Gerrit-PatchSet: 9

Gerrit-Owner: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Andreas Haas <ah...@google.com>

Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-Reviewer: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>