[gcmole] Annotate codebase with V8_MAY_GC [v8/v8 : main]

0 views

Skip to first unread message

Leszek Swirski (Gerrit)

unread,

May 26, 2026, 4:08:29 AM (5 days ago) May 26

to les...@google.com, Hannes Payer, dmercadi...@chromium.org, v8-re...@googlegroups.com, oilpan-r...@chromium.org, pthier...@chromium.org, mlippau...@chromium.org, victorgo...@chromium.org, marja...@chromium.org, was...@google.com, cbruni...@chromium.org, jgrube...@chromium.org, devtools-...@chromium.org

Leszek Swirski has uploaded the change for review

Commit message

[gcmole] Annotate codebase with V8_MAY_GC

This CL adds V8_MAY_GC annotations to various methods and functions
across V8, as identified by the modern GCMole analysis tool.

It also adds `tools/gcmole/annotate.py` script that automates the process of
identifying and inserting annotations, and updates gcmole plugin to
support `--verify-annotations` check.

TAG=agy
CONV=6e030fdf-c1e4-448f-855a-7647e024b307
R=les...@google.com

Change-Id: Ib5d43def2b0714815599fdcb44a93c0bd88b2ccc

Change diff

Change information

Files:

M BUILD.gn
M include/v8-array-buffer.h
M include/v8-container.h
M include/v8-context.h
M include/v8-cpp-heap-external.h
M include/v8-cppgc.h
M include/v8-date.h
M include/v8-debug.h
M include/v8-exception.h
M include/v8-extension.h
M include/v8-external-memory-accounter.h
M include/v8-external.h
M include/v8-function-callback.h
M include/v8-function.h
M include/v8-isolate.h
M include/v8-json.h
M include/v8-locker.h
M include/v8-message.h
M include/v8-microtask-queue.h
M include/v8-object.h
M include/v8-platform.h
M include/v8-primitive-object.h
M include/v8-primitive.h
M include/v8-profiler.h
M include/v8-promise.h
M include/v8-proxy.h
M include/v8-regexp.h
M include/v8-script.h
M include/v8-snapshot.h
M include/v8-statistics.h
M include/v8-template.h
M include/v8-typed-array.h
M include/v8-value-serializer.h
M include/v8-value.h
M include/v8-wasm.h
M include/v8config.h
M src/api/api-arguments.h
M src/api/api-natives.cc
M src/api/api-natives.h
M src/api/api.cc
M src/api/api.h
M src/asmjs/asm-js.cc
M src/asmjs/asm-js.h
M src/ast/prettyprinter.h
M src/base/platform/platform.h
M src/builtins/accessors.cc
M src/builtins/accessors.h
M src/builtins/builtins-api.cc
M src/builtins/builtins-array.cc
M src/builtins/builtins-arraybuffer.cc
M src/builtins/builtins-async-disposable-stack.cc
M src/builtins/builtins-async-module.cc
M src/builtins/builtins-atomics-synchronization.cc
M src/builtins/builtins-bigint.cc
M src/builtins/builtins-callsite.cc
M src/builtins/builtins-collections.cc
M src/builtins/builtins-console.cc
M src/builtins/builtins-dataview.cc
M src/builtins/builtins-date.cc
M src/builtins/builtins-disposable-stack.cc
M src/builtins/builtins-error.cc
M src/builtins/builtins-function.cc
M src/builtins/builtins-global.cc
M src/builtins/builtins-internal.cc
M src/builtins/builtins-intl.cc
M src/builtins/builtins-iterator-inl.h
M src/builtins/builtins-iterator.h
M src/builtins/builtins-json.cc
M src/builtins/builtins-math.cc
M src/builtins/builtins-number.cc
M src/builtins/builtins-object.cc
M src/builtins/builtins-reflect.cc
M src/builtins/builtins-regexp.cc
M src/builtins/builtins-shadow-realm.cc
M src/builtins/builtins-shared-array.cc
M src/builtins/builtins-sharedarraybuffer.cc
M src/builtins/builtins-string.cc
M src/builtins/builtins-struct.cc
M src/builtins/builtins-symbol.cc
M src/builtins/builtins-trace.cc
M src/builtins/builtins-typed-array.cc
M src/builtins/builtins-weak-refs.cc
M src/builtins/builtins.h
M src/builtins/constants-table-builder.h
M src/builtins/setup-builtins-internal.cc
M src/codegen/background-merge-task.h
M src/codegen/compilation-cache.h
M src/codegen/compiler.cc
M src/codegen/compiler.h
M src/codegen/tick-counter.h
M src/compiler-dispatcher/lazy-compile-dispatcher.cc
M src/compiler-dispatcher/lazy-compile-dispatcher.h
M src/compiler-dispatcher/optimizing-compile-dispatcher.cc
M src/compiler-dispatcher/optimizing-compile-dispatcher.h
M src/compiler/access-info.cc
M src/compiler/access-info.h
M src/compiler/backend/code-generator.cc
M src/compiler/backend/code-generator.h
M src/compiler/backend/instruction-selector.h
M src/compiler/backend/register-allocator.h
M src/compiler/bytecode-graph-builder.cc
M src/compiler/bytecode-graph-builder.h
M src/compiler/code-assembler-compilation-job.h
M src/compiler/code-assembler.h
M src/compiler/compilation-dependencies.cc
M src/compiler/compilation-dependencies.h
M src/compiler/escape-analysis.cc
M src/compiler/escape-analysis.h
M src/compiler/fast-api-calls.cc
M src/compiler/fast-api-calls.h
M src/compiler/graph-assembler.cc
M src/compiler/graph-assembler.h
M src/compiler/graph-reducer.h
M src/compiler/js-call-reducer.cc
M src/compiler/js-call-reducer.h
M src/compiler/js-heap-broker.h
M src/compiler/js-inlining-heuristic.h
M src/compiler/js-inlining.h
M src/compiler/js-native-context-specialization.h
M src/compiler/js-typed-lowering.h
M src/compiler/loop-analysis.cc
M src/compiler/loop-analysis.h
M src/compiler/memory-lowering.h
M src/compiler/memory-optimizer.h
M src/compiler/pipeline.cc
M src/compiler/pipeline.h
M src/compiler/scheduler.cc
M src/compiler/scheduler.h
M src/compiler/select-lowering.h
M src/compiler/simplified-lowering.cc
M src/compiler/simplified-lowering.h
M src/compiler/turbofan-typer.h
M src/compiler/turbofan-types.h
M src/compiler/turboshaft/assert-types-reducer.h
M src/compiler/turboshaft/block-instrumentation-phase.h
M src/compiler/turboshaft/build-graph-phase.h
M src/compiler/turboshaft/builtin-compiler.h
M src/compiler/turboshaft/code-elimination-and-simplification-phase.h
M src/compiler/turboshaft/copying-phase.h
M src/compiler/turboshaft/csa-branch-elimination-phase.h
M src/compiler/turboshaft/csa-early-machine-optimization-phase.h
M src/compiler/turboshaft/csa-late-escape-analysis-phase.h
M src/compiler/turboshaft/csa-load-elimination-phase.h
M src/compiler/turboshaft/csa-memory-optimization-phase.h
M src/compiler/turboshaft/graph-builder.cc
M src/compiler/turboshaft/graph-builder.h
M src/compiler/turboshaft/instruction-selection-phase.h
M src/compiler/turboshaft/load-elimination-phase.h
M src/compiler/turboshaft/loop-peeling-phase.h
M src/compiler/turboshaft/loop-unrolling-phase.h
M src/compiler/turboshaft/machine-lowering-phase.h
M src/compiler/turboshaft/memory-optimization-phase.h
M src/compiler/turboshaft/pipelines.h
M src/compiler/turboshaft/register-allocation-phase.h
M src/compiler/turboshaft/type-assertions-phase.h
M src/compiler/turboshaft/typed-optimizations-phase.h
M src/compiler/turboshaft/types.h
M src/compiler/wasm-graph-assembler.h
M src/date/date.h
M src/debug/debug-coverage.h
M src/debug/debug-evaluate.cc
M src/debug/debug-evaluate.h
M src/debug/debug-frames.h
M src/debug/debug-interface.cc
M src/debug/debug-interface.h
M src/debug/debug-property-iterator.h
M src/debug/debug-scope-iterator.h
M src/debug/debug-scopes.h
M src/debug/debug-stack-trace-iterator.h
M src/debug/debug-wasm-objects.cc
M src/debug/debug-wasm-objects.h
M src/debug/debug.cc
M src/debug/debug.h
M src/debug/liveedit.cc
M src/debug/liveedit.h
M src/deoptimizer/deoptimized-frame-info.cc
M src/deoptimizer/deoptimizer.cc
M src/deoptimizer/deoptimizer.h
M src/deoptimizer/materialized-object-store.h
M src/deoptimizer/translated-state.h
M src/diagnostics/basic-block-profiler.cc
M src/diagnostics/basic-block-profiler.h
M src/execution/arguments.h
M src/execution/execution.cc
M src/execution/execution.h
M src/execution/frames.cc
M src/execution/frames.h
M src/execution/futex-emulation.cc
M src/execution/futex-emulation.h
M src/execution/isolate.cc
M src/execution/isolate.h
M src/execution/messages.cc
M src/execution/messages.h
M src/execution/microtask-queue.h
M src/execution/stack-guard.h
M src/execution/tiering-manager.h
M src/execution/v8threads.h
M src/extensions/cputracemark-extension.h
M src/extensions/externalize-string-extension.cc
M src/extensions/externalize-string-extension.h
M src/extensions/gc-extension.cc
M src/extensions/gc-extension.h
M src/extensions/statistics-extension.cc
M src/extensions/statistics-extension.h
M src/extensions/trigger-failure-extension.h
M src/handles/global-handles.h
M src/handles/local-handles.h
M src/handles/persistent-handles.h
M src/handles/traced-handles.cc
M src/handles/traced-handles.h
M src/heap/allocation-observer.h
M src/heap/array-buffer-sweeper.cc
M src/heap/array-buffer-sweeper.h
M src/heap/collection-barrier.cc
M src/heap/collection-barrier.h
M src/heap/concurrent-marking.cc
M src/heap/concurrent-marking.h
M src/heap/conservative-stack-visitor.h
M src/heap/cppgc-js/cpp-heap.cc
M src/heap/cppgc-js/cpp-heap.h
M src/heap/evacuation-allocator.h
M src/heap/factory-base.h
M src/heap/factory.cc
M src/heap/factory.h
M src/heap/finalization-registry-cleanup-task.h
M src/heap/gc-callbacks.h
M src/heap/gc-tracer.h
M src/heap/heap-allocator.h
M src/heap/heap.cc
M src/heap/heap.h
M src/heap/incremental-marking-job.cc
M src/heap/incremental-marking-job.h
M src/heap/incremental-marking.h
M src/heap/large-spaces.h
M src/heap/local-factory.h
M src/heap/local-heap.h
M src/heap/main-allocator.h
M src/heap/mark-compact.cc
M src/heap/mark-compact.h
M src/heap/memory-measurement.cc
M src/heap/memory-measurement.h
M src/heap/memory-reducer.h
M src/heap/minor-gc-job.cc
M src/heap/minor-mark-sweep.h
M src/heap/object-stats.cc
M src/heap/object-stats.h
M src/heap/parked-scope.h
M src/heap/read-only-heap.h
M src/heap/read-only-promotion.cc
M src/heap/read-only-promotion.h
M src/heap/safepoint.cc
M src/heap/safepoint.h
M src/heap/scavenger.cc
M src/heap/scavenger.h
M src/heap/sweeper.cc
M src/heap/sweeper.h
M src/heap/visit-object.cc
M src/heap/visit-object.h
M src/ic/handler-configuration.h
M src/ic/ic.cc
M src/ic/ic.h
M src/init/bootstrapper.cc
M src/init/bootstrapper.h
M src/init/setup-isolate.h
M src/interpreter/bytecode-generator.h
M src/json/json-parser.h
M src/json/json-stringifier.cc
M src/json/json-stringifier.h
M src/logging/log.h
M src/numbers/conversions.h
M src/numbers/math-random.h
M src/objects/allocation-site.h
M src/objects/backing-store.h
M src/objects/bigint.cc
M src/objects/bigint.h
M src/objects/call-site-info.cc
M src/objects/call-site-info.h
M src/objects/code.h
M src/objects/compilation-cache-table.cc
M src/objects/compilation-cache-table.h
M src/objects/contexts.cc
M src/objects/contexts.h
M src/objects/debug-objects.h
M src/objects/deoptimization-data.h
M src/objects/dictionary.h
M src/objects/elements.cc
M src/objects/elements.h
M src/objects/embedder-data-array.h
M src/objects/feedback-vector.h
M src/objects/fixed-array.h
M src/objects/intl-objects.cc
M src/objects/intl-objects.h
M src/objects/js-array-buffer.cc
M src/objects/js-array-buffer.h
M src/objects/js-array.h
M src/objects/js-atomics-synchronization.h
M src/objects/js-break-iterator.h
M src/objects/js-collator.cc
M src/objects/js-collator.h
M src/objects/js-collection.h
M src/objects/js-data-object-builder.h
M src/objects/js-date-time-format.cc
M src/objects/js-date-time-format.h
M src/objects/js-display-names.cc
M src/objects/js-display-names.h
M src/objects/js-disposable-stack.h
M src/objects/js-duration-format.cc
M src/objects/js-duration-format.h
M src/objects/js-function.cc
M src/objects/js-function.h
M src/objects/js-list-format.cc
M src/objects/js-list-format.h
M src/objects/js-locale.cc
M src/objects/js-locale.h
M src/objects/js-number-format.cc
M src/objects/js-number-format.h
M src/objects/js-objects.cc
M src/objects/js-objects.h
M src/objects/js-plural-rules.cc
M src/objects/js-plural-rules.h
M src/objects/js-promise.h
M src/objects/js-proxy.h
M src/objects/js-raw-json.h
M src/objects/js-regexp.h
M src/objects/js-relative-time-format.cc
M src/objects/js-relative-time-format.h
M src/objects/js-segment-iterator.h
M src/objects/js-segmenter.h
M src/objects/js-segments.h
M src/objects/js-struct.h
M src/objects/js-temporal-helpers.cc
M src/objects/js-temporal-helpers.h
M src/objects/js-weak-refs.h
M src/objects/keys.cc
M src/objects/keys.h
M src/objects/lookup-inl.h
M src/objects/lookup.h
M src/objects/managed.cc
M src/objects/managed.h
M src/objects/map-updater.h
M src/objects/map.cc
M src/objects/map.h
M src/objects/module.h
M src/objects/name.h
M src/objects/number-string-cache.h
M src/objects/objects-inl.h
M src/objects/objects.cc
M src/objects/objects.h
M src/objects/off-heap-hash-table.h
M src/objects/option-utils.h
M src/objects/ordered-hash-table.cc
M src/objects/ordered-hash-table.h
M src/objects/property-cell.h
M src/objects/property-descriptor.cc
M src/objects/property-descriptor.h
M src/objects/prototype.h
M src/objects/regexp-match-info.h
M src/objects/script.h
M src/objects/shared-function-info.h
M src/objects/source-text-module.h
M src/objects/string-inl.h
M src/objects/string-table.cc
M src/objects/string-table.h
M src/objects/string.h
M src/objects/struct.h
M src/objects/synthetic-module.h
M src/objects/template-objects.cc
M src/objects/template-objects.h
M src/objects/templates.cc
M src/objects/templates.h
M src/objects/transitions.h
M src/objects/value-serializer.cc
M src/objects/value-serializer.h
M src/objects/visitors.h
M src/parsing/parsing.h
M src/parsing/pending-compilation-error-handler.h
M src/parsing/scanner-character-streams.h
M src/profiler/heap-profiler.h
M src/profiler/heap-snapshot-generator.cc
M src/profiler/heap-snapshot-generator.h
M src/profiler/sampling-heap-profiler.h
M src/profiler/tracing-cpu-profiler.cc
M src/profiler/tracing-cpu-profiler.h
M src/regexp/experimental/experimental-interpreter.cc
M src/regexp/experimental/experimental-interpreter.h
M src/regexp/experimental/experimental.cc
M src/regexp/experimental/experimental.h
M src/regexp/regexp-bytecode-generator.h
M src/regexp/regexp-bytecode-peephole.h
M src/regexp/regexp-code-generator.h
M src/regexp/regexp-compiler.cc
M src/regexp/regexp-compiler.h
M src/regexp/regexp-interpreter.cc
M src/regexp/regexp-interpreter.h
M src/regexp/regexp-macro-assembler.cc
M src/regexp/regexp-macro-assembler.h
M src/regexp/regexp-nodes.h
M src/regexp/regexp-utils.h
M src/regexp/regexp.cc
M src/regexp/regexp.h
M src/regexp/x64/regexp-macro-assembler-x64.h
M src/roots/roots.h
M src/runtime/runtime-array.cc
M src/runtime/runtime-atomics.cc
M src/runtime/runtime-bigint.cc
M src/runtime/runtime-classes.cc
M src/runtime/runtime-collections.cc
M src/runtime/runtime-compiler.cc
M src/runtime/runtime-date.cc
M src/runtime/runtime-debug.cc
M src/runtime/runtime-forin.cc
M src/runtime/runtime-function.cc
M src/runtime/runtime-futex.cc
M src/runtime/runtime-generator.cc
M src/runtime/runtime-internal.cc
M src/runtime/runtime-intl.cc
M src/runtime/runtime-literals.cc
M src/runtime/runtime-module.cc
M src/runtime/runtime-numbers.cc
M src/runtime/runtime-object.cc
M src/runtime/runtime-operators.cc
M src/runtime/runtime-promise.cc
M src/runtime/runtime-proxy.cc
M src/runtime/runtime-regexp.cc
M src/runtime/runtime-scopes.cc
M src/runtime/runtime-shadow-realm.cc
M src/runtime/runtime-strings.cc
M src/runtime/runtime-symbol.cc
M src/runtime/runtime-test-wasm.cc
M src/runtime/runtime-test.cc
M src/runtime/runtime-typedarray.cc
M src/runtime/runtime-wasm.cc
M src/runtime/runtime-weak-refs.cc
M src/runtime/runtime.h
M src/sandbox/sandboxable-thread.h
M src/sandbox/testing.cc
M src/sandbox/testing.h
M src/snapshot/code-serializer.cc
M src/snapshot/code-serializer.h
M src/snapshot/context-serializer.h
M src/snapshot/deserializer.cc
M src/snapshot/deserializer.h
M src/snapshot/read-only-serializer.cc
M src/snapshot/roots-serializer.h
M src/snapshot/serializer-deserializer.cc
M src/snapshot/serializer-deserializer.h
M src/snapshot/serializer.h
M src/snapshot/shared-heap-deserializer.h
M src/snapshot/shared-heap-serializer.cc
M src/snapshot/shared-heap-serializer.h
M src/snapshot/snapshot.cc
M src/snapshot/snapshot.h
M src/snapshot/startup-deserializer.h
M src/snapshot/startup-serializer.h
M src/strings/string-builder.h
M src/strings/string-stream.h
M src/strings/uri.cc
M src/strings/uri.h
M src/tasks/cancelable-task.h
M src/utils/identity-map.h
M src/wasm/canonical-types.h
M src/wasm/compilation-environment.h
M src/wasm/constant-expression-interface.h
M src/wasm/constant-expression.h
M src/wasm/function-compiler.h
M src/wasm/module-compiler.cc
M src/wasm/module-compiler.h
M src/wasm/module-decoder-impl.h
M src/wasm/module-decoder.h
M src/wasm/module-instantiate.cc
M src/wasm/module-instantiate.h
M src/wasm/stacks.h
M src/wasm/streaming-decoder.cc
M src/wasm/streaming-decoder.h
M src/wasm/sync-streaming-decoder.cc
M src/wasm/wasm-code-manager.h
M src/wasm/wasm-debug.cc
M src/wasm/wasm-disassembler-impl.h
M src/wasm/wasm-disassembler.h
M src/wasm/wasm-engine.cc
M src/wasm/wasm-engine.h
M src/wasm/wasm-export-wrapper-cache.h
M src/wasm/wasm-import-wrapper-cache.h
M src/wasm/wasm-js.cc
M src/wasm/wasm-js.h
M src/wasm/wasm-module.h
M src/wasm/wasm-objects.cc
M src/wasm/wasm-objects.h
M src/wasm/wasm-result.h
M src/wasm/wasm-serialization.h
M src/wasm/wasm-wrapper-cache.h
M test/cctest/heap/heap-tester.h
M test/cctest/heap/heap-utils.h
M test/cctest/test-api.cc
M test/cctest/test-cpu-profiler.cc
M test/cctest/test-debug-helper.cc
M test/cctest/test-disasm-regex-helper.cc
M test/cctest/test-disasm-regex-helper.h
M test/cctest/test-field-type-tracking.cc
M test/cctest/test-inobject-slack-tracking.cc
M test/cctest/test-js-weak-refs.cc
M test/cctest/test-liveedit.cc
M test/cctest/test-lockers.cc
M test/cctest/test-log-stack-tracer.cc
M test/cctest/test-mementos.cc
M test/cctest/test-orderedhashtable.cc
M test/cctest/test-profile-generator.cc
M test/cctest/test-ptr-compr-cage.cc
M test/cctest/test-random-number-generator.cc
M test/cctest/test-shared-strings.cc
M test/cctest/test-strings.cc
M test/cctest/test-swiss-name-dictionary-infra.h
M test/cctest/test-swiss-name-dictionary.cc
M test/cctest/test-transitions.cc
M test/cctest/test-typedarrays.cc
M test/cctest/test-unwinder-code-pages.cc
M test/common/wasm/wasm-run-utils.h
A tools/gcmole/annotate.py
M tools/gcmole/gcmole-test.cc
M tools/gcmole/gcmole.cc
M tools/gcmole/gcmole.py

Change size: XL

Delta: 521 files changed, 7608 insertions(+), 7284 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages