Dominik Inführ (Gerrit)

unread,

Mar 4, 2026, 12:46:36 PMMar 4

to Michael Lippautz, V8 LUCI CQ, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com

Attention needed from Michael Lippautz

Dominik Inführ added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Dominik Inführ . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

Michael Lippautz

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Michael Lippautz (Gerrit)

unread,

Mar 5, 2026, 4:24:19 AMMar 5

to Dominik Inführ, V8 LUCI CQ, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com

Attention needed from Dominik Inführ

Michael Lippautz voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Dominik Inführ

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Dominik Inführ (Gerrit)

unread,

Mar 5, 2026, 4:44:48 AMMar 5

to Michael Lippautz, V8 LUCI CQ, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com

Dominik Inführ voted and added 1 comment

Votes added by Dominik Inführ

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Dominik Inführ . resolved

Thanks for the review!

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Dominik Inführ (Gerrit)

unread,

Mar 5, 2026, 5:47:09 AMMar 5

to Michael Lippautz, V8 LUCI CQ, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com

Dominik Inführ voted

Code-Review	+0
Commit-Queue	+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

V8 LUCI CQ (Gerrit)

unread,

Mar 5, 2026, 6:25:12 AMMar 5

to Dominik Inführ, Michael Lippautz, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:

[profiler] Move cppgc roots below GC roots in heap snapshot

This makes cppgc roots uniform with other V8 GC roots.

Change-Id: I27eed52a938e37e49a97d4c24b3a396dab20abb9

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7631935

Reviewed-by: Michael Lippautz <mlip...@chromium.org>

Commit-Queue: Dominik Inführ <dinf...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#105608}

Files:

M src/profiler/heap-snapshot-generator.cc
M test/cctest/test-heap-profiler.cc
M test/unittests/heap/cppgc-js/unified-heap-snapshot-unittest.cc

Change size: M

Delta: 3 files changed, 58 insertions(+), 36 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +0 by Dominik Inführ, +1 by Michael Lippautz

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[profiler] Move cppgc roots below GC roots in heap snapshot [v8/v8 : main]

Dominik Inführ (Gerrit)

Dominik Inführ added 1 comment

Related details

Michael Lippautz (Gerrit)

Michael Lippautz voted Code-Review+1

Related details

Dominik Inführ (Gerrit)

Dominik Inführ voted and added 1 comment

Votes added by Dominik Inführ

1 comment

Related details

Dominik Inführ (Gerrit)

Dominik Inführ voted

Related details

V8 LUCI CQ (Gerrit)

V8 LUCI CQ submitted the change

Change information