[heap] Enable cppgc_enable_object_names by default on Desktop [v8/v8 : main]
0 views
Skip to first unread message
Dominik Inführ (Gerrit)
May 20, 2026, 4:18:22 PM (11 days ago) May 20
to Michael Lippautz, chrom...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
May 21, 2026, 6:55:10 AM (10 days ago) May 21
to Dominik Inführ, chrom...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Michael Lippautz added 1 comment![]( "Open in Gerrit")
File include/cppgc/internal/pointer-policies.h
Line 212, Patchset 5 (Latest):
constexpr KeepLocationPolicy() = default;Michael Lippautz . unresolved
I think this one may actually be expensive. `cppgc::Persistent` is used all over the place in Blink and this one adds one field that affects copy/move.
Can we separate this part out?
Alternatively, try running benchmarks :)
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
May 21, 2026, 7:27:44 AM (10 days ago) May 21
to Michael Lippautz, chrom...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Dominik Inführ added 1 comment![]( "Open in Gerrit")
File include/cppgc/internal/pointer-policies.h
Line 212, Patchset 5 (Latest):
constexpr KeepLocationPolicy() = default;Michael Lippautz . unresolved
I think this one may actually be expensive. `cppgc::Persistent` is used all over the place in Blink and this one adds one field that affects copy/move.
Can we separate this part out?
Alternatively, try running benchmarks :)
Dominik Inführ
I did, see [0] and [1] for the results. The change looks neutral to me.
0: https://pinpoint-dot-chromeperf.appspot.com/job/100aeb1b890000
1: https://pinpoint-dot-chromeperf.appspot.com/job/111f89bb890000
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
May 21, 2026, 7:28:02 AM (10 days ago) May 21
to Michael Lippautz, chrom...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Dominik Inführ added 1 comment![]( "Open in Gerrit")
File include/cppgc/internal/pointer-policies.h
Line 212, Patchset 5 (Latest):
constexpr KeepLocationPolicy() = default;Michael Lippautz . unresolved
Dominik InführI think this one may actually be expensive. `cppgc::Persistent` is used all over the place in Blink and this one adds one field that affects copy/move.
Can we separate this part out?
Alternatively, try running benchmarks :)
I did, see [0] and [1] for the results. The change looks neutral to me.
0: https://pinpoint-dot-chromeperf.appspot.com/job/100aeb1b890000
1: https://pinpoint-dot-chromeperf.appspot.com/job/111f89bb890000
Dominik Inführ
Wdyt?
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
May 21, 2026, 7:36:43 AM (10 days ago) May 21
to Dominik Inführ, chrom...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Michael Lippautz voted and added 2 comments![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
2 comments
Patchset-level comments
File include/cppgc/internal/pointer-policies.h
Line 212, Patchset 5 (Latest):
constexpr KeepLocationPolicy() = default;Michael Lippautz . resolved
Dominik InführI think this one may actually be expensive. `cppgc::Persistent` is used all over the place in Blink and this one adds one field that affects copy/move.
Can we separate this part out?
Alternatively, try running benchmarks :)
Dominik InführI did, see [0] and [1] for the results. The change looks neutral to me.
0: https://pinpoint-dot-chromeperf.appspot.com/job/100aeb1b890000
1: https://pinpoint-dot-chromeperf.appspot.com/job/111f89bb890000
Wdyt?
Michael Lippautz
JetStream should never be affected by this.
Speedometer may be, and other benchmarks people use (DOM bindings stuff) maybe be. I guess we can just try and see what happens. Worst case we revert the changes for the location policy.
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
May 21, 2026, 8:10:41 AM (10 days ago) May 21
to Michael Lippautz, chrom...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Dominik Inführ . resolved
Thanks for the review! Let's try and see..
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
May 21, 2026, 8:53:06 AM (10 days ago) May 21
to Dominik Inführ, Michael Lippautz, chrom...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[heap] Enable cppgc_enable_object_names by default on Desktop
This CL initially enables this "gn arg" on Desktop platforms. Android
and Fuchsia can be enabled later as well.
Bug: 497855658
Change-Id: I09696c4df93f403a7eff349a74037e1ee167a557
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Dominik Inführ <dinf...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#107492}
Files:
- M gni/v8.gni
- M include/cppgc/cross-thread-persistent.h
- M include/cppgc/internal/pointer-policies.h
- M include/cppgc/visitor.h
Change size: S
Delta: 4 files changed, 28 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
May 21, 2026, 11:15:13 AM (10 days ago) May 21
to v8-s...@luci-project-accounts.iam.gserviceaccount.com, Dominik Inführ, Michael Lippautz, chrom...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Clemens Backes added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Clemens Backes . unresolved
Is this CL the reason for this failure?
https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20-%20official/14106/overview
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
May 21, 2026, 12:06:33 PM (10 days ago) May 21
to v8-s...@luci-project-accounts.iam.gserviceaccount.com, Dominik Inführ, Clemens Backes, chrom...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Michael Lippautz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Clemens Backes . unresolved
Is this CL the reason for this failure?
https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20-%20official/14106/overview
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
May 21, 2026, 12:29:01 PM (10 days ago) May 21
to v8-s...@luci-project-accounts.iam.gserviceaccount.com, Dominik Inführ, Michael Lippautz, chrom...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Clemens Backes added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Clemens Backes . unresolved
Michael LippautzIs this CL the reason for this failure?
https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20-%20official/14106/overview
Likely, yes
Clemens Backes
We should revert then. This is closing the tree.
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
May 21, 2026, 1:40:00 PM (10 days ago) May 21
to v8-s...@luci-project-accounts.iam.gserviceaccount.com, Dominik Inführ, Clemens Backes, Michael Lippautz, chrom...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Leszek Swirski has created a revert of this change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
May 22, 2026, 7:14:37 AM (9 days ago) May 22
to Michael Lippautz, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Dominik Inführ added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
May 22, 2026, 7:16:26 AM (9 days ago) May 22
to Dominik Inführ, v8-s...@luci-project-accounts.iam.gserviceaccount.com, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Michael Lippautz voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
May 22, 2026, 7:41:40 AM (9 days ago) May 22
to Michael Lippautz, v8-s...@luci-project-accounts.iam.gserviceaccount.com, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
May 22, 2026, 12:39:19 PM (9 days ago) May 22
to Michael Lippautz, v8-s...@luci-project-accounts.iam.gserviceaccount.com, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Dominik Inführ voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
May 22, 2026, 12:41:26 PM (9 days ago) May 22
to Dominik Inführ, Michael Lippautz, oilpan-r...@chromium.org, v8-re...@googlegroups.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[heap] Enable cppgc_enable_object_names by default on Desktop
https://crrev.com/c/7807042 already tried to update this "gn arg"
but got reverted. This CL fixes the failing test now. The ASAN fixes
landed separately in https://crrev.com/c/7865927.
Bug: 497855658
Change-Id: I683a9a699f1475b47631d53ba15456910a7553b3
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Dominik Inführ <dinf...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#107529}
Files:
- M gni/v8.gni
- M test/unittests/heap/cppgc/name-trait-unittest.cc
Change size: S
Delta: 2 files changed, 8 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages