[api] Start deprecation of v8::HeapProfile::ObjectNameResolver [v8/v8 : main]

0 views
Skip to first unread message

Igor Sheludko (Gerrit)

unread,
Sep 18, 2025, 4:28:32 AM (13 days ago) Sep 18
to AyeAye, V8 LUCI CQ, Michael Lippautz, oilpan-r...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz

Igor Sheludko voted and added 1 comment

Votes added by Igor Sheludko

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Igor Sheludko . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I0995cf892c663b3b21e7f83f79e1ce81c4bd9d9e
Gerrit-Change-Number: 6909452
Gerrit-PatchSet: 5
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Sep 2025 08:28:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
Sep 18, 2025, 4:29:05 AM (13 days ago) Sep 18
to Igor Sheludko, AyeAye, V8 LUCI CQ, oilpan-r...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Igor Sheludko

Michael Lippautz voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Igor Sheludko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I0995cf892c663b3b21e7f83f79e1ce81c4bd9d9e
Gerrit-Change-Number: 6909452
Gerrit-PatchSet: 5
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Attention: Igor Sheludko <ish...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Sep 2025 08:29:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Sep 18, 2025, 5:08:10 AM (13 days ago) Sep 18
to Igor Sheludko, Michael Lippautz, AyeAye, oilpan-r...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[api] Start deprecation of v8::HeapProfile::ObjectNameResolver
Bug: 333672197
Change-Id: I0995cf892c663b3b21e7f83f79e1ce81c4bd9d9e
Auto-Submit: Igor Sheludko <ish...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Commit-Queue: Michael Lippautz <mlip...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102582}
Files:
  • M include/v8-profiler.h
  • M src/profiler/heap-profiler.cc
  • M test/cctest/test-heap-profiler.cc
  • M test/unittests/heap/cppgc-js/unified-heap-snapshot-unittest.cc
Change size: S
Delta: 4 files changed, 26 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Michael Lippautz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I0995cf892c663b3b21e7f83f79e1ce81c4bd9d9e
Gerrit-Change-Number: 6909452
Gerrit-PatchSet: 6
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages