PCScan: Try delayed tasks [chromium/src : main]

0 views
Skip to first unread message

Anton Bikineev (Gerrit)

unread,
Apr 15, 2021, 8:24:00 AM4/15/21
to kouhe...@chromium.org, lizeb...@chromium.org, oilpan-...@chromium.org, vmpstr...@chromium.org, wfh+...@chromium.org, chromium...@chromium.org, Kentaro Hara

View Change

1 comment:

  • File base/allocator/partition_allocator/starscan/pcscan.cc:

    • Patch Set #1, Line 1518: PlatformThread::Sleep(delay);

      note: waiting on the condvar would have been better here, if another thread wants to signal to start immediate scanning.

To view, visit change 2827896. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I746653effe2fd241904b31ef838a7a1af6aad8a0
Gerrit-Change-Number: 2827896
Gerrit-PatchSet: 1
Gerrit-Owner: Anton Bikineev <biki...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Comment-Date: Thu, 15 Apr 2021 12:23:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Anton Bikineev (Gerrit)

unread,
Apr 15, 2021, 8:25:04 AM4/15/21
to kouhe...@chromium.org, lizeb...@chromium.org, oilpan-...@chromium.org, vmpstr...@chromium.org, wfh+...@chromium.org, chromium...@chromium.org, Kentaro Hara

View Change

1 comment:

  • File base/allocator/partition_allocator/starscan/pcscan.cc:

To view, visit change 2827896. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I746653effe2fd241904b31ef838a7a1af6aad8a0
Gerrit-Change-Number: 2827896
Gerrit-PatchSet: 1
Gerrit-Owner: Anton Bikineev <biki...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Comment-Date: Thu, 15 Apr 2021 12:24:55 +0000

Mike Frysinger (Gerrit)

unread,
Jan 5, 2026, 7:40:17 PM (12 days ago) Jan 5
to Anton Bikineev, chromium...@chromium.org, Kentaro Hara, kouhe...@chromium.org, lizeb...@chromium.org, oilpan-...@chromium.org, vmpstr...@chromium.org, wfh+...@chromium.org

Mike Frysinger abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages